2022-04-29 22:03:34 -04:00
|
|
|
use core::fmt::Debug;
|
2022-04-30 04:32:19 -04:00
|
|
|
use std::{rc::Rc, cell::RefCell};
|
2022-04-29 22:03:34 -04:00
|
|
|
|
2022-05-06 07:33:08 -04:00
|
|
|
use rand_core::{RngCore, CryptoRng, SeedableRng};
|
|
|
|
|
use rand_chacha::ChaCha12Rng;
|
2022-04-21 21:36:18 -04:00
|
|
|
|
|
|
|
|
use curve25519_dalek::{
|
|
|
|
|
constants::ED25519_BASEPOINT_TABLE,
|
2022-04-29 22:03:34 -04:00
|
|
|
traits::Identity,
|
2022-04-21 21:36:18 -04:00
|
|
|
scalar::Scalar,
|
|
|
|
|
edwards::EdwardsPoint
|
|
|
|
|
};
|
|
|
|
|
|
2022-05-03 07:20:24 -04:00
|
|
|
use monero::util::ringct::{Key, Clsag};
|
|
|
|
|
|
2022-04-21 21:36:18 -04:00
|
|
|
use group::Group;
|
2022-05-03 07:20:24 -04:00
|
|
|
|
|
|
|
|
use transcript::Transcript as TranscriptTrait;
|
2022-05-17 19:15:53 -04:00
|
|
|
use frost::{FrostError, algorithm::Algorithm, MultisigView};
|
2022-05-03 08:49:46 -04:00
|
|
|
use dalek_ff_group as dfg;
|
2022-04-21 21:36:18 -04:00
|
|
|
|
|
|
|
|
use crate::{
|
|
|
|
|
hash_to_point,
|
2022-05-17 19:15:53 -04:00
|
|
|
frost::{Transcript, MultisigError, Ed25519, DLEqProof, read_dleq},
|
2022-04-28 17:29:56 -04:00
|
|
|
clsag::{Input, sign_core, verify}
|
2022-04-21 21:36:18 -04:00
|
|
|
};
|
|
|
|
|
|
2022-05-03 07:20:24 -04:00
|
|
|
impl Input {
|
2022-05-06 01:35:23 -04:00
|
|
|
fn transcript<T: TranscriptTrait>(&self, transcript: &mut T) {
|
2022-05-06 07:33:08 -04:00
|
|
|
// Doesn't domain separate as this is considered part of the larger CLSAG proof
|
2022-05-06 01:35:23 -04:00
|
|
|
|
2022-05-03 07:20:24 -04:00
|
|
|
// Ring index
|
2022-05-06 19:07:37 -04:00
|
|
|
transcript.append_message(b"ring_index", &[self.decoys.i]);
|
2022-05-03 07:20:24 -04:00
|
|
|
|
|
|
|
|
// Ring
|
|
|
|
|
let mut ring = vec![];
|
2022-05-06 19:07:37 -04:00
|
|
|
for pair in &self.decoys.ring {
|
2022-05-03 07:20:24 -04:00
|
|
|
// Doesn't include global output indexes as CLSAG doesn't care and won't be affected by it
|
2022-05-06 19:07:37 -04:00
|
|
|
// They're just a unreliable reference to this data which will be included in the message
|
|
|
|
|
// if in use
|
2022-05-03 07:20:24 -04:00
|
|
|
ring.extend(&pair[0].compress().to_bytes());
|
|
|
|
|
ring.extend(&pair[1].compress().to_bytes());
|
|
|
|
|
}
|
|
|
|
|
transcript.append_message(b"ring", &ring);
|
|
|
|
|
|
|
|
|
|
// Doesn't include the commitment's parts as the above ring + index includes the commitment
|
|
|
|
|
// The only potential malleability would be if the G/H relationship is known breaking the
|
|
|
|
|
// discrete log problem, which breaks everything already
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-05-06 19:07:37 -04:00
|
|
|
// pub to enable testing
|
|
|
|
|
// While we could move the CLSAG test inside this crate, that'd require duplicating the FROST test
|
|
|
|
|
// helper, and isn't worth doing right now when this is harmless enough (semver? TODO)
|
|
|
|
|
#[derive(Clone, Debug)]
|
|
|
|
|
pub struct Details {
|
|
|
|
|
input: Input,
|
|
|
|
|
mask: Scalar
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl Details {
|
|
|
|
|
pub fn new(input: Input, mask: Scalar) -> Details {
|
|
|
|
|
Details { input, mask }
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-04-21 21:36:18 -04:00
|
|
|
#[allow(non_snake_case)]
|
|
|
|
|
#[derive(Clone, Debug)]
|
2022-05-06 19:07:37 -04:00
|
|
|
struct Interim {
|
2022-05-13 20:26:29 -04:00
|
|
|
p: Scalar,
|
2022-04-21 21:36:18 -04:00
|
|
|
c: Scalar,
|
|
|
|
|
|
|
|
|
|
clsag: Clsag,
|
2022-05-13 20:26:29 -04:00
|
|
|
pseudo_out: EdwardsPoint
|
2022-04-21 21:36:18 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[allow(non_snake_case)]
|
|
|
|
|
#[derive(Clone, Debug)]
|
2022-04-30 04:32:19 -04:00
|
|
|
pub struct Multisig {
|
2022-05-06 07:33:08 -04:00
|
|
|
transcript: Transcript,
|
|
|
|
|
|
2022-05-17 19:15:53 -04:00
|
|
|
H: EdwardsPoint,
|
|
|
|
|
// Merged here as CLSAG needs it, passing it would be a mess, yet having it beforehand requires a round
|
2022-05-03 07:20:24 -04:00
|
|
|
image: EdwardsPoint,
|
2022-04-29 22:03:34 -04:00
|
|
|
AH: (dfg::EdwardsPoint, dfg::EdwardsPoint),
|
2022-04-21 21:36:18 -04:00
|
|
|
|
2022-05-06 19:07:37 -04:00
|
|
|
details: Rc<RefCell<Option<Details>>>,
|
2022-04-29 22:03:34 -04:00
|
|
|
|
2022-05-18 00:53:13 -04:00
|
|
|
msg: Option<[u8; 32]>,
|
2022-05-06 19:07:37 -04:00
|
|
|
interim: Option<Interim>
|
2022-04-21 21:36:18 -04:00
|
|
|
}
|
|
|
|
|
|
2022-04-30 04:32:19 -04:00
|
|
|
impl Multisig {
|
2022-04-29 15:28:04 -04:00
|
|
|
pub fn new(
|
2022-05-06 07:33:08 -04:00
|
|
|
transcript: Transcript,
|
2022-05-18 00:53:13 -04:00
|
|
|
details: Rc<RefCell<Option<Details>>>
|
2022-04-30 04:32:19 -04:00
|
|
|
) -> Result<Multisig, MultisigError> {
|
2022-04-21 21:36:18 -04:00
|
|
|
Ok(
|
|
|
|
|
Multisig {
|
2022-05-06 07:33:08 -04:00
|
|
|
transcript,
|
|
|
|
|
|
2022-05-17 19:15:53 -04:00
|
|
|
H: EdwardsPoint::identity(),
|
2022-05-03 07:20:24 -04:00
|
|
|
image: EdwardsPoint::identity(),
|
2022-04-29 22:03:34 -04:00
|
|
|
AH: (dfg::EdwardsPoint::identity(), dfg::EdwardsPoint::identity()),
|
2022-04-21 21:36:18 -04:00
|
|
|
|
2022-05-06 19:07:37 -04:00
|
|
|
details,
|
2022-04-30 01:43:15 -04:00
|
|
|
|
2022-05-18 00:53:13 -04:00
|
|
|
msg: None,
|
2022-04-21 21:36:18 -04:00
|
|
|
interim: None
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
}
|
2022-04-30 04:32:19 -04:00
|
|
|
|
|
|
|
|
pub fn serialized_len() -> usize {
|
|
|
|
|
3 * (32 + 64)
|
|
|
|
|
}
|
2022-05-06 19:07:37 -04:00
|
|
|
|
|
|
|
|
fn input(&self) -> Input {
|
|
|
|
|
self.details.borrow().as_ref().unwrap().input.clone()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn mask(&self) -> Scalar {
|
|
|
|
|
self.details.borrow().as_ref().unwrap().mask
|
|
|
|
|
}
|
2022-04-21 21:36:18 -04:00
|
|
|
}
|
|
|
|
|
|
2022-04-30 04:32:19 -04:00
|
|
|
impl Algorithm<Ed25519> for Multisig {
|
2022-05-03 07:20:24 -04:00
|
|
|
type Transcript = Transcript;
|
2022-04-21 21:36:18 -04:00
|
|
|
type Signature = (Clsag, EdwardsPoint);
|
|
|
|
|
|
|
|
|
|
fn preprocess_addendum<R: RngCore + CryptoRng>(
|
2022-05-17 19:15:53 -04:00
|
|
|
&mut self,
|
2022-04-21 21:36:18 -04:00
|
|
|
rng: &mut R,
|
2022-04-30 04:32:19 -04:00
|
|
|
view: &MultisigView<Ed25519>,
|
2022-04-21 21:36:18 -04:00
|
|
|
nonces: &[dfg::Scalar; 2]
|
|
|
|
|
) -> Vec<u8> {
|
2022-05-17 19:15:53 -04:00
|
|
|
self.H = hash_to_point(&view.group_key().0);
|
2022-04-30 01:43:15 -04:00
|
|
|
|
2022-04-30 04:32:19 -04:00
|
|
|
let mut serialized = Vec::with_capacity(Multisig::serialized_len());
|
2022-05-17 19:15:53 -04:00
|
|
|
serialized.extend((view.secret_share().0 * self.H).compress().to_bytes());
|
2022-05-17 19:51:04 -04:00
|
|
|
serialized.extend(DLEqProof::prove(rng, &self.H, &view.secret_share().0).serialize());
|
2022-05-17 19:15:53 -04:00
|
|
|
|
|
|
|
|
serialized.extend((nonces[0].0 * self.H).compress().to_bytes());
|
2022-05-17 19:51:04 -04:00
|
|
|
serialized.extend(&DLEqProof::prove(rng, &self.H, &nonces[0].0).serialize());
|
2022-05-17 19:15:53 -04:00
|
|
|
serialized.extend((nonces[1].0 * self.H).compress().to_bytes());
|
2022-05-17 19:51:04 -04:00
|
|
|
serialized.extend(&DLEqProof::prove(rng, &self.H, &nonces[1].0).serialize());
|
2022-04-21 21:36:18 -04:00
|
|
|
serialized
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn process_addendum(
|
|
|
|
|
&mut self,
|
2022-04-30 04:32:19 -04:00
|
|
|
view: &MultisigView<Ed25519>,
|
2022-04-21 21:36:18 -04:00
|
|
|
l: usize,
|
|
|
|
|
commitments: &[dfg::EdwardsPoint; 2],
|
|
|
|
|
serialized: &[u8]
|
|
|
|
|
) -> Result<(), FrostError> {
|
2022-04-30 04:32:19 -04:00
|
|
|
if serialized.len() != Multisig::serialized_len() {
|
2022-04-21 21:36:18 -04:00
|
|
|
// Not an optimal error but...
|
2022-04-30 01:43:15 -04:00
|
|
|
Err(FrostError::InvalidCommitmentQuantity(l, 9, serialized.len() / 32))?;
|
2022-04-21 21:36:18 -04:00
|
|
|
}
|
|
|
|
|
|
2022-05-17 19:15:53 -04:00
|
|
|
if self.AH.0.is_identity().into() {
|
2022-05-06 07:33:08 -04:00
|
|
|
self.transcript.domain_separate(b"CLSAG");
|
2022-05-06 19:07:37 -04:00
|
|
|
self.input().transcript(&mut self.transcript);
|
|
|
|
|
self.transcript.append_message(b"mask", &self.mask().to_bytes());
|
2022-05-06 07:33:08 -04:00
|
|
|
}
|
|
|
|
|
|
2022-05-17 19:15:53 -04:00
|
|
|
let share = read_dleq(
|
|
|
|
|
serialized,
|
|
|
|
|
0,
|
|
|
|
|
&self.H,
|
|
|
|
|
l,
|
|
|
|
|
&view.verification_share(l).0
|
|
|
|
|
).map_err(|_| FrostError::InvalidCommitment(l))?.0;
|
2022-05-06 07:33:08 -04:00
|
|
|
// Given the fact there's only ever one possible value for this, this may technically not need
|
|
|
|
|
// to be committed to. If signing a TX, it'll be double committed to thanks to the message
|
|
|
|
|
// It doesn't hurt to have though and ensures security boundaries are well formed
|
|
|
|
|
self.transcript.append_message(b"image_share", &share.compress().to_bytes());
|
2022-04-30 01:43:15 -04:00
|
|
|
self.image += share;
|
|
|
|
|
|
2022-05-03 07:20:24 -04:00
|
|
|
// Uses the same format FROST does for the expected commitments (nonce * G where this is nonce * H)
|
2022-05-06 07:33:08 -04:00
|
|
|
// Given this is guaranteed to match commitments, which FROST commits to, this also technically
|
|
|
|
|
// doesn't need to be committed to if a canonical serialization is guaranteed
|
|
|
|
|
// It, again, doesn't hurt to include and ensures security boundaries are well formed
|
2022-05-06 07:49:18 -04:00
|
|
|
self.transcript.append_message(b"participant", &u16::try_from(l).unwrap().to_be_bytes());
|
2022-04-21 21:36:18 -04:00
|
|
|
|
2022-05-17 19:15:53 -04:00
|
|
|
self.transcript.append_message(b"commitment_D_H", &serialized[0 .. 32]);
|
|
|
|
|
self.AH.0 += read_dleq(serialized, 96, &self.H, l, &commitments[0]).map_err(|_| FrostError::InvalidCommitment(l))?;
|
|
|
|
|
self.transcript.append_message(b"commitment_E_H", &serialized[0 .. 32]);
|
|
|
|
|
self.AH.1 += read_dleq(serialized, 192, &self.H, l, &commitments[1]).map_err(|_| FrostError::InvalidCommitment(l))?;
|
2022-04-21 21:36:18 -04:00
|
|
|
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
2022-05-06 07:33:08 -04:00
|
|
|
fn transcript(&mut self) -> &mut Self::Transcript {
|
|
|
|
|
&mut self.transcript
|
2022-04-29 15:28:04 -04:00
|
|
|
}
|
|
|
|
|
|
2022-04-21 21:36:18 -04:00
|
|
|
fn sign_share(
|
|
|
|
|
&mut self,
|
2022-04-30 04:32:19 -04:00
|
|
|
view: &MultisigView<Ed25519>,
|
2022-04-21 21:36:18 -04:00
|
|
|
nonce_sum: dfg::EdwardsPoint,
|
2022-04-29 22:03:34 -04:00
|
|
|
b: dfg::Scalar,
|
2022-04-23 03:49:30 -04:00
|
|
|
nonce: dfg::Scalar,
|
2022-05-18 00:53:13 -04:00
|
|
|
msg: &[u8]
|
2022-04-21 21:36:18 -04:00
|
|
|
) -> dfg::Scalar {
|
2022-04-29 22:03:34 -04:00
|
|
|
// Apply the binding factor to the H variant of the nonce
|
|
|
|
|
self.AH.0 += self.AH.1 * b;
|
|
|
|
|
|
2022-05-03 07:20:24 -04:00
|
|
|
// Use the transcript to get a seeded random number generator
|
|
|
|
|
// The transcript contains private data, preventing passive adversaries from recreating this
|
|
|
|
|
// process even if they have access to commitments (specifically, the ring index being signed
|
|
|
|
|
// for, along with the mask which should not only require knowing the shared keys yet also the
|
2022-05-06 07:33:08 -04:00
|
|
|
// input commitment masks)
|
|
|
|
|
let mut rng = ChaCha12Rng::from_seed(self.transcript.rng_seed(b"decoy_responses", None));
|
2022-04-28 12:01:20 -04:00
|
|
|
|
2022-05-18 00:53:13 -04:00
|
|
|
self.msg = Some(msg.try_into().expect("CLSAG message should be 32-bytes"));
|
|
|
|
|
|
2022-04-21 21:36:18 -04:00
|
|
|
#[allow(non_snake_case)]
|
2022-05-13 20:26:29 -04:00
|
|
|
let (clsag, pseudo_out, p, c) = sign_core(
|
2022-04-28 17:12:54 -04:00
|
|
|
&mut rng,
|
2022-04-30 01:43:15 -04:00
|
|
|
&self.image,
|
2022-05-06 19:07:37 -04:00
|
|
|
&self.input(),
|
|
|
|
|
self.mask(),
|
2022-05-18 00:53:13 -04:00
|
|
|
&self.msg.as_ref().unwrap(),
|
2022-04-23 03:49:30 -04:00
|
|
|
nonce_sum.0,
|
2022-04-29 22:03:34 -04:00
|
|
|
self.AH.0.0
|
2022-04-23 03:49:30 -04:00
|
|
|
);
|
2022-05-13 20:26:29 -04:00
|
|
|
self.interim = Some(Interim { p, c, clsag, pseudo_out });
|
2022-04-21 21:36:18 -04:00
|
|
|
|
2022-05-13 20:26:29 -04:00
|
|
|
let share = dfg::Scalar(nonce.0 - (p * view.secret_share().0));
|
2022-04-21 21:36:18 -04:00
|
|
|
|
|
|
|
|
share
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn verify(
|
|
|
|
|
&self,
|
|
|
|
|
_: dfg::EdwardsPoint,
|
|
|
|
|
_: dfg::EdwardsPoint,
|
|
|
|
|
sum: dfg::Scalar
|
|
|
|
|
) -> Option<Self::Signature> {
|
|
|
|
|
let interim = self.interim.as_ref().unwrap();
|
|
|
|
|
let mut clsag = interim.clsag.clone();
|
2022-05-13 20:26:29 -04:00
|
|
|
clsag.s[usize::from(self.input().decoys.i)] = Key { key: (sum.0 - interim.c).to_bytes() };
|
2022-05-18 00:53:13 -04:00
|
|
|
if verify(
|
|
|
|
|
&clsag,
|
|
|
|
|
&self.input().decoys.ring,
|
|
|
|
|
&self.image,
|
|
|
|
|
&interim.pseudo_out,
|
|
|
|
|
&self.msg.as_ref().unwrap()
|
|
|
|
|
).is_ok() {
|
2022-05-13 20:26:29 -04:00
|
|
|
return Some((clsag, interim.pseudo_out));
|
2022-04-21 21:36:18 -04:00
|
|
|
}
|
|
|
|
|
return None;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn verify_share(
|
|
|
|
|
&self,
|
|
|
|
|
verification_share: dfg::EdwardsPoint,
|
|
|
|
|
nonce: dfg::EdwardsPoint,
|
|
|
|
|
share: dfg::Scalar,
|
|
|
|
|
) -> bool {
|
|
|
|
|
let interim = self.interim.as_ref().unwrap();
|
|
|
|
|
return (&share.0 * &ED25519_BASEPOINT_TABLE) == (
|
2022-05-13 20:26:29 -04:00
|
|
|
nonce.0 - (interim.p * verification_share.0)
|
2022-04-21 21:36:18 -04:00
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|