mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 20:29:23 +00:00
93f7afec8b
The audit recommends checking failure cases for from_bytes, from_bytes_unechecked, and from_repr. This isn't feasible. from_bytes is allowed to have non-canonical values. [0xff; 32] may accordingly be a valid point for non-SEC1-encoded curves. from_bytes_unchecked doesn't have a defined failure mode, and by name, unchecked, shouldn't necessarily fail. The audit acknowledges the tests should test for whatever result is 'appropriate', yet any result which isn't a failure on a valid element is appropriate. from_repr must be canonical, yet for a binary field of 2^n where n % 8 == 0, a [0xff; n / 8] repr would be valid.
37 lines
1.1 KiB
Rust
37 lines
1.1 KiB
Rust
use zeroize::Zeroize;
|
|
|
|
use crypto_bigint::{U512, U1024};
|
|
|
|
use crate::field;
|
|
|
|
#[derive(Clone, Copy, PartialEq, Eq, Default, Debug, Zeroize)]
|
|
pub struct FieldElement(pub(crate) U512);
|
|
|
|
// 2**448 - 2**224 - 1
|
|
pub const MODULUS: FieldElement = FieldElement(U512::from_be_hex(concat!(
|
|
"00000000000000",
|
|
"00",
|
|
"fffffffffffffffffffffffffffffffffffffffffffffffffffffffe",
|
|
"ffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
|
|
)));
|
|
|
|
const WIDE_MODULUS: U1024 = U1024::from_be_hex(concat!(
|
|
"0000000000000000000000000000000000000000000000000000000000000000",
|
|
"0000000000000000000000000000000000000000000000000000000000000000",
|
|
"00000000000000",
|
|
"00",
|
|
"fffffffffffffffffffffffffffffffffffffffffffffffffffffffe",
|
|
"ffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
|
|
));
|
|
|
|
pub(crate) const Q_4: FieldElement =
|
|
FieldElement(MODULUS.0.saturating_add(&U512::ONE).wrapping_div(&U512::from_u8(4)));
|
|
|
|
field!(FieldElement, MODULUS, WIDE_MODULUS, 448);
|
|
|
|
#[test]
|
|
fn test_field() {
|
|
// TODO: Move to test_prime_field_bits once the impl is finished
|
|
ff_group_tests::prime_field::test_prime_field::<_, FieldElement>(&mut rand_core::OsRng);
|
|
}
|