93f7afec8b
The audit recommends checking failure cases for from_bytes, from_bytes_unechecked, and from_repr. This isn't feasible. from_bytes is allowed to have non-canonical values. [0xff; 32] may accordingly be a valid point for non-SEC1-encoded curves. from_bytes_unchecked doesn't have a defined failure mode, and by name, unchecked, shouldn't necessarily fail. The audit acknowledges the tests should test for whatever result is 'appropriate', yet any result which isn't a failure on a valid element is appropriate. from_repr must be canonical, yet for a binary field of 2^n where n % 8 == 0, a [0xff; n / 8] repr would be valid.
Serai
Serai is a new DEX, built from the ground up, initially planning on listing Bitcoin, Ethereum, Monero, DAI, offering a liquidity pool trading experience. Funds are stored in an economically secured threshold multisig wallet.
Layout
-
docs: Documentation on the Serai protocol. -
crypto: A series of composable cryptographic libraries built around theff/groupAPIs achieving a variety of tasks. These range from generic infrastructure, to our IETF-compliant FROST implementation, to a DLEq proof as needed for Bitcoin-Monero atomic swaps. -
coins: Various coin libraries intended for usage in Serai yet also by the wider community. This means they will always support the functionality Serai needs, yet won't disadvantage other use cases when possible. -
processor: A generic chain processor to process data for Serai and process events from Serai, executing transactions as expected and needed. -
contracts: Smart Contracts implementing Serai's functionality. -
substrate: Substrate crates used to instantiate the Serai network.