absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-10 13:09:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix timeline for incrementing providers

Browse Source 
e1671dd71b incremented the providers for every
single transaction's sender before execution, noting the solution was fragile
but it worked for us at this time. It did not work for us at this time.

The new solution replaces `inc_providers` with direct access to the `Account`
`StorageMap` to increment the providers, achieving the desired goal, _without_
emitting an event (which is ordered, and the disparate order between building
and execution was causing mismatches of the state root).

This solution is also fragile and may also be insufficient. None of this code
exists anymore on `next` however. It just has to work sufficiently for now.
This commit is contained in:
Luke Parker
2025-10-05 05:34:18 -04:00
parent 8970031f42
commit 74296a0775
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
substrate/runtime/src/lib.rs
View File

@@ -383,9 +383,11 @@ sp_api::impl_runtime_apis! {
fn execute_block(block: Block) {
for tx in &block.extrinsics {
if let Some(signer) = tx.signer() {
let signer = signer.0.into();
if System::providers(&signer) == 0 {
System::inc_providers(&signer);
let signer = PublicKey::from(signer.0);
let mut info = frame_system::Account::<Runtime>::get(&signer);
if info.providers == 0 {
info.providers = 1;
frame_system::Account::<Runtime>::set(&signer, info);
}
}
}
@@ -401,9 +403,11 @@ sp_api::impl_runtime_apis! {
impl sp_block_builder::BlockBuilder<Block> for Runtime {
fn apply_extrinsic(extrinsic: <Block as BlockT>::Extrinsic) -> ApplyExtrinsicResult {
if let Some(signer) = extrinsic.signer() {
let signer = signer.0.into();
if System::providers(&signer) == 0 {
System::inc_providers(&signer);
let signer = PublicKey::from(signer.0);
let mut info = frame_system::Account::<Runtime>::get(&signer);
if info.providers == 0 {
info.providers = 1;
frame_system::Account::<Runtime>::set(&signer, info);
}
}
Executive::apply_extrinsic(extrinsic)