mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-12 22:19:26 +00:00
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
76 lines
2.4 KiB
Rust
76 lines
2.4 KiB
Rust
use std::collections::HashMap;
|
|
|
|
use zeroize::Zeroizing;
|
|
use rand_core::OsRng;
|
|
use rand::seq::SliceRandom;
|
|
|
|
use ciphersuite::{group::ff::Field, WrappedGroup};
|
|
use embedwards25519::Embedwards25519;
|
|
|
|
use dkg_recovery::recover_key;
|
|
use crate::{Participant, Curves, Generators, VerifyResult, Dkg, Ed25519};
|
|
|
|
mod proof;
|
|
|
|
const THRESHOLD: u16 = 3;
|
|
const PARTICIPANTS: u16 = 5;
|
|
|
|
#[test]
|
|
fn dkg() {
|
|
let generators = Generators::<Ed25519>::new(THRESHOLD, PARTICIPANTS);
|
|
let context = [0; 32];
|
|
|
|
let mut priv_keys = vec![];
|
|
let mut pub_keys = vec![];
|
|
for i in 0 .. PARTICIPANTS {
|
|
let priv_key = <Embedwards25519 as WrappedGroup>::F::random(&mut OsRng);
|
|
pub_keys.push(<Embedwards25519 as WrappedGroup>::generator() * priv_key);
|
|
priv_keys.push((Participant::new(1 + i).unwrap(), Zeroizing::new(priv_key)));
|
|
}
|
|
|
|
let mut participations = HashMap::new();
|
|
// Shuffle the private keys so we iterate over a random subset of them
|
|
priv_keys.shuffle(&mut OsRng);
|
|
for (i, priv_key) in priv_keys.iter().take(usize::from(THRESHOLD)) {
|
|
participations.insert(
|
|
*i,
|
|
Dkg::<Ed25519>::participate(&mut OsRng, &generators, context, THRESHOLD, &pub_keys, priv_key)
|
|
.unwrap(),
|
|
);
|
|
}
|
|
|
|
let VerifyResult::Valid(dkg) =
|
|
Dkg::<Ed25519>::verify(&mut OsRng, &generators, context, THRESHOLD, &pub_keys, &participations)
|
|
.unwrap()
|
|
else {
|
|
panic!("verify didn't return VerifyResult::Valid")
|
|
};
|
|
|
|
let mut group_key = None;
|
|
let mut verification_shares = None;
|
|
let mut all_keys = HashMap::new();
|
|
for (i, priv_key) in priv_keys {
|
|
let keys = dkg.keys(&priv_key).into_iter().next().unwrap();
|
|
assert_eq!(keys.params().i(), i);
|
|
assert_eq!(keys.params().t(), THRESHOLD);
|
|
assert_eq!(keys.params().n(), PARTICIPANTS);
|
|
group_key = group_key.or(Some(keys.group_key()));
|
|
let these_verification_shares = Participant::iter()
|
|
.take(usize::from(PARTICIPANTS))
|
|
.map(|i| (i, keys.original_verification_share(i)))
|
|
.collect::<HashMap<_, _>>();
|
|
verification_shares = verification_shares.or(Some(these_verification_shares.clone()));
|
|
assert_eq!(Some(keys.group_key()), group_key);
|
|
assert_eq!(Some(these_verification_shares), verification_shares);
|
|
|
|
all_keys.insert(i, keys);
|
|
}
|
|
|
|
// TODO: Test for all possible combinations of keys
|
|
assert_eq!(
|
|
<<Ed25519 as Curves>::ToweringCurve as WrappedGroup>::generator() *
|
|
*recover_key(&all_keys.values().cloned().collect::<Vec<_>>()).unwrap(),
|
|
group_key.unwrap()
|
|
);
|
|
}
|