mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-09 04:39:24 +00:00
a141deaf36
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
86 lines
2.3 KiB
Rust
86 lines
2.3 KiB
Rust
use rand::rngs::OsRng;
|
|
|
|
use blake2::{Digest, Blake2s256};
|
|
|
|
use dalek_ff_group::Ristretto;
|
|
use ciphersuite::*;
|
|
|
|
use crate::{
|
|
ReadWrite,
|
|
transaction::{Signed, Transaction, verify_transaction},
|
|
tests::{random_signed, random_signed_transaction},
|
|
};
|
|
|
|
#[test]
|
|
fn serialize_signed() {
|
|
let signed = random_signed(&mut rand::rngs::OsRng);
|
|
assert_eq!(Signed::read::<&[u8]>(&mut signed.serialize().as_ref()).unwrap(), signed);
|
|
}
|
|
|
|
#[test]
|
|
fn sig_hash() {
|
|
let (genesis, tx1) = random_signed_transaction(&mut OsRng);
|
|
assert!(tx1.sig_hash(genesis) != tx1.sig_hash(Blake2s256::digest(genesis).into()));
|
|
|
|
let (_, tx2) = random_signed_transaction(&mut OsRng);
|
|
assert!(tx1.hash() != tx2.hash());
|
|
assert!(tx1.sig_hash(genesis) != tx2.sig_hash(genesis));
|
|
}
|
|
|
|
#[test]
|
|
fn signed_transaction() {
|
|
let (genesis, tx) = random_signed_transaction(&mut OsRng);
|
|
|
|
// Mutate various properties and verify it no longer works
|
|
|
|
// Different genesis
|
|
assert!(verify_transaction(&tx, Blake2s256::digest(genesis).into(), &mut |_, _| Some(
|
|
tx.1.nonce
|
|
))
|
|
.is_err());
|
|
|
|
// Different data
|
|
{
|
|
let mut tx = tx.clone();
|
|
tx.0 = Blake2s256::digest(tx.0).to_vec();
|
|
assert!(verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce)).is_err());
|
|
}
|
|
|
|
// Different signer
|
|
{
|
|
let mut tx = tx.clone();
|
|
tx.1.signer += Ristretto::generator();
|
|
assert!(verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce)).is_err());
|
|
}
|
|
|
|
// Different nonce
|
|
{
|
|
#[allow(clippy::redundant_clone)] // False positive?
|
|
let mut tx = tx.clone();
|
|
tx.1.nonce = tx.1.nonce.wrapping_add(1);
|
|
assert!(verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce)).is_err());
|
|
}
|
|
|
|
// Different signature
|
|
{
|
|
let mut tx = tx.clone();
|
|
tx.1.signature.R += Ristretto::generator();
|
|
assert!(verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce)).is_err());
|
|
}
|
|
{
|
|
let mut tx = tx.clone();
|
|
tx.1.signature.s += <Ristretto as WrappedGroup>::F::ONE;
|
|
assert!(verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce)).is_err());
|
|
}
|
|
|
|
// Sanity check the original TX was never mutated and is valid
|
|
verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce)).unwrap();
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_nonce() {
|
|
let (genesis, tx) = random_signed_transaction(&mut OsRng);
|
|
|
|
assert!(verify_transaction(&tx, genesis, &mut |_, _| Some(tx.1.nonce.wrapping_add(1)),).is_err());
|
|
}
|