mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-12 14:09:25 +00:00
a141deaf36
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
55 lines
1.3 KiB
Rust
55 lines
1.3 KiB
Rust
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
|
|
#![cfg_attr(not(feature = "std"), no_std)]
|
|
|
|
use zeroize::Zeroize;
|
|
|
|
use sha2::Sha512;
|
|
|
|
use ciphersuite::{WrappedGroup, Id, WithPreferredHash, GroupCanonicalEncoding};
|
|
|
|
pub use k256;
|
|
pub use p256;
|
|
|
|
macro_rules! kp_curve {
|
|
(
|
|
$feature: literal,
|
|
$lib: ident,
|
|
|
|
$Ciphersuite: ident,
|
|
$ID: literal
|
|
) => {
|
|
impl WrappedGroup for $Ciphersuite {
|
|
type F = $lib::Scalar;
|
|
type G = $lib::ProjectivePoint;
|
|
fn generator() -> Self::G {
|
|
$lib::ProjectivePoint::GENERATOR
|
|
}
|
|
}
|
|
impl Id for $Ciphersuite {
|
|
const ID: &'static [u8] = $ID;
|
|
}
|
|
impl WithPreferredHash for $Ciphersuite {
|
|
type H = Sha512;
|
|
}
|
|
impl GroupCanonicalEncoding for $Ciphersuite {}
|
|
};
|
|
}
|
|
|
|
/// Ciphersuite for Secp256k1.
|
|
#[derive(Clone, Copy, PartialEq, Eq, Debug, Zeroize)]
|
|
pub struct Secp256k1;
|
|
kp_curve!("secp256k1", k256, Secp256k1, b"secp256k1");
|
|
#[test]
|
|
fn test_secp256k1() {
|
|
ff_group_tests::group::test_prime_group_bits::<_, k256::ProjectivePoint>(&mut rand_core::OsRng);
|
|
}
|
|
|
|
/// Ciphersuite for P-256.
|
|
#[derive(Clone, Copy, PartialEq, Eq, Debug, Zeroize)]
|
|
pub struct P256;
|
|
kp_curve!("p256", p256, P256, b"P-256");
|
|
#[test]
|
|
fn test_p256() {
|
|
ff_group_tests::group::test_prime_group_bits::<_, p256::ProjectivePoint>(&mut rand_core::OsRng);
|
|
}
|