mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-09 12:49:23 +00:00
a141deaf36
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
87 lines
2.7 KiB
Rust
87 lines
2.7 KiB
Rust
use std::{
|
|
collections::HashMap,
|
|
io::{self, Read},
|
|
};
|
|
|
|
use rand_core::{RngCore, CryptoRng};
|
|
|
|
use frost::{
|
|
dkg::{Participant, ThresholdKeys},
|
|
curve::Ristretto,
|
|
FrostError,
|
|
algorithm::Algorithm,
|
|
sign::*,
|
|
};
|
|
use frost_schnorrkel::Schnorrkel;
|
|
|
|
// This wraps a Schnorrkel sign machine into one with a preset message.
|
|
#[derive(Clone)]
|
|
pub(crate) struct WrappedSchnorrkelMachine(ThresholdKeys<Ristretto>, &'static [u8], Vec<u8>);
|
|
impl WrappedSchnorrkelMachine {
|
|
pub(crate) fn new(keys: ThresholdKeys<Ristretto>, context: &'static [u8], msg: Vec<u8>) -> Self {
|
|
Self(keys, context, msg)
|
|
}
|
|
}
|
|
|
|
pub(crate) struct WrappedSchnorrkelSignMachine(
|
|
<AlgorithmMachine<Ristretto, Schnorrkel> as PreprocessMachine>::SignMachine,
|
|
Vec<u8>,
|
|
);
|
|
|
|
type Signature = <AlgorithmMachine<Ristretto, Schnorrkel> as PreprocessMachine>::Signature;
|
|
impl PreprocessMachine for WrappedSchnorrkelMachine {
|
|
type Preprocess = <AlgorithmMachine<Ristretto, Schnorrkel> as PreprocessMachine>::Preprocess;
|
|
type Signature = Signature;
|
|
type SignMachine = WrappedSchnorrkelSignMachine;
|
|
|
|
fn preprocess<R: RngCore + CryptoRng>(
|
|
self,
|
|
rng: &mut R,
|
|
) -> (Self::SignMachine, Preprocess<Ristretto, <Schnorrkel as Algorithm<Ristretto>>::Addendum>)
|
|
{
|
|
let WrappedSchnorrkelMachine(keys, context, msg) = self;
|
|
let (machine, preprocess) =
|
|
AlgorithmMachine::new(Schnorrkel::new(context), keys).preprocess(rng);
|
|
(WrappedSchnorrkelSignMachine(machine, msg), preprocess)
|
|
}
|
|
}
|
|
|
|
impl SignMachine<Signature> for WrappedSchnorrkelSignMachine {
|
|
type Params = <AlgorithmSignMachine<Ristretto, Schnorrkel> as SignMachine<Signature>>::Params;
|
|
type Keys = <AlgorithmSignMachine<Ristretto, Schnorrkel> as SignMachine<Signature>>::Keys;
|
|
type Preprocess =
|
|
<AlgorithmSignMachine<Ristretto, Schnorrkel> as SignMachine<Signature>>::Preprocess;
|
|
type SignatureShare =
|
|
<AlgorithmSignMachine<Ristretto, Schnorrkel> as SignMachine<Signature>>::SignatureShare;
|
|
type SignatureMachine =
|
|
<AlgorithmSignMachine<Ristretto, Schnorrkel> as SignMachine<Signature>>::SignatureMachine;
|
|
|
|
fn cache(self) -> CachedPreprocess {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn from_cache(
|
|
_algorithm: Schnorrkel,
|
|
_keys: ThresholdKeys<Ristretto>,
|
|
_cache: CachedPreprocess,
|
|
) -> (Self, Self::Preprocess) {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn read_preprocess<R: Read>(&self, reader: &mut R) -> io::Result<Self::Preprocess> {
|
|
self.0.read_preprocess(reader)
|
|
}
|
|
|
|
fn sign(
|
|
self,
|
|
preprocesses: HashMap<
|
|
Participant,
|
|
Preprocess<Ristretto, <Schnorrkel as Algorithm<Ristretto>>::Addendum>,
|
|
>,
|
|
msg: &[u8],
|
|
) -> Result<(Self::SignatureMachine, SignatureShare<Ristretto>), FrostError> {
|
|
assert!(msg.is_empty());
|
|
self.0.sign(preprocesses, &self.1)
|
|
}
|
|
}
|