mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 20:29:23 +00:00
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
123 lines
3.5 KiB
Rust
123 lines
3.5 KiB
Rust
use core::{marker::PhantomData, future::Future};
|
|
|
|
use frost::{dkg::ThresholdKeys, curve::Ristretto};
|
|
|
|
use serai_primitives::Signature;
|
|
use serai_validator_sets_primitives::Session;
|
|
|
|
use serai_db::{DbTxn, Db};
|
|
|
|
use messages::sign::VariantSignId;
|
|
|
|
use primitives::task::{DoesNotError, ContinuallyRan};
|
|
use scanner::ScannerFeed;
|
|
|
|
use frost_attempt_manager::*;
|
|
|
|
use crate::{
|
|
db::{
|
|
SlashReport, SignedSlashReport, CoordinatorToSlashReportSignerMessages,
|
|
SlashReportSignerToCoordinatorMessages,
|
|
},
|
|
WrappedSchnorrkelMachine,
|
|
};
|
|
|
|
// Fetches slash reports to sign and signs them.
|
|
#[allow(non_snake_case)]
|
|
pub(crate) struct SlashReportSignerTask<D: Db, S: ScannerFeed> {
|
|
db: D,
|
|
_S: PhantomData<S>,
|
|
|
|
session: Session,
|
|
keys: Vec<ThresholdKeys<Ristretto>>,
|
|
|
|
has_slash_report: bool,
|
|
attempt_manager: AttemptManager<D, WrappedSchnorrkelMachine>,
|
|
}
|
|
|
|
impl<D: Db, S: ScannerFeed> SlashReportSignerTask<D, S> {
|
|
pub(crate) fn new(db: D, session: Session, keys: Vec<ThresholdKeys<Ristretto>>) -> Self {
|
|
let attempt_manager = AttemptManager::new(
|
|
db.clone(),
|
|
session,
|
|
keys.first().expect("creating a slash report signer with 0 keys").params().i(),
|
|
);
|
|
|
|
Self { db, _S: PhantomData, session, keys, has_slash_report: false, attempt_manager }
|
|
}
|
|
}
|
|
|
|
impl<D: Db, S: ScannerFeed> ContinuallyRan for SlashReportSignerTask<D, S> {
|
|
type Error = DoesNotError;
|
|
|
|
fn run_iteration(&mut self) -> impl Send + Future<Output = Result<bool, Self::Error>> {
|
|
async move {
|
|
let mut iterated = false;
|
|
|
|
// Check for the slash report to sign
|
|
if !self.has_slash_report {
|
|
let mut txn = self.db.txn();
|
|
let Some(slash_report) = SlashReport::try_recv(&mut txn, self.session) else {
|
|
return Ok(false);
|
|
};
|
|
// We only commit this upon successfully signing this slash report
|
|
drop(txn);
|
|
iterated = true;
|
|
|
|
self.has_slash_report = true;
|
|
|
|
let mut machines = Vec::with_capacity(self.keys.len());
|
|
{
|
|
let message = slash_report.report_slashes_message();
|
|
for keys in &self.keys {
|
|
// TODO: Fetch this constant from somewhere instead of inlining it
|
|
machines.push(WrappedSchnorrkelMachine::new(
|
|
keys.clone(),
|
|
b"substrate",
|
|
message.clone(),
|
|
));
|
|
}
|
|
}
|
|
let mut txn = self.db.txn();
|
|
for msg in self.attempt_manager.register(VariantSignId::SlashReport, machines) {
|
|
SlashReportSignerToCoordinatorMessages::send(&mut txn, self.session, &msg);
|
|
}
|
|
txn.commit();
|
|
}
|
|
|
|
// Handle any messages sent to us
|
|
loop {
|
|
let mut txn = self.db.txn();
|
|
let Some(msg) = CoordinatorToSlashReportSignerMessages::try_recv(&mut txn, self.session)
|
|
else {
|
|
break;
|
|
};
|
|
iterated = true;
|
|
|
|
match self.attempt_manager.handle(msg) {
|
|
Response::Messages(msgs) => {
|
|
for msg in msgs {
|
|
SlashReportSignerToCoordinatorMessages::send(&mut txn, self.session, &msg);
|
|
}
|
|
}
|
|
Response::Signature { id, signature } => {
|
|
assert_eq!(id, VariantSignId::SlashReport);
|
|
// Drain the channel
|
|
let slash_report = SlashReport::try_recv(&mut txn, self.session).unwrap();
|
|
// Send the signature
|
|
SignedSlashReport::send(
|
|
&mut txn,
|
|
self.session,
|
|
&(slash_report, Signature::from(signature).0),
|
|
);
|
|
}
|
|
}
|
|
|
|
txn.commit();
|
|
}
|
|
|
|
Ok(iterated)
|
|
}
|
|
}
|
|
}
|