mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 12:19:24 +00:00
a141deaf36
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
39 lines
1.3 KiB
Rust
39 lines
1.3 KiB
Rust
use zeroize::Zeroizing;
|
|
|
|
use ciphersuite::*;
|
|
use dalek_ff_group::Ed25519;
|
|
|
|
use monero_wallet::{address::SubaddressIndex, ViewPairError, GuaranteedViewPair};
|
|
|
|
use view_keys::view_key;
|
|
|
|
pub(crate) mod output;
|
|
pub(crate) mod transaction;
|
|
pub(crate) mod block;
|
|
|
|
pub(crate) const EXTERNAL_SUBADDRESS: SubaddressIndex = match SubaddressIndex::new(1, 0) {
|
|
Some(index) => index,
|
|
None => panic!("SubaddressIndex for EXTERNAL_SUBADDRESS was None"),
|
|
};
|
|
pub(crate) const BRANCH_SUBADDRESS: SubaddressIndex = match SubaddressIndex::new(2, 0) {
|
|
Some(index) => index,
|
|
None => panic!("SubaddressIndex for BRANCH_SUBADDRESS was None"),
|
|
};
|
|
pub(crate) const CHANGE_SUBADDRESS: SubaddressIndex = match SubaddressIndex::new(2, 1) {
|
|
Some(index) => index,
|
|
None => panic!("SubaddressIndex for CHANGE_SUBADDRESS was None"),
|
|
};
|
|
pub(crate) const FORWARDED_SUBADDRESS: SubaddressIndex = match SubaddressIndex::new(2, 2) {
|
|
Some(index) => index,
|
|
None => panic!("SubaddressIndex for FORWARDED_SUBADDRESS was None"),
|
|
};
|
|
|
|
pub(crate) fn view_pair(key: <Ed25519 as WrappedGroup>::G) -> GuaranteedViewPair {
|
|
match GuaranteedViewPair::new(key.0, Zeroizing::new(view_key::<Ed25519>(0))) {
|
|
Ok(view_pair) => view_pair,
|
|
Err(ViewPairError::TorsionedSpendKey) => {
|
|
unreachable!("dalek_ff_group::EdwardsPoint had torsion")
|
|
}
|
|
}
|
|
}
|