mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-11 13:39:25 +00:00
797be71eb3
* Apply Zeroize to nonces used in Bulletproofs Also makes bit decomposition constant time for a given amount of outputs. * Fix nonce reuse for single-signer CLSAG * Attach Zeroize to most structures in Monero, and ZOnDrop to anything with private data * Zeroize private keys and nonces * Merge prepare_outputs and prepare_transactions * Ensure CLSAG is constant time * Pass by borrow where needed, bug fixes The past few commitments have been one in-progress chunk which I've broken up as best read. * Add Zeroize to FROST structs Still needs to zeroize internally, yet next step. Not quite as aggressive as Monero, partially due to the limitations of HashMaps, partially due to less concern about metadata, yet does still delete a few smaller items of metadata (group key, context string...). * Remove Zeroize from most Monero multisig structs These structs largely didn't have private data, just fields with private data, yet those fields implemented ZeroizeOnDrop making them already covered. While there is still traces of the transaction left in RAM, fully purging that was never the intent. * Use Zeroize within dleq bitvec doesn't offer Zeroize, so a manual zeroing has been implemented. * Use Zeroize for random_nonce It isn't perfect, due to the inability to zeroize the digest, and due to kp256 requiring a few transformations. It does the best it can though. Does move the per-curve random_nonce to a provided one, which is allowed as of https://github.com/cfrg/draft-irtf-cfrg-frost/pull/231. * Use Zeroize on FROST keygen/signing * Zeroize constant time multiexp. * Correct when FROST keygen zeroizes * Move the FROST keys Arc into FrostKeys Reduces amount of instances in memory. * Manually implement Debug for FrostCore to not leak the secret share * Misc bug fixes * clippy + multiexp test bug fixes * Correct FROST key gen share summation It leaked our own share for ourself. * Fix cross-group DLEq tests
85 lines
2.0 KiB
Rust
85 lines
2.0 KiB
Rust
use std::marker::Send;
|
|
|
|
use async_trait::async_trait;
|
|
use thiserror::Error;
|
|
|
|
use transcript::RecommendedTranscript;
|
|
use frost::{curve::Curve, FrostKeys, sign::PreprocessMachine};
|
|
|
|
pub mod monero;
|
|
pub use self::monero::Monero;
|
|
|
|
#[derive(Clone, Error, Debug)]
|
|
pub enum CoinError {
|
|
#[error("failed to connect to coin daemon")]
|
|
ConnectionError,
|
|
}
|
|
|
|
pub trait Output: Sized + Clone {
|
|
type Id: AsRef<[u8]>;
|
|
|
|
fn id(&self) -> Self::Id;
|
|
fn amount(&self) -> u64;
|
|
|
|
fn serialize(&self) -> Vec<u8>;
|
|
fn deserialize<R: std::io::Read>(reader: &mut R) -> std::io::Result<Self>;
|
|
}
|
|
|
|
#[async_trait]
|
|
pub trait Coin {
|
|
type Curve: Curve;
|
|
|
|
type Fee: Copy;
|
|
type Transaction;
|
|
type Block;
|
|
|
|
type Output: Output;
|
|
type SignableTransaction;
|
|
type TransactionMachine: PreprocessMachine<Signature = Self::Transaction>;
|
|
|
|
type Address: Send;
|
|
|
|
const ID: &'static [u8];
|
|
const CONFIRMATIONS: usize;
|
|
const MAX_INPUTS: usize;
|
|
const MAX_OUTPUTS: usize; // TODO: Decide if this includes change or not
|
|
|
|
// Doesn't have to take self, enables some level of caching which is pleasant
|
|
fn address(&self, key: <Self::Curve as Curve>::G) -> Self::Address;
|
|
|
|
async fn get_height(&self) -> Result<usize, CoinError>;
|
|
async fn get_block(&self, height: usize) -> Result<Self::Block, CoinError>;
|
|
async fn get_outputs(
|
|
&self,
|
|
block: &Self::Block,
|
|
key: <Self::Curve as Curve>::G,
|
|
) -> Vec<Self::Output>;
|
|
|
|
async fn prepare_send(
|
|
&self,
|
|
keys: FrostKeys<Self::Curve>,
|
|
transcript: RecommendedTranscript,
|
|
height: usize,
|
|
inputs: Vec<Self::Output>,
|
|
payments: &[(Self::Address, u64)],
|
|
fee: Self::Fee,
|
|
) -> Result<Self::SignableTransaction, CoinError>;
|
|
|
|
async fn attempt_send(
|
|
&self,
|
|
transaction: Self::SignableTransaction,
|
|
included: &[u16],
|
|
) -> Result<Self::TransactionMachine, CoinError>;
|
|
|
|
async fn publish_transaction(
|
|
&self,
|
|
tx: &Self::Transaction,
|
|
) -> Result<(Vec<u8>, Vec<<Self::Output as Output>::Id>), CoinError>;
|
|
|
|
#[cfg(test)]
|
|
async fn mine_block(&self);
|
|
|
|
#[cfg(test)]
|
|
async fn test_send(&self, key: Self::Address);
|
|
}
|