mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 20:29:23 +00:00
a141deaf36
This helps identify where the various functionalities are used, or rather, not used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating the entire FCMP++ tree, only requires the markers _and_ canonical point decoding. I've opened a PR to upstream such a trait into `group` (https://github.com/zkcrypto/group/pull/68). `WrappedGroup` is still justified for as long as `Group::generator` exists. Moving `::generator()` to its own trait, on an independent structure (upstream) would be massively appreciated. @tarcieri also wanted to update from `fn generator()` to `const GENERATOR`, which would encourage further discussion on https://github.com/zkcrypto/group/issues/32 and https://github.com/zkcrypto/group/issues/45, which have been stagnant. The `Id` trait is occasionally used yet really should be first off the chopping block. Finally, `WithPreferredHash` is only actually used around a third of the time, which more than justifies it being a separate trait. --- Updates `dalek_ff_group::Scalar` to directly re-export `curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint` also could be replaced with an export of `curve25519_dalek::RistrettoPoint`, yet the coordinator relies on how we implemented `Hash` on it for the hell of it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't implement `zeroize`, `subtle` traits within a released, non-yanked version. Relevance to https://github.com/serai-dex/serai/issues/201 and https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746. Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over `SHA2-512`. In order to maintain compliance with FROST's IETF standard, `modular-frost` defines its own ciphersuite for Ristretto which still uses `SHA2-512`.
35 lines
1.0 KiB
Rust
35 lines
1.0 KiB
Rust
use ciphersuite::{group::GroupEncoding, *};
|
|
use dkg::{ThresholdKeys, Curves, Secp256k1};
|
|
|
|
use crate::{primitives::x_coord_to_even_point, scan::scanner};
|
|
|
|
pub(crate) struct KeyGenParams;
|
|
impl key_gen::KeyGenParams for KeyGenParams {
|
|
const ID: &'static str = "Bitcoin";
|
|
|
|
type ExternalNetworkCiphersuite = Secp256k1;
|
|
|
|
fn tweak_keys(
|
|
keys: &mut ThresholdKeys<<Self::ExternalNetworkCiphersuite as Curves>::ToweringCurve>,
|
|
) {
|
|
*keys = bitcoin_serai::wallet::tweak_keys(keys.clone());
|
|
// Also create a scanner to assert these keys, and all expected paths, are usable
|
|
scanner(keys.group_key());
|
|
}
|
|
|
|
fn encode_key(
|
|
key: <<Self::ExternalNetworkCiphersuite as Curves>::ToweringCurve as WrappedGroup>::G,
|
|
) -> Vec<u8> {
|
|
let key = key.to_bytes();
|
|
let key: &[u8] = key.as_ref();
|
|
// Skip the parity encoding as we know this key is even
|
|
key[1 ..].to_vec()
|
|
}
|
|
|
|
fn decode_key(
|
|
key: &[u8],
|
|
) -> Option<<<Self::ExternalNetworkCiphersuite as Curves>::ToweringCurve as WrappedGroup>::G> {
|
|
x_coord_to_even_point(key)
|
|
}
|
|
}
|