use core::{marker::PhantomData, fmt}; use std::collections::HashMap; use rand_core::OsRng; use ciphersuite::group::GroupEncoding; use frost::{ ThresholdKeys, FrostError, sign::{Writable, PreprocessMachine, SignMachine, SignatureMachine}, }; use log::{info, debug, warn, error}; use serai_client::validator_sets::primitives::Session; use messages::sign::*; pub use serai_db::*; use crate::{ Get, DbTxn, Db, networks::{Transaction, Eventuality, Network}, }; create_db!( SignerDb { CompletionsDb: (id: [u8; 32]) -> Vec, EventualityDb: (id: [u8; 32]) -> Vec, AttemptDb: (id: &SignId) -> (), TransactionDb: (id: &[u8]) -> Vec, ActiveSignsDb: () -> Vec<[u8; 32]>, CompletedOnChainDb: (id: &[u8; 32]) -> (), } ); impl ActiveSignsDb { fn add_active_sign(txn: &mut impl DbTxn, id: &[u8; 32]) { if CompletedOnChainDb::get(txn, id).is_some() { return; } let mut active = ActiveSignsDb::get(txn).unwrap_or_default(); active.push(*id); ActiveSignsDb::set(txn, &active); } } impl CompletedOnChainDb { fn complete_on_chain(txn: &mut impl DbTxn, id: &[u8; 32]) { CompletedOnChainDb::set(txn, id, &()); ActiveSignsDb::set( txn, &ActiveSignsDb::get(txn) .unwrap_or_default() .into_iter() .filter(|active| active != id) .collect::>(), ); } } impl CompletionsDb { fn completions( getter: &impl Get, id: [u8; 32], ) -> Vec<>::Id> { let completions = Self::get(getter, id).unwrap_or_default(); let mut completions_ref = completions.as_slice(); let mut res = vec![]; while !completions_ref.is_empty() { let mut id = >::Id::default(); let id_len = id.as_ref().len(); id.as_mut().copy_from_slice(&completions_ref[.. id_len]); completions_ref = &completions_ref[id_len ..]; res.push(id); } res } fn complete(txn: &mut impl DbTxn, id: [u8; 32], tx: &N::Transaction) { let tx_id = tx.id(); // Transactions can be completed by multiple signatures // Save every solution in order to be robust TransactionDb::save_transaction::(txn, tx); let mut existing = Self::get(txn, id).unwrap_or_default(); // Don't add this TX if it's already present let tx_len = tx_id.as_ref().len(); assert_eq!(existing.len() % tx_len, 0); let mut i = 0; while i < existing.len() { if &existing[i .. (i + tx_len)] == tx_id.as_ref() { return; } i += tx_len; } existing.extend(tx_id.as_ref()); Self::set(txn, id, &existing); } } impl EventualityDb { fn save_eventuality( txn: &mut impl DbTxn, id: [u8; 32], eventuality: &N::Eventuality, ) { txn.put(Self::key(id), eventuality.serialize()); } fn eventuality(getter: &impl Get, id: [u8; 32]) -> Option { Some(N::Eventuality::read(&mut getter.get(Self::key(id))?.as_slice()).unwrap()) } } impl TransactionDb { fn save_transaction(txn: &mut impl DbTxn, tx: &N::Transaction) { Self::set(txn, tx.id().as_ref(), &tx.serialize()); } fn transaction( getter: &impl Get, id: &>::Id, ) -> Option { Self::get(getter, id.as_ref()).map(|tx| N::Transaction::read(&mut tx.as_slice()).unwrap()) } } type PreprocessFor = <::TransactionMachine as PreprocessMachine>::Preprocess; type SignMachineFor = <::TransactionMachine as PreprocessMachine>::SignMachine; type SignatureShareFor = as SignMachine<::Transaction>>::SignatureShare; type SignatureMachineFor = as SignMachine<::Transaction>>::SignatureMachine; pub struct Signer { db: PhantomData, network: N, session: Session, keys: Vec>, signable: HashMap<[u8; 32], N::SignableTransaction>, attempt: HashMap<[u8; 32], u32>, #[allow(clippy::type_complexity)] preprocessing: HashMap<[u8; 32], (Vec>, Vec>)>, #[allow(clippy::type_complexity)] signing: HashMap<[u8; 32], (SignatureMachineFor, Vec>)>, } impl fmt::Debug for Signer { fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result { fmt .debug_struct("Signer") .field("network", &self.network) .field("signable", &self.signable) .field("attempt", &self.attempt) .finish_non_exhaustive() } } impl Signer { /// Rebroadcast already signed TXs which haven't had their completions mined into a sufficiently /// confirmed block. pub async fn rebroadcast_task(db: D, network: N) { log::info!("rebroadcasting transactions for plans whose completions yet to be confirmed..."); loop { for active in ActiveSignsDb::get(&db).unwrap_or_default() { for completion in CompletionsDb::completions::(&db, active) { log::info!("rebroadcasting {}", hex::encode(&completion)); // TODO: Don't drop the error entirely. Check for invariants let _ = network .publish_transaction(&TransactionDb::transaction::(&db, &completion).unwrap()) .await; } } // Only run every five minutes so we aren't frequently loading tens to hundreds of KB from // the DB tokio::time::sleep(core::time::Duration::from_secs(5 * 60)).await; } } pub fn new(network: N, session: Session, keys: Vec>) -> Signer { assert!(!keys.is_empty()); Signer { db: PhantomData, network, session, keys, signable: HashMap::new(), attempt: HashMap::new(), preprocessing: HashMap::new(), signing: HashMap::new(), } } fn verify_id(&self, id: &SignId) -> Result<(), ()> { // Check the attempt lines up match self.attempt.get(&id.id) { // If we don't have an attempt logged, it's because the coordinator is faulty OR because we // rebooted OR we detected the signed transaction on chain, so there's notable network // latency/a malicious validator None => { warn!( "not attempting {} #{}. this is an error if we didn't reboot", hex::encode(id.id), id.attempt ); Err(())?; } Some(attempt) => { if attempt != &id.attempt { warn!( "sent signing data for {} #{} yet we have attempt #{}", hex::encode(id.id), id.attempt, attempt ); Err(())?; } } } Ok(()) } #[must_use] fn already_completed(txn: &mut D::Transaction<'_>, id: [u8; 32]) -> bool { if !CompletionsDb::completions::(txn, id).is_empty() { debug!( "SignTransaction/Reattempt order for {}, which we've already completed signing", hex::encode(id) ); true } else { false } } #[must_use] fn complete( &mut self, id: [u8; 32], tx_id: &>::Id, ) -> ProcessorMessage { // Assert we're actively signing for this TX assert!(self.signable.remove(&id).is_some(), "completed a TX we weren't signing for"); assert!(self.attempt.remove(&id).is_some(), "attempt had an ID signable didn't have"); // If we weren't selected to participate, we'll have a preprocess self.preprocessing.remove(&id); // If we were selected, the signature will only go through if we contributed a share // Despite this, we then need to get everyone's shares, and we may get a completion before // we get everyone's shares // This would be if the coordinator fails and we find the eventuality completion on-chain self.signing.remove(&id); // Emit the event for it ProcessorMessage::Completed { session: self.session, id, tx: tx_id.as_ref().to_vec() } } #[must_use] pub fn completed( &mut self, txn: &mut D::Transaction<'_>, id: [u8; 32], tx: &N::Transaction, ) -> Option { let first_completion = !Self::already_completed(txn, id); // Save this completion to the DB CompletedOnChainDb::complete_on_chain(txn, &id); CompletionsDb::complete::(txn, id, tx); if first_completion { Some(self.complete(id, &tx.id())) } else { None } } /// Returns Some if the first completion. // Doesn't use any loops/retries since we'll eventually get this from the Scanner anyways #[must_use] async fn claimed_eventuality_completion( &mut self, txn: &mut D::Transaction<'_>, id: [u8; 32], tx_id: &>::Id, ) -> Option { if let Some(eventuality) = EventualityDb::eventuality::(txn, id) { // Transaction hasn't hit our mempool/was dropped for a different signature // The latter can happen given certain latency conditions/a single malicious signer // In the case of a single malicious signer, they can drag multiple honest validators down // with them, so we unfortunately can't slash on this case let Ok(tx) = self.network.get_transaction(tx_id).await else { warn!( "a validator claimed {} completed {} yet we didn't have that TX in our mempool {}", hex::encode(tx_id), hex::encode(id), "(or had another connectivity issue)", ); return None; }; if self.network.confirm_completion(&eventuality, &tx) { info!("signer eventuality for {} resolved in TX {}", hex::encode(id), hex::encode(tx_id)); let first_completion = !Self::already_completed(txn, id); // Save this completion to the DB CompletionsDb::complete::(txn, id, &tx); if first_completion { return Some(self.complete(id, &tx.id())); } } else { warn!( "a validator claimed {} completed {} when it did not", hex::encode(tx_id), hex::encode(id) ); } } else { // If we don't have this in RAM, it should be because we already finished signing it assert!(!CompletionsDb::completions::(txn, id).is_empty()); info!( "signer {} informed of the eventuality completion for plan {}, {}", hex::encode(self.keys[0].group_key().to_bytes()), hex::encode(id), "which we already marked as completed", ); } None } #[must_use] async fn attempt( &mut self, txn: &mut D::Transaction<'_>, id: [u8; 32], attempt: u32, ) -> Option { if Self::already_completed(txn, id) { return None; } // Check if we're already working on this attempt if let Some(curr_attempt) = self.attempt.get(&id) { if curr_attempt >= &attempt { warn!( "told to attempt {} #{} yet we're already working on {}", hex::encode(id), attempt, curr_attempt ); return None; } } // Start this attempt // Clone the TX so we don't have an immutable borrow preventing the below mutable actions // (also because we do need an owned tx anyways) let Some(tx) = self.signable.get(&id).cloned() else { warn!("told to attempt a TX we aren't currently signing for"); return None; }; // Delete any existing machines self.preprocessing.remove(&id); self.signing.remove(&id); // Update the attempt number self.attempt.insert(id, attempt); let id = SignId { session: self.session, id, attempt }; info!("signing for {} #{}", hex::encode(id.id), id.attempt); // If we reboot mid-sign, the current design has us abort all signs and wait for latter // attempts/new signing protocols // This is distinct from the DKG which will continue DKG sessions, even on reboot // This is because signing is tolerant of failures of up to 1/3rd of the group // The DKG requires 100% participation // While we could apply similar tricks as the DKG (a seeded RNG) to achieve support for // reboots, it's not worth the complexity when messing up here leaks our secret share // // Despite this, on reboot, we'll get told of active signing items, and may be in this // branch again for something we've already attempted // // Only run if this hasn't already been attempted // TODO: This isn't complete as this txn may not be committed with the expected timing if AttemptDb::get(txn, &id).is_some() { warn!( "already attempted {} #{}. this is an error if we didn't reboot", hex::encode(id.id), id.attempt ); return None; } AttemptDb::set(txn, &id, &()); // Attempt to create the TX let mut machines = vec![]; let mut preprocesses = vec![]; let mut serialized_preprocesses = vec![]; for keys in &self.keys { let machine = match self.network.attempt_send(keys.clone(), tx.clone()).await { Err(e) => { error!("failed to attempt {}, #{}: {:?}", hex::encode(id.id), id.attempt, e); return None; } Ok(machine) => machine, }; let (machine, preprocess) = machine.preprocess(&mut OsRng); machines.push(machine); serialized_preprocesses.push(preprocess.serialize()); preprocesses.push(preprocess); } self.preprocessing.insert(id.id, (machines, preprocesses)); // Broadcast our preprocess Some(ProcessorMessage::Preprocess { id, preprocesses: serialized_preprocesses }) } #[must_use] pub async fn sign_transaction( &mut self, txn: &mut D::Transaction<'_>, id: [u8; 32], tx: N::SignableTransaction, eventuality: &N::Eventuality, ) -> Option { // The caller is expected to re-issue sign orders on reboot // This is solely used by the rebroadcast task ActiveSignsDb::add_active_sign(txn, &id); if Self::already_completed(txn, id) { return None; } EventualityDb::save_eventuality::(txn, id, eventuality); self.signable.insert(id, tx); self.attempt(txn, id, 0).await } #[must_use] pub async fn handle( &mut self, txn: &mut D::Transaction<'_>, msg: CoordinatorMessage, ) -> Option { match msg { CoordinatorMessage::Preprocesses { id, preprocesses } => { if self.verify_id(&id).is_err() { return None; } let (machines, our_preprocesses) = match self.preprocessing.remove(&id.id) { // Either rebooted or RPC error, or some invariant None => { warn!( "not preprocessing for {}. this is an error if we didn't reboot", hex::encode(id.id) ); return None; } Some(machine) => machine, }; let mut parsed = HashMap::new(); for l in { let mut keys = preprocesses.keys().copied().collect::>(); keys.sort(); keys } { let mut preprocess_ref = preprocesses.get(&l).unwrap().as_slice(); let Ok(res) = machines[0].read_preprocess(&mut preprocess_ref) else { return Some(ProcessorMessage::InvalidParticipant { id, participant: l }); }; if !preprocess_ref.is_empty() { return Some(ProcessorMessage::InvalidParticipant { id, participant: l }); } parsed.insert(l, res); } let preprocesses = parsed; // Only keep a single machine as we only need one to get the signature let mut signature_machine = None; let mut shares = vec![]; let mut serialized_shares = vec![]; for (m, machine) in machines.into_iter().enumerate() { let mut preprocesses = preprocesses.clone(); for (i, our_preprocess) in our_preprocesses.clone().into_iter().enumerate() { if i != m { assert!(preprocesses.insert(self.keys[i].params().i(), our_preprocess).is_none()); } } // Use an empty message, as expected of TransactionMachines let (machine, share) = match machine.sign(preprocesses, &[]) { Ok(res) => res, Err(e) => match e { FrostError::InternalError(_) | FrostError::InvalidParticipant(_, _) | FrostError::InvalidSigningSet(_) | FrostError::InvalidParticipantQuantity(_, _) | FrostError::DuplicatedParticipant(_) | FrostError::MissingParticipant(_) => unreachable!(), FrostError::InvalidPreprocess(l) | FrostError::InvalidShare(l) => { return Some(ProcessorMessage::InvalidParticipant { id, participant: l }) } }, }; if m == 0 { signature_machine = Some(machine); } serialized_shares.push(share.serialize()); shares.push(share); } self.signing.insert(id.id, (signature_machine.unwrap(), shares)); // Broadcast our shares Some(ProcessorMessage::Share { id, shares: serialized_shares }) } CoordinatorMessage::Shares { id, shares } => { if self.verify_id(&id).is_err() { return None; } let (machine, our_shares) = match self.signing.remove(&id.id) { // Rebooted, RPC error, or some invariant None => { // If preprocessing has this ID, it means we were never sent the preprocess by the // coordinator if self.preprocessing.contains_key(&id.id) { panic!("never preprocessed yet signing?"); } warn!( "not preprocessing for {}. this is an error if we didn't reboot", hex::encode(id.id) ); return None; } Some(machine) => machine, }; let mut parsed = HashMap::new(); for l in { let mut keys = shares.keys().copied().collect::>(); keys.sort(); keys } { let mut share_ref = shares.get(&l).unwrap().as_slice(); let Ok(res) = machine.read_share(&mut share_ref) else { return Some(ProcessorMessage::InvalidParticipant { id, participant: l }); }; if !share_ref.is_empty() { return Some(ProcessorMessage::InvalidParticipant { id, participant: l }); } parsed.insert(l, res); } let mut shares = parsed; for (i, our_share) in our_shares.into_iter().enumerate().skip(1) { assert!(shares.insert(self.keys[i].params().i(), our_share).is_none()); } let tx = match machine.complete(shares) { Ok(res) => res, Err(e) => match e { FrostError::InternalError(_) | FrostError::InvalidParticipant(_, _) | FrostError::InvalidSigningSet(_) | FrostError::InvalidParticipantQuantity(_, _) | FrostError::DuplicatedParticipant(_) | FrostError::MissingParticipant(_) => unreachable!(), FrostError::InvalidPreprocess(l) | FrostError::InvalidShare(l) => { return Some(ProcessorMessage::InvalidParticipant { id, participant: l }) } }, }; // Save the transaction in case it's needed for recovery CompletionsDb::complete::(txn, id.id, &tx); // Publish it let tx_id = tx.id(); if let Err(e) = self.network.publish_transaction(&tx).await { error!("couldn't publish {:?}: {:?}", tx, e); } else { info!("published {} for plan {}", hex::encode(&tx_id), hex::encode(id.id)); } // Stop trying to sign for this TX Some(self.complete(id.id, &tx_id)) } CoordinatorMessage::Reattempt { id } => self.attempt(txn, id.id, id.attempt).await, CoordinatorMessage::Completed { session: _, id, tx: mut tx_vec } => { let mut tx = >::Id::default(); if tx.as_ref().len() != tx_vec.len() { let true_len = tx_vec.len(); tx_vec.truncate(2 * tx.as_ref().len()); warn!( "a validator claimed {}... (actual length {}) completed {} yet {}", hex::encode(&tx_vec), true_len, hex::encode(id), "that's not a valid TX ID", ); return None; } tx.as_mut().copy_from_slice(&tx_vec); self.claimed_eventuality_completion(txn, id, &tx).await } } } }