Move the entirety of ed448 to Residue, offering a further 2-4x speedup

This commit is contained in:
Luke Parker
2023-04-19 04:02:59 -04:00
parent 334873b6a5
commit ff2febe5aa
4 changed files with 82 additions and 87 deletions

View File

@@ -1,10 +1,9 @@
use zeroize::Zeroize;
use zeroize::{DefaultIsZeroes, Zeroize};
use crypto_bigint::{U512, U1024};
/// Ed448 Scalar field element.
#[derive(Clone, Copy, PartialEq, Eq, Default, Debug, Zeroize)]
pub struct Scalar(pub(crate) U512);
use crypto_bigint::{
U512, U1024,
modular::constant_mod::{ResidueParams, Residue},
};
const MODULUS_PADDED_STR: &str = concat!(
"00000000000000",
@@ -13,18 +12,27 @@ const MODULUS_PADDED_STR: &str = concat!(
"7cca23e9c44edb49aed63690216cc2728dc58f552378c292ab5844f3",
);
impl_modulus!(ScalarModulus, U512, MODULUS_PADDED_STR);
type ResidueType = Residue<ScalarModulus, { ScalarModulus::LIMBS }>;
/// Ed448 Scalar field element.
#[derive(Clone, Copy, PartialEq, Eq, Default, Debug)]
pub struct Scalar(pub(crate) ResidueType);
impl DefaultIsZeroes for Scalar {}
const MODULUS_STR: &str = concat!(
"3fffffffffffffffffffffffffffffffffffffffffffffffffffffff",
"7cca23e9c44edb49aed63690216cc2728dc58f552378c292ab5844f3",
);
// 2**446 - 13818066809895115352007386748515426880336692474882178609894547503885
pub(crate) const MODULUS: Scalar = Scalar(U512::from_be_hex(concat!(
pub(crate) const MODULUS: U512 = U512::from_be_hex(concat!(
"00000000000000",
"00",
"3fffffffffffffffffffffffffffffffffffffffffffffffffffffff",
"7cca23e9c44edb49aed63690216cc2728dc58f552378c292ab5844f3",
)));
));
const WIDE_MODULUS: U1024 = U1024::from_be_hex(concat!(
"0000000000000000000000000000000000000000000000000000000000000000",
@@ -37,20 +45,12 @@ const WIDE_MODULUS: U1024 = U1024::from_be_hex(concat!(
field!(
Scalar,
MODULUS_PADDED_STR,
ResidueType,
MODULUS_STR,
MODULUS,
WIDE_MODULUS,
446,
concat!(
"7a22ac554961bc91aac7e2463961b610481b6bd7a46d27e2f41165beffffffff",
"ffffffffffffffffffffffffffffffffffffffffffffff1f0000000000000000",
),
2,
concat!(
"f24458ab92c27823558fc58d72c26c219036d6ae49db4ec4e923ca7cffffffff",
"ffffffffffffffffffffffffffffffffffffffffffffff3f0000000000000000",
),
concat!(
"0400000000000000000000000000000000000000000000000000000000000000",
"0000000000000000000000000000000000000000000000000000000000000000",
@@ -60,7 +60,7 @@ field!(
impl Scalar {
/// Perform a wide reduction to obtain a non-biased Scalar.
pub fn wide_reduce(bytes: [u8; 114]) -> Scalar {
Scalar(reduce(U1024::from_le_slice(&[bytes.as_ref(), &[0; 14]].concat())))
Scalar(Residue::new(&reduce(U1024::from_le_slice(&[bytes.as_ref(), &[0; 14]].concat()))))
}
}