absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 12:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Have Router signatures additionally sign the Router's address (B2)

Browse Source 
This slightly modifies the gas usage of the contract in a way breaking the
existing vector. A new, much simpler, vector has been provided instead.
This commit is contained in:
Luke Parker
2025-04-12 09:55:40 -04:00
parent b5608fc3d2
commit f7e63d4944
5 changed files with 75 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
processor/ethereum/router/contracts/Router.sol
View File

@@ -185,6 +185,10 @@ contract Router is IRouterWithoutCollisions {
// Read _nextNonce into memory as the nonce we'll use
nonceUsed = _nextNonce;
// We overwrite the signature response with the Router contract's address concatenated with the
// nonce. This is safe until the nonce exceeds 2**96, which is infeasible to do on-chain
uint256 signatureResponseOverwrite = (uint256(uint160(address(this))) << 96) | nonceUsed;
// Declare memory to copy the signature out to
bytes32 signatureC;
bytes32 signatureS;
@@ -199,7 +203,7 @@ contract Router is IRouterWithoutCollisions {
// Overwrite the signature challenge with the chain ID
mstore(add(message, 36), chainID)
// Overwrite the signature response with the nonce
mstore(add(message, 68), nonceUsed)
mstore(add(message, 68), signatureResponseOverwrite)
// Calculate the message hash
messageHash := keccak256(add(message, 32), messageLen)