mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 12:19:24 +00:00
Alternate handover batch TOCTOU fix (#397)
* Revert "Correct the prior documented TOCTOU" This reverts commitd50fe87801. * Correct the prior documented TOCTOUd50fe87801edited the challenge for the Batch to fix it. This won't produce Batch n+1 until Batch n is successfully published and verified. It's an alternative strategy able to be reviewed, with a much smaller impact to scope.
This commit is contained in:
@@ -39,8 +39,7 @@ pub async fn provide_batch(batch: Batch) -> [u8; 32] {
|
||||
|
||||
let block = publish_tx(&Serai::execute_batch(SignedBatch {
|
||||
batch: batch.clone(),
|
||||
// TODO: This `batch.id == 0` line only works when session == 0
|
||||
signature: pair.sign(&batch_message(batch.id == 0, &batch)),
|
||||
signature: pair.sign(&batch_message(&batch)),
|
||||
}))
|
||||
.await;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user