absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-10 21:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support v1 transactions

Browse Source 
Closes https://github.com/serai-dex/serai/issues/117.
This commit is contained in:
Luke Parker
2022-09-28 05:28:42 -04:00
parent 5a4eb0a076
commit f48a48ec3f
4 changed files with 55 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
coins/monero/src/serialize.rs
View File

@@ -94,7 +94,12 @@ pub(crate) fn read_varint<R: io::Read>(r: &mut R) -> io::Result<u64> {
Ok(res)
}
// TODO: https://github.com/serai-dex/serai/issues/25
// All scalar fields supported by monero-serai are checked to be canonical for valid transactions
// While from_bytes_mod_order would be more flexible, it's not currently needed and would be
// inaccurate to include now. While casting a wide net may be preferable, it'd also be inaccurate
// for now. There's also further edge cases as noted by
// https://github.com/monero-project/monero/issues/8438, where some scalars had an archaic
// reduction applied
pub(crate) fn read_scalar<R: io::Read>(r: &mut R) -> io::Result<Scalar> {
Scalar::from_canonical_bytes(read_bytes(r)?)
.ok_or_else(|| io::Error::new(io::ErrorKind::Other, "unreduced scalar"))