absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 04:09:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use an empty key for Batch's SignId

Browse Source
This commit is contained in:
Luke Parker
2023-08-24 20:35:50 -04:00
parent bccdabb53d
commit ea8e26eca3
5 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
processor/src/substrate_signer.rs
View File

@@ -6,7 +6,6 @@ use rand_core::OsRng;
use scale::Encode;
use transcript::{Transcript, RecommendedTranscript};
use ciphersuite::group::GroupEncoding;
use frost::{
curve::Ristretto,
ThresholdKeys,
@@ -179,7 +178,9 @@ impl<D: Db> SubstrateSigner<D> {
// Update the attempt number
self.attempt.insert(id, attempt);
let id = SignId { key: self.keys.group_key().to_bytes().to_vec(), id, attempt };
// Doesn't set key since there's only one key active at a time
// TODO: BatchSignId
let id = SignId { key: vec![], id, attempt };
info!("signing batch {} #{}", hex::encode(id.id), id.attempt);
// If we reboot mid-sign, the current design has us abort all signs and wait for latter

10
processor/src/tests/substrate_signer.rs
View File

@@ -20,14 +20,13 @@ use crate::substrate_signer::{SubstrateSignerEvent, SubstrateSigner};
#[tokio::test]
async fn test_substrate_signer() {
let mut keys = key_gen::<_, Ristretto>(&mut OsRng);
let keys = key_gen::<_, Ristretto>(&mut OsRng);
let participant_one = Participant::new(1).unwrap();
let id: u32 = 5;
let block = BlockHash([0xaa; 32]);
let mut actual_id =
SignId { key: keys[&participant_one].group_key().to_bytes().to_vec(), id: [0; 32], attempt: 0 };
let mut actual_id = SignId { key: vec![], id: [0; 32], attempt: 0 };
let batch = Batch {
network: NetworkId::Monero,
@@ -50,7 +49,7 @@ async fn test_substrate_signer() {
let mut t = 0;
for i in 1 ..= keys.len() {
let i = Participant::new(u16::try_from(i).unwrap()).unwrap();
let keys = keys.remove(&i).unwrap();
let keys = keys.get(&i).unwrap().clone();
t = keys.params().t();
let mut signer = SubstrateSigner::<MemDb>::new(NetworkId::Monero, keys);
@@ -62,7 +61,6 @@ async fn test_substrate_signer() {
signers.insert(i, signer);
dbs.insert(i, db);
}
drop(keys);
let mut signing_set = vec![];
while signing_set.len() < usize::from(t) {
@@ -144,7 +142,7 @@ async fn test_substrate_signer() {
signers.get_mut(i).unwrap().events.pop_front().unwrap()
{
assert_eq!(signed_batch.batch, batch);
assert!(Public::from_raw(actual_id.key.clone().try_into().unwrap())
assert!(Public::from_raw(keys[&participant_one].group_key().to_bytes())
.verify(&batch_message(&batch), &signed_batch.signature));
} else {
panic!("didn't get signed batch back");