Add workspace lints

substrate/abi/Cargo.toml

@@ -12,6 +12,9 @@ rust-version = "1.69"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 scale = { package = "parity-scale-codec", version = "3", features = ["derive"] }
 scale-info = { version = "2", features = ["derive"] }

substrate/client/Cargo.toml

@@ -13,6 +13,9 @@ rust-version = "1.74"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 zeroize = "^1.5"
 thiserror = { version = "1", optional = true }

substrate/client/src/serai/mod.rs

@@ -317,7 +317,6 @@ impl<'a> TemporalSerai<'a> {
     if events.is_none() {
       drop(events);
       let mut events_write = self.events.write().await;
-      #[allow(clippy::unwrap_or_default)]
       if events_write.is_none() {
         *events_write = Some(self.storage("System", "Events", ()).await?.unwrap_or(vec![]));
       }

substrate/coins/pallet/Cargo.toml

@@ -15,6 +15,9 @@ rustdoc-args = ["--cfg", "docsrs"]
 [package.metadata.cargo-machete]
 ignored = ["scale", "scale-info"]
 
+[lints]
+workspace = true
+
 [dependencies]
 scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive"] }
 scale-info = { version = "2", default-features = false, features = ["derive"] }

substrate/coins/pallet/src/lib.rs

@@ -12,6 +12,7 @@ impl AllowMint for () {
   }
 }
 
+#[allow(clippy::cast_possible_truncation)] // TODO: Investigate why Substrate generates this
 #[frame_support::pallet]
 pub mod pallet {
   use super::*;

substrate/coins/primitives/Cargo.toml

@@ -11,6 +11,9 @@ rust-version = "1.69"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 zeroize = { version = "^1.5", features = ["derive"], optional = true }
 

substrate/dex/pallet/Cargo.toml

@@ -15,6 +15,9 @@ rustdoc-args = ["--cfg", "docsrs"]
 [package.metadata.cargo-machete]
 ignored = ["scale", "scale-info"]
 
+[lints]
+workspace = true
+
 [dependencies]
 scale = { package = "parity-scale-codec", version = "3.6.1", default-features = false }
 scale-info = { version = "2.5.0", default-features = false, features = ["derive"] }

substrate/dex/pallet/src/lib.rs

@@ -94,6 +94,7 @@ use sp_std::prelude::*;
 pub use types::*;
 pub use weights::WeightInfo;
 
+#[allow(clippy::cast_possible_truncation)] // TODO: Investigate why Substrate generates this
 #[frame_support::pallet]
 pub mod pallet {
   use super::*;
@@ -751,7 +752,7 @@ pub mod pallet {
         )?;
 
         let mut i = 0;
-        let path_len = path.len() as u32;
+        let path_len = u32::try_from(path.len()).unwrap();
         #[allow(clippy::explicit_counter_loop)]
         for coins_pair in path.windows(2) {
           if let [coin1, coin2] = coins_pair {

substrate/in-instructions/pallet/Cargo.toml

@@ -15,6 +15,9 @@ rustdoc-args = ["--cfg", "docsrs"]
 [package.metadata.cargo-machete]
 ignored = ["scale", "scale-info"]
 
+[lints]
+workspace = true
+
 [dependencies]
 scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive", "max-encoded-len"] }
 scale-info = { version = "2", default-features = false, features = ["derive"] }

substrate/in-instructions/pallet/src/lib.rs

@@ -9,6 +9,7 @@ use serai_primitives::{BlockHash, NetworkId};
 pub use in_instructions_primitives as primitives;
 use primitives::*;
 
+#[allow(clippy::cast_possible_truncation)] // TODO: Investigate why Substrate generates this
 #[frame_support::pallet]
 pub mod pallet {
   use sp_std::vec;

substrate/in-instructions/primitives/Cargo.toml

@@ -11,6 +11,9 @@ rust-version = "1.69"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 zeroize = { version = "^1.5", features = ["derive"], optional = true }
 

substrate/node/Cargo.toml

@@ -9,6 +9,13 @@ edition = "2021"
 publish = false
 rust-version = "1.74"
 
+[package.metadata.docs.rs]
+all-features = true
+rustdoc-args = ["--cfg", "docsrs"]
+
+[lints]
+workspace = true
+
 [[bin]]
 name = "serai-node"
 

substrate/node/src/service.rs

@@ -124,7 +124,7 @@ pub fn new_partial(config: &Configuration) -> Result<PartialComponents, ServiceE
       justification_import: Some(Box::new(justification_import)),
       client: client.clone(),
       select_chain: select_chain.clone(),
-      create_inherent_data_providers: move |_, _| async move {
+      create_inherent_data_providers: move |_, ()| async move {
         Ok(create_inherent_data_providers(slot_duration))
       },
       spawner: &task_manager.spawn_essential_handle(),
@@ -259,7 +259,7 @@ pub async fn new_full(config: Configuration) -> Result<TaskManager, ServiceError
       block_import,
       sync_oracle: sync_service.clone(),
       justification_sync_link: sync_service.clone(),
-      create_inherent_data_providers: move |_, _| async move {
+      create_inherent_data_providers: move |_, ()| async move {
         Ok(create_inherent_data_providers(slot_duration))
       },
       force_authoring,

substrate/primitives/Cargo.toml

@@ -12,6 +12,9 @@ rust-version = "1.69"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 zeroize = { version = "^1.5", features = ["derive"], optional = true }
 

substrate/runtime/Cargo.toml

@@ -15,6 +15,9 @@ rustdoc-args = ["--cfg", "docsrs"]
 [package.metadata.cargo-machete]
 ignored = ["scale", "scale-info"]
 
+[lints]
+workspace = true
+
 [dependencies]
 scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive"] }
 scale-info = { version = "2", default-features = false, features = ["derive"] }

substrate/runtime/src/lib.rs

@@ -268,8 +268,10 @@ impl Convert<PublicKey, Option<PublicKey>> for IdentityValidatorIdOf {
 impl signals::Config for Runtime {
   type RuntimeEvent = RuntimeEvent;
   // 1 week
+  #[allow(clippy::cast_possible_truncation)]
   type RetirementValidityDuration = ConstU32<{ (7 * 24 * 60 * 60) / (TARGET_BLOCK_TIME as u32) }>;
   // 2 weeks
+  #[allow(clippy::cast_possible_truncation)]
   type RetirementLockInDuration = ConstU32<{ (2 * 7 * 24 * 60 * 60) / (TARGET_BLOCK_TIME as u32) }>;
 }
 

substrate/signals/pallet/Cargo.toml

@@ -15,6 +15,9 @@ rustdoc-args = ["--cfg", "docsrs"]
 [package.metadata.cargo-machete]
 ignored = ["scale", "scale-info"]
 
+[lints]
+workspace = true
+
 [dependencies]
 scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive"] }
 scale-info = { version = "2", default-features = false, features = ["derive"] }

substrate/signals/pallet/src/lib.rs

@@ -1,6 +1,11 @@
 #![cfg_attr(not(feature = "std"), no_std)]
 
-#[allow(deprecated, clippy::let_unit_value)] // TODO
+#[allow(
+  deprecated,
+  clippy::let_unit_value,
+  clippy::cast_possible_truncation,
+  clippy::ignored_unit_patterns
+)] // TODO
 #[frame_support::pallet]
 pub mod pallet {
   use scale_info::TypeInfo;

substrate/signals/primitives/Cargo.toml

@@ -12,6 +12,9 @@ rust-version = "1.74"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 zeroize = { version = "^1.5", features = ["derive"], optional = true }
 

substrate/validator-sets/pallet/Cargo.toml

@@ -15,6 +15,9 @@ rustdoc-args = ["--cfg", "docsrs"]
 [package.metadata.cargo-machete]
 ignored = ["scale", "scale-info"]
 
+[lints]
+workspace = true
+
 [dependencies]
 hashbrown = { version = "0.14", default-features = false, features = ["ahash", "inline-more"] }
 

substrate/validator-sets/pallet/src/lib.rs

@@ -53,11 +53,16 @@ impl<T: pallet::Config> GetValidatorCount for MembershipProof<T> {
   // rely on it and Substrate only relies on it to offer economic calculations we also don't rely
   // on
   fn validator_count(&self) -> u32 {
-    Babe::<T>::authorities().len() as u32
+    u32::try_from(Babe::<T>::authorities().len()).unwrap()
   }
 }
 
-#[allow(deprecated, clippy::let_unit_value)] // TODO
+#[allow(
+  deprecated,
+  clippy::let_unit_value,
+  clippy::cast_possible_truncation,
+  clippy::ignored_unit_patterns
+)] // TODO
 #[frame_support::pallet]
 pub mod pallet {
   use super::*;
@@ -717,7 +722,7 @@ pub mod pallet {
           None,
         ),
         WeakBoundedVec::force_from(
-          next_validators.iter().cloned().map(|(id, w)| (BabeAuthorityId::from(id), w)).collect(),
+          next_validators.iter().copied().map(|(id, w)| (BabeAuthorityId::from(id), w)).collect(),
           None,
         ),
         Some(session),

substrate/validator-sets/primitives/Cargo.toml

@@ -12,6 +12,9 @@ rust-version = "1.74"
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 zeroize = { version = "^1.5", features = ["derive"], optional = true }