One Round DKG (#589)

* Upstream GBP, divisor, circuit abstraction, and EC gadgets from FCMP++

* Initial eVRF implementation

Not quite done yet. It needs to communicate the resulting points and proofs to
extract them from the Pedersen Commitments in order to return those, and then
be tested.

* Add the openings of the PCs to the eVRF as necessary

* Add implementation of secq256k1

* Make DKG Encryption a bit more flexible

No longer requires the use of an EncryptionKeyMessage, and allows pre-defined
keys for encryption.

* Make NUM_BITS an argument for the field macro

* Have the eVRF take a Zeroizing private key

* Initial eVRF-based DKG

* Add embedwards25519 curve

* Inline the eVRF into the DKG library

Due to how we're handling share encryption, we'd either need two circuits or to
dedicate this circuit to the DKG. The latter makes sense at this time.

* Add documentation to the eVRF-based DKG

* Add paragraph claiming robustness

* Update to the new eVRF proof

* Finish routing the eVRF functionality

Still needs errors and serialization, along with a few other TODOs.

* Add initial eVRF DKG test

* Improve eVRF DKG

Updates how we calculcate verification shares, improves performance when
extracting multiple sets of keys, and adds more to the test for it.

* Start using a proper error for the eVRF DKG

* Resolve various TODOs

Supports recovering multiple key shares from the eVRF DKG.

Inlines two loops to save 2**16 iterations.

Adds support for creating a constant time representation of scalars < NUM_BITS.

* Ban zero ECDH keys, document non-zero requirements

* Implement eVRF traits, all the way up to the DKG, for secp256k1/ed25519

* Add Ristretto eVRF trait impls

* Support participating multiple times in the eVRF DKG

* Only participate once per key, not once per key share

* Rewrite processor key-gen around the eVRF DKG

Still a WIP.

* Finish routing the new key gen in the processor

Doesn't touch the tests, coordinator, nor Substrate yet.
`cargo +nightly fmt && cargo +nightly-2024-07-01 clippy --all-features -p serai-processor`
does pass.

* Deduplicate and better document in processor key_gen

* Update serai-processor tests to the new key gen

* Correct amount of yx coefficients, get processor key gen test to pass

* Add embedded elliptic curve keys to Substrate

* Update processor key gen tests to the eVRF DKG

* Have set_keys take signature_participants, not removed_participants

Now no one is removed from the DKG. Only `t` people publish the key however.

Uses a BitVec for an efficient encoding of the participants.

* Update the coordinator binary for the new DKG

This does not yet update any tests.

* Add sensible Debug to key_gen::[Processor, Coordinator]Message

* Have the DKG explicitly declare how to interpolate its shares

Removes the hack for MuSig where we multiply keys by the inverse of their
lagrange interpolation factor.

* Replace Interpolation::None with Interpolation::Constant

Allows the MuSig DKG to keep the secret share as the original private key,
enabling deriving FROST nonces consistently regardless of the MuSig context.

* Get coordinator tests to pass

* Update spec to the new DKG

* Get clippy to pass across the repo

* cargo machete

* Add an extra sleep to ensure expected ordering of `Participation`s

* Update orchestration

* Remove bad panic in coordinator

It expected ConfirmationShare to be n-of-n, not t-of-n.

* Improve documentation on  functions

* Update TX size limit

We now no longer have to support the ridiculous case of having 49 DKG
participations within a 101-of-150 DKG. It does remain quite high due to
needing to _sign_ so many times. It'd may be optimal for parties with multiple
key shares to independently send their preprocesses/shares (despite the
overhead that'll cause with signatures and the transaction structure).

* Correct error in the Processor spec document

* Update a few comments in the validator-sets pallet

* Send/Recv Participation one at a time

Sending all, then attempting to receive all in an expected order, wasn't working
even with notable delays between sending messages. This points to the mempool
not working as expected...

* Correct ThresholdKeys serialization in modular-frost test

* Updating existing TX size limit test for the new DKG parameters

* Increase time allowed for the DKG on the GH CI

* Correct construction of signature_participants in serai-client tests

Fault identified by akil.

* Further contextualize DkgConfirmer by ValidatorSet

Caught by a safety check we wouldn't reuse preprocesses across messages. That
raises the question of we were prior reusing preprocesses (reusing keys)?
Except that'd have caused a variety of signing failures (suggesting we had some
staggered timing avoiding it in practice but yes, this was possible in theory).

* Add necessary calls to set_embedded_elliptic_curve_key in coordinator set rotation tests

* Correct shimmed setting of a secq256k1 key

* cargo fmt

* Don't use `[0; 32]` for the embedded keys in the coordinator rotation test

The key_gen function expects the random values already decided.

* Big-endian secq256k1 scalars

Also restores the prior, safer, Encryption::register function.

crypto/evrf/generalized-bulletproofs/src/tests/arithmetic_circuit_proof.rs

@@ -0,0 +1,250 @@
+use rand_core::{RngCore, OsRng};
+
+use ciphersuite::{group::ff::Field, Ciphersuite, Ristretto};
+
+use crate::{
+  ScalarVector, PedersenCommitment, PedersenVectorCommitment,
+  transcript::*,
+  arithmetic_circuit_proof::{
+    Variable, LinComb, ArithmeticCircuitStatement, ArithmeticCircuitWitness,
+  },
+  tests::generators,
+};
+
+#[test]
+fn test_zero_arithmetic_circuit() {
+  let generators = generators(1);
+
+  let value = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let gamma = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let commitment = (generators.g() * value) + (generators.h() * gamma);
+  let V = vec![commitment];
+
+  let aL = ScalarVector::<<Ristretto as Ciphersuite>::F>(vec![<Ristretto as Ciphersuite>::F::ZERO]);
+  let aR = aL.clone();
+
+  let mut transcript = Transcript::new([0; 32]);
+  let commitments = transcript.write_commitments(vec![], V);
+  let statement = ArithmeticCircuitStatement::<Ristretto>::new(
+    generators.reduce(1).unwrap(),
+    vec![],
+    commitments.clone(),
+  )
+  .unwrap();
+  let witness = ArithmeticCircuitWitness::<Ristretto>::new(
+    aL,
+    aR,
+    vec![],
+    vec![PedersenCommitment { value, mask: gamma }],
+  )
+  .unwrap();
+
+  let proof = {
+    statement.clone().prove(&mut OsRng, &mut transcript, witness).unwrap();
+    transcript.complete()
+  };
+  let mut verifier = generators.batch_verifier();
+
+  let mut transcript = VerifierTranscript::new([0; 32], &proof);
+  let verifier_commmitments = transcript.read_commitments(0, 1);
+  assert_eq!(commitments, verifier_commmitments.unwrap());
+  statement.verify(&mut OsRng, &mut verifier, &mut transcript).unwrap();
+  assert!(generators.verify(verifier));
+}
+
+#[test]
+fn test_vector_commitment_arithmetic_circuit() {
+  let generators = generators(2);
+  let reduced = generators.reduce(2).unwrap();
+
+  let v1 = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let v2 = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let v3 = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let v4 = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let gamma = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+  let commitment = (reduced.g_bold(0) * v1) +
+    (reduced.g_bold(1) * v2) +
+    (reduced.h_bold(0) * v3) +
+    (reduced.h_bold(1) * v4) +
+    (generators.h() * gamma);
+  let V = vec![];
+  let C = vec![commitment];
+
+  let zero_vec =
+    || ScalarVector::<<Ristretto as Ciphersuite>::F>(vec![<Ristretto as Ciphersuite>::F::ZERO]);
+
+  let aL = zero_vec();
+  let aR = zero_vec();
+
+  let mut transcript = Transcript::new([0; 32]);
+  let commitments = transcript.write_commitments(C, V);
+  let statement = ArithmeticCircuitStatement::<Ristretto>::new(
+    reduced,
+    vec![LinComb::empty()
+      .term(<Ristretto as Ciphersuite>::F::ONE, Variable::CG { commitment: 0, index: 0 })
+      .term(<Ristretto as Ciphersuite>::F::from(2u64), Variable::CG { commitment: 0, index: 1 })
+      .term(<Ristretto as Ciphersuite>::F::from(3u64), Variable::CH { commitment: 0, index: 0 })
+      .term(<Ristretto as Ciphersuite>::F::from(4u64), Variable::CH { commitment: 0, index: 1 })
+      .constant(-(v1 + (v2 + v2) + (v3 + v3 + v3) + (v4 + v4 + v4 + v4)))],
+    commitments.clone(),
+  )
+  .unwrap();
+  let witness = ArithmeticCircuitWitness::<Ristretto>::new(
+    aL,
+    aR,
+    vec![PedersenVectorCommitment {
+      g_values: ScalarVector(vec![v1, v2]),
+      h_values: ScalarVector(vec![v3, v4]),
+      mask: gamma,
+    }],
+    vec![],
+  )
+  .unwrap();
+
+  let proof = {
+    statement.clone().prove(&mut OsRng, &mut transcript, witness).unwrap();
+    transcript.complete()
+  };
+  let mut verifier = generators.batch_verifier();
+
+  let mut transcript = VerifierTranscript::new([0; 32], &proof);
+  let verifier_commmitments = transcript.read_commitments(1, 0);
+  assert_eq!(commitments, verifier_commmitments.unwrap());
+  statement.verify(&mut OsRng, &mut verifier, &mut transcript).unwrap();
+  assert!(generators.verify(verifier));
+}
+
+#[test]
+fn fuzz_test_arithmetic_circuit() {
+  let generators = generators(32);
+
+  for i in 0 .. 100 {
+    dbg!(i);
+
+    // Create aL, aR, aO
+    let mut aL = ScalarVector(vec![]);
+    let mut aR = ScalarVector(vec![]);
+    while aL.len() < ((OsRng.next_u64() % 8) + 1).try_into().unwrap() {
+      aL.0.push(<Ristretto as Ciphersuite>::F::random(&mut OsRng));
+    }
+    while aR.len() < aL.len() {
+      aR.0.push(<Ristretto as Ciphersuite>::F::random(&mut OsRng));
+    }
+    let aO = aL.clone() * &aR;
+
+    // Create C
+    let mut C = vec![];
+    while C.len() < (OsRng.next_u64() % 16).try_into().unwrap() {
+      let mut g_values = ScalarVector(vec![]);
+      while g_values.0.len() < ((OsRng.next_u64() % 8) + 1).try_into().unwrap() {
+        g_values.0.push(<Ristretto as Ciphersuite>::F::random(&mut OsRng));
+      }
+      let mut h_values = ScalarVector(vec![]);
+      while h_values.0.len() < ((OsRng.next_u64() % 8) + 1).try_into().unwrap() {
+        h_values.0.push(<Ristretto as Ciphersuite>::F::random(&mut OsRng));
+      }
+      C.push(PedersenVectorCommitment {
+        g_values,
+        h_values,
+        mask: <Ristretto as Ciphersuite>::F::random(&mut OsRng),
+      });
+    }
+
+    // Create V
+    let mut V = vec![];
+    while V.len() < (OsRng.next_u64() % 4).try_into().unwrap() {
+      V.push(PedersenCommitment {
+        value: <Ristretto as Ciphersuite>::F::random(&mut OsRng),
+        mask: <Ristretto as Ciphersuite>::F::random(&mut OsRng),
+      });
+    }
+
+    // Generate random constraints
+    let mut constraints = vec![];
+    for _ in 0 .. (OsRng.next_u64() % 8).try_into().unwrap() {
+      let mut eval = <Ristretto as Ciphersuite>::F::ZERO;
+      let mut constraint = LinComb::empty();
+
+      for _ in 0 .. (OsRng.next_u64() % 4) {
+        let index = usize::try_from(OsRng.next_u64()).unwrap() % aL.len();
+        let weight = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+        constraint = constraint.term(weight, Variable::aL(index));
+        eval += weight * aL[index];
+      }
+
+      for _ in 0 .. (OsRng.next_u64() % 4) {
+        let index = usize::try_from(OsRng.next_u64()).unwrap() % aR.len();
+        let weight = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+        constraint = constraint.term(weight, Variable::aR(index));
+        eval += weight * aR[index];
+      }
+
+      for _ in 0 .. (OsRng.next_u64() % 4) {
+        let index = usize::try_from(OsRng.next_u64()).unwrap() % aO.len();
+        let weight = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+        constraint = constraint.term(weight, Variable::aO(index));
+        eval += weight * aO[index];
+      }
+
+      for (commitment, C) in C.iter().enumerate() {
+        for _ in 0 .. (OsRng.next_u64() % 4) {
+          let index = usize::try_from(OsRng.next_u64()).unwrap() % C.g_values.len();
+          let weight = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+          constraint = constraint.term(weight, Variable::CG { commitment, index });
+          eval += weight * C.g_values[index];
+        }
+
+        for _ in 0 .. (OsRng.next_u64() % 4) {
+          let index = usize::try_from(OsRng.next_u64()).unwrap() % C.h_values.len();
+          let weight = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+          constraint = constraint.term(weight, Variable::CH { commitment, index });
+          eval += weight * C.h_values[index];
+        }
+      }
+
+      if !V.is_empty() {
+        for _ in 0 .. (OsRng.next_u64() % 4) {
+          let index = usize::try_from(OsRng.next_u64()).unwrap() % V.len();
+          let weight = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+          constraint = constraint.term(weight, Variable::V(index));
+          eval += weight * V[index].value;
+        }
+      }
+
+      constraint = constraint.constant(-eval);
+
+      constraints.push(constraint);
+    }
+
+    let mut transcript = Transcript::new([0; 32]);
+    let commitments = transcript.write_commitments(
+      C.iter()
+        .map(|C| {
+          C.commit(generators.g_bold_slice(), generators.h_bold_slice(), generators.h()).unwrap()
+        })
+        .collect(),
+      V.iter().map(|V| V.commit(generators.g(), generators.h())).collect(),
+    );
+
+    let statement = ArithmeticCircuitStatement::<Ristretto>::new(
+      generators.reduce(16).unwrap(),
+      constraints,
+      commitments.clone(),
+    )
+    .unwrap();
+
+    let witness = ArithmeticCircuitWitness::<Ristretto>::new(aL, aR, C.clone(), V.clone()).unwrap();
+
+    let proof = {
+      statement.clone().prove(&mut OsRng, &mut transcript, witness).unwrap();
+      transcript.complete()
+    };
+    let mut verifier = generators.batch_verifier();
+
+    let mut transcript = VerifierTranscript::new([0; 32], &proof);
+    let verifier_commmitments = transcript.read_commitments(C.len(), V.len());
+    assert_eq!(commitments, verifier_commmitments.unwrap());
+    statement.verify(&mut OsRng, &mut verifier, &mut transcript).unwrap();
+    assert!(generators.verify(verifier));
+  }
+}

crypto/evrf/generalized-bulletproofs/src/tests/inner_product.rs

@@ -0,0 +1,113 @@
+// The inner product relation is P = sum(g_bold * a, h_bold * b, g * (a * b))
+
+use rand_core::OsRng;
+
+use ciphersuite::{
+  group::{ff::Field, Group},
+  Ciphersuite, Ristretto,
+};
+
+use crate::{
+  ScalarVector, PointVector,
+  transcript::*,
+  inner_product::{P, IpStatement, IpWitness},
+  tests::generators,
+};
+
+#[test]
+fn test_zero_inner_product() {
+  let P = <Ristretto as Ciphersuite>::G::identity();
+
+  let generators = generators::<Ristretto>(1);
+  let reduced = generators.reduce(1).unwrap();
+  let witness = IpWitness::<Ristretto>::new(
+    ScalarVector::<<Ristretto as Ciphersuite>::F>::new(1),
+    ScalarVector::<<Ristretto as Ciphersuite>::F>::new(1),
+  )
+  .unwrap();
+
+  let proof = {
+    let mut transcript = Transcript::new([0; 32]);
+    IpStatement::<Ristretto>::new(
+      reduced,
+      ScalarVector(vec![<Ristretto as Ciphersuite>::F::ONE; 1]),
+      <Ristretto as Ciphersuite>::F::ONE,
+      P::Prover(P),
+    )
+    .unwrap()
+    .clone()
+    .prove(&mut transcript, witness)
+    .unwrap();
+    transcript.complete()
+  };
+
+  let mut verifier = generators.batch_verifier();
+  IpStatement::<Ristretto>::new(
+    reduced,
+    ScalarVector(vec![<Ristretto as Ciphersuite>::F::ONE; 1]),
+    <Ristretto as Ciphersuite>::F::ONE,
+    P::Verifier { verifier_weight: <Ristretto as Ciphersuite>::F::ONE },
+  )
+  .unwrap()
+  .verify(&mut verifier, &mut VerifierTranscript::new([0; 32], &proof))
+  .unwrap();
+  assert!(generators.verify(verifier));
+}
+
+#[test]
+fn test_inner_product() {
+  // P = sum(g_bold * a, h_bold * b)
+  let generators = generators::<Ristretto>(32);
+  let mut verifier = generators.batch_verifier();
+  for i in [1, 2, 4, 8, 16, 32] {
+    let generators = generators.reduce(i).unwrap();
+    let g = generators.g();
+    assert_eq!(generators.len(), i);
+    let mut g_bold = vec![];
+    let mut h_bold = vec![];
+    for i in 0 .. i {
+      g_bold.push(generators.g_bold(i));
+      h_bold.push(generators.h_bold(i));
+    }
+    let g_bold = PointVector::<Ristretto>(g_bold);
+    let h_bold = PointVector::<Ristretto>(h_bold);
+
+    let mut a = ScalarVector::<<Ristretto as Ciphersuite>::F>::new(i);
+    let mut b = ScalarVector::<<Ristretto as Ciphersuite>::F>::new(i);
+
+    for i in 0 .. i {
+      a[i] = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+      b[i] = <Ristretto as Ciphersuite>::F::random(&mut OsRng);
+    }
+
+    let P = g_bold.multiexp(&a) + h_bold.multiexp(&b) + (g * a.inner_product(b.0.iter()));
+
+    let witness = IpWitness::<Ristretto>::new(a, b).unwrap();
+
+    let proof = {
+      let mut transcript = Transcript::new([0; 32]);
+      IpStatement::<Ristretto>::new(
+        generators,
+        ScalarVector(vec![<Ristretto as Ciphersuite>::F::ONE; i]),
+        <Ristretto as Ciphersuite>::F::ONE,
+        P::Prover(P),
+      )
+      .unwrap()
+      .prove(&mut transcript, witness)
+      .unwrap();
+      transcript.complete()
+    };
+
+    verifier.additional.push((<Ristretto as Ciphersuite>::F::ONE, P));
+    IpStatement::<Ristretto>::new(
+      generators,
+      ScalarVector(vec![<Ristretto as Ciphersuite>::F::ONE; i]),
+      <Ristretto as Ciphersuite>::F::ONE,
+      P::Verifier { verifier_weight: <Ristretto as Ciphersuite>::F::ONE },
+    )
+    .unwrap()
+    .verify(&mut verifier, &mut VerifierTranscript::new([0; 32], &proof))
+    .unwrap();
+  }
+  assert!(generators.verify(verifier));
+}

crypto/evrf/generalized-bulletproofs/src/tests/mod.rs

@@ -0,0 +1,27 @@
+use rand_core::OsRng;
+
+use ciphersuite::{group::Group, Ciphersuite};
+
+use crate::{Generators, padded_pow_of_2};
+
+#[cfg(test)]
+mod inner_product;
+
+#[cfg(test)]
+mod arithmetic_circuit_proof;
+
+/// Generate a set of generators for testing purposes.
+///
+/// This should not be considered secure.
+pub fn generators<C: Ciphersuite>(n: usize) -> Generators<C> {
+  assert_eq!(padded_pow_of_2(n), n, "amount of generators wasn't a power of 2");
+
+  let gens = || {
+    let mut res = Vec::with_capacity(n);
+    for _ in 0 .. n {
+      res.push(C::G::random(&mut OsRng));
+    }
+    res
+  };
+  Generators::new(C::G::random(&mut OsRng), C::G::random(&mut OsRng), gens(), gens()).unwrap()
+}