absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-09 04:39:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make TransactionKind have a reference to Signed

Browse Source 
Broken commit due to partial staging of one file.
This commit is contained in:
Luke Parker
2023-04-12 09:38:20 -04:00
parent 354ac856a5
commit d5a12a9b97
4 changed files with 41 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
coordinator/tributary/src/transaction.rs
View File

@@ -53,7 +53,7 @@ impl ReadWrite for Signed {
#[allow(clippy::large_enum_variant)]
#[derive(Clone, PartialEq, Eq, Debug)]
pub enum TransactionKind {
pub enum TransactionKind<'a> {
/// This tranaction should be provided by every validator, solely ordered by the block producer.
///
/// This transaction is only valid if a supermajority of validators provided it.
@@ -63,11 +63,11 @@ pub enum TransactionKind {
Unsigned,
/// A signed transaction.
Signed(Signed),
Signed(&'a Signed),
}
pub trait Transaction: Send + Sync + Clone + Eq + Debug + ReadWrite {
fn kind(&self) -> TransactionKind;
fn kind(&self) -> TransactionKind<'_>;
/// Return the hash of this transaction.
///
/// The hash must NOT commit to the signature.
@@ -97,13 +97,13 @@ pub(crate) fn verify_transaction<T: Transaction>(
TransactionKind::Unsigned => {}
TransactionKind::Signed(Signed { signer, nonce, signature }) => {
// TODO: Use presence as a whitelist, erroring on lack of
if next_nonces.get(&signer).cloned().unwrap_or(0) != nonce {
if next_nonces.get(signer).cloned().unwrap_or(0) != *nonce {
Err(TransactionError::Temporal)?;
}
next_nonces.insert(signer, nonce + 1);
next_nonces.insert(*signer, nonce + 1);
// TODO: Use Schnorr half-aggregation and a batch verification here
if !signature.verify(signer, tx.sig_hash(genesis)) {
if !signature.verify(*signer, tx.sig_hash(genesis)) {
Err(TransactionError::Fatal)?;
}
}