absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 12:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Verify Batch signatures

Browse Source 
Starts further fleshing out the Serai client tests with common utils.
This commit is contained in:
Luke Parker
2023-03-31 06:34:09 -04:00
parent 30b8636641
commit ae4e98c052
14 changed files with 291 additions and 201 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
substrate/in-instructions/pallet/Cargo.toml
View File

@@ -17,6 +17,7 @@ thiserror = { version = "1", optional = true }
scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive", "max-encoded-len"] }
scale-info = { version = "2", default-features = false, features = ["derive"] }
sp-application-crypto = { git = "https://github.com/serai-dex/substrate", default-features = false }
sp-runtime = { git = "https://github.com/serai-dex/substrate", default-features = false }
frame-system = { git = "https://github.com/serai-dex/substrate", default-features = false }
@@ -26,6 +27,7 @@ serai-primitives = { path = "../../serai/primitives", default-features = false }
in-instructions-primitives = { path = "../primitives", default-features = false }
tokens-pallet = { path = "../../tokens/pallet", default-features = false }
validator-sets-pallet = { path = "../../validator-sets/pallet", default-features = false }
[features]
std = [

36
substrate/in-instructions/pallet/src/lib.rs
View File

@@ -22,15 +22,23 @@ pub enum PalletError {
#[frame_support::pallet]
pub mod pallet {
use sp_application_crypto::RuntimePublic;
use frame_support::pallet_prelude::*;
use frame_system::pallet_prelude::*;
use tokens_pallet::{Config as TokensConfig, Pallet as Tokens};
use validator_sets_pallet::{
primitives::{Session, ValidatorSet},
Config as ValidatorSetsConfig, Pallet as ValidatorSets,
};
use super::*;
#[pallet::config]
pub trait Config: frame_system::Config<BlockNumber = u64> + TokensConfig {
pub trait Config:
frame_system::Config<BlockNumber = u64> + ValidatorSetsConfig + TokensConfig
{
type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
}
@@ -101,9 +109,31 @@ pub mod pallet {
let network = batch.batch.network;
// TODO: Get the key for this network or Err(UnrecognizedNetwork)
// TODO: Get the latest session
let session = Session(0);
// TODO: Verify the signature or Err(InvalidSignature)
let mut set = ValidatorSet { session, network };
// TODO: If this session just set their keys, it'll invalidate anything in the mempool
// Should there be a transitory period/future-set cut off?
let key = if let Some(keys) = ValidatorSets::<T>::keys(set) {
keys.0
} else {
// If this set hasn't set their keys yet, use the previous set's
if set.session.0 == 0 {
Err(InvalidTransaction::BadProof)?;
}
set.session.0 -= 1;
if let Some(keys) = ValidatorSets::<T>::keys(set) {
keys.0
} else {
Err(InvalidTransaction::BadProof)?
}
};
if !key.verify(&batch.batch.encode(), &batch.signature) {
Err(InvalidTransaction::BadProof)?;
}
// Verify the batch is sequential
// Batches has the last ID set. The next ID should be it + 1