From a9072e6b1bb72cf8bad2ebefc51fa18d2b7ed2a3 Mon Sep 17 00:00:00 2001 From: Luke Parker Date: Sun, 16 Jul 2023 20:38:13 -0400 Subject: [PATCH] Remove signature from get_next_message Duee to signature replaying, it's very annoying to provide meanigful data access privacy. None of these messages should be private/have sensitive data anyways though. --- message-queue/src/main.rs | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/message-queue/src/main.rs b/message-queue/src/main.rs index aa059de5..eb5203d5 100644 --- a/message-queue/src/main.rs +++ b/message-queue/src/main.rs @@ -44,13 +44,7 @@ fn queue_message(meta: Metadata, msg: Vec, sig: SchnorrSignature) } // get RPC method -fn get_next_message( - service: Service, - _expected: u64, - _signature: SchnorrSignature, -) -> Option { - // TODO: Verify the signature - +fn get_next_message(service: Service, _expected: u64) -> Option { // TODO: Verify the expected next message ID matches let queue_outer = (*QUEUES).read().unwrap(); @@ -129,11 +123,7 @@ async fn main() { module .register_method("next", |args, _| { let args = args.parse::<(Service, u64, Vec)>().unwrap(); - get_next_message( - args.0, - args.1, - SchnorrSignature::::read(&mut args.2.as_slice()).unwrap(), - ); + get_next_message(args.0, args.1); Ok(()) }) .unwrap();