Smash the singular Ciphersuite trait into multiple

This helps identify where the various functionalities are used, or rather, not
used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating
the entire FCMP++ tree, only requires the markers _and_ canonical point
decoding. I've opened a PR to upstream such a trait into `group`
(https://github.com/zkcrypto/group/pull/68).

`WrappedGroup` is still justified for as long as `Group::generator` exists.
Moving `::generator()` to its own trait, on an independent structure (upstream)
would be massively appreciated. @tarcieri also wanted to update from
`fn generator()` to `const GENERATOR`, which would encourage further discussion
on https://github.com/zkcrypto/group/issues/32 and
https://github.com/zkcrypto/group/issues/45, which have been stagnant.

The `Id` trait is occasionally used yet really should be first off the chopping
block.

Finally, `WithPreferredHash` is only actually used around a third of the time,
which more than justifies it being a separate trait.

---

Updates `dalek_ff_group::Scalar` to directly re-export
`curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint`
also could be replaced with an export of `curve25519_dalek::RistrettoPoint`,
yet the coordinator relies on how we implemented `Hash` on it for the hell of
it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be
replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't
implement `zeroize`, `subtle` traits within a released, non-yanked version.
Relevance to https://github.com/serai-dex/serai/issues/201 and
https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746.

Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over
`SHA2-512`. In order to maintain compliance with FROST's IETF standard,
`modular-frost` defines its own ciphersuite for Ristretto which still uses
`SHA2-512`.

substrate/client/Cargo.toml

@@ -41,9 +41,9 @@ simple-request = { path = "../../common/request", version = "0.1", optional = tr
 
 bitcoin = { version = "0.32", optional = true }
 
+ciphersuite = { path = "../../crypto/ciphersuite", optional = true }
 dalek-ff-group = { path = "../../crypto/dalek-ff-group", optional = true }
-ciphersuite = { path = "../../crypto/ciphersuite", version = "0.4", optional = true }
-monero-address = { git = "https://github.com/monero-oxide/monero-oxide", rev = "6966575e05fe09b77674c46984b21686ed9304ff", version = "0.1.0", default-features = false, features = ["std"], optional = true }
+monero-address = { git = "https://github.com/monero-oxide/monero-oxide", rev = "7f37cc8f770858aa1739e0f56dbe447db86f4ba6", version = "0.1.0", default-features = false, features = ["std"], optional = true }
 
 [dev-dependencies]
 rand_core = "0.6"
@@ -70,7 +70,7 @@ borsh = ["serai-abi/borsh"]
 networks = []
 bitcoin = ["networks", "dep:bitcoin"]
 ethereum = ["networks"]
-monero = ["networks", "dalek-ff-group", "ciphersuite", "monero-address"]
+monero = ["networks", "ciphersuite", "dalek-ff-group", "monero-address"]
 
 # Assumes the default usage is to use Serai as a DEX, which doesn't actually
 # require connecting to a Serai node

substrate/client/src/networks/monero.rs

@@ -1,7 +1,7 @@
 use core::{str::FromStr, fmt};
 
-use dalek_ff_group::Ed25519;
-use ciphersuite::Ciphersuite;
+use dalek_ff_group::{EdwardsPoint, Ed25519};
+use ciphersuite::GroupIo;
 
 use monero_address::{Network, AddressType as MoneroAddressType, MoneroAddress};
 
@@ -18,8 +18,8 @@ enum AddressType {
 #[derive(Clone, Copy, PartialEq, Eq, Debug)]
 pub struct Address {
   kind: AddressType,
-  spend: <Ed25519 as Ciphersuite>::G,
-  view: <Ed25519 as Ciphersuite>::G,
+  spend: EdwardsPoint,
+  view: EdwardsPoint,
 }
 
 fn byte_for_kind(kind: AddressType) -> u8 {

substrate/client/tests/common/genesis_liquidity.rs

@@ -3,8 +3,8 @@ use std::collections::HashMap;
 use rand_core::{RngCore, OsRng};
 use zeroize::Zeroizing;
 
-use dalek_ff_group::Ristretto;
-use ciphersuite::Ciphersuite;
+use frost::curve::Ristretto;
+use ciphersuite::{WrappedGroup, GroupIo};
 use dkg_musig::musig;
 use schnorrkel::Schnorrkel;
 
@@ -96,11 +96,10 @@ async fn set_values(serai: &Serai, values: &Values) {
   // we publish the tx in set 1
   let set = ValidatorSet { session: Session(1), network: NetworkId::Serai };
 
-  let public_key = <Ristretto as Ciphersuite>::read_G::<&[u8]>(&mut public.0.as_ref()).unwrap();
-  let secret_key = <Ristretto as Ciphersuite>::read_F::<&[u8]>(
-    &mut pair.as_ref().secret.to_bytes()[.. 32].as_ref(),
-  )
-  .unwrap();
+  let public_key = <Ristretto as GroupIo>::read_G::<&[u8]>(&mut public.0.as_ref()).unwrap();
+  let secret_key =
+    <Ristretto as GroupIo>::read_F::<&[u8]>(&mut pair.as_ref().secret.to_bytes()[.. 32].as_ref())
+      .unwrap();
 
   assert_eq!(Ristretto::generator() * secret_key, public_key);
   let threshold_keys =

substrate/client/tests/common/validator_sets.rs

@@ -1,9 +1,13 @@
 use std::collections::HashMap;
 
-use serai_abi::primitives::NetworkId;
 use zeroize::Zeroizing;
 use rand_core::OsRng;
 
+use frost::curve::Ristretto;
+use ciphersuite::{WrappedGroup, GroupIo};
+use dkg_musig::musig;
+use schnorrkel::Schnorrkel;
+
 use sp_core::{
   ConstU32,
   bounded_vec::BoundedVec,
@@ -11,10 +15,7 @@ use sp_core::{
   Pair as PairTrait,
 };
 
-use dalek_ff_group::Ristretto;
-use ciphersuite::Ciphersuite;
-use dkg_musig::musig;
-use schnorrkel::Schnorrkel;
+use serai_abi::primitives::NetworkId;
 
 use serai_client::{
   primitives::{EmbeddedEllipticCurve, Amount},
@@ -37,13 +38,13 @@ pub async fn set_keys(
   let mut pub_keys = vec![];
   for pair in pairs {
     let public_key =
-      <Ristretto as Ciphersuite>::read_G::<&[u8]>(&mut pair.public().0.as_ref()).unwrap();
+      <Ristretto as GroupIo>::read_G::<&[u8]>(&mut pair.public().0.as_ref()).unwrap();
     pub_keys.push(public_key);
   }
 
   let mut threshold_keys = vec![];
   for i in 0 .. pairs.len() {
-    let secret_key = <Ristretto as Ciphersuite>::read_F::<&[u8]>(
+    let secret_key = <Ristretto as GroupIo>::read_F::<&[u8]>(
       &mut pairs[i].as_ref().secret.to_bytes()[.. 32].as_ref(),
     )
     .unwrap();