Smash the singular Ciphersuite trait into multiple

This helps identify where the various functionalities are used, or rather, not
used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating
the entire FCMP++ tree, only requires the markers _and_ canonical point
decoding. I've opened a PR to upstream such a trait into `group`
(https://github.com/zkcrypto/group/pull/68).

`WrappedGroup` is still justified for as long as `Group::generator` exists.
Moving `::generator()` to its own trait, on an independent structure (upstream)
would be massively appreciated. @tarcieri also wanted to update from
`fn generator()` to `const GENERATOR`, which would encourage further discussion
on https://github.com/zkcrypto/group/issues/32 and
https://github.com/zkcrypto/group/issues/45, which have been stagnant.

The `Id` trait is occasionally used yet really should be first off the chopping
block.

Finally, `WithPreferredHash` is only actually used around a third of the time,
which more than justifies it being a separate trait.

---

Updates `dalek_ff_group::Scalar` to directly re-export
`curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint`
also could be replaced with an export of `curve25519_dalek::RistrettoPoint`,
yet the coordinator relies on how we implemented `Hash` on it for the hell of
it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be
replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't
implement `zeroize`, `subtle` traits within a released, non-yanked version.
Relevance to https://github.com/serai-dex/serai/issues/201 and
https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746.

Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over
`SHA2-512`. In order to maintain compliance with FROST's IETF standard,
`modular-frost` defines its own ciphersuite for Ristretto which still uses
`SHA2-512`.

processor/monero/Cargo.toml

@@ -29,8 +29,8 @@ dalek-ff-group = { path = "../../crypto/dalek-ff-group", default-features = fals
 dkg = { package = "dkg-evrf", path = "../../crypto/dkg/evrf", default-features = false, features = ["std", "ed25519"] }
 frost = { package = "modular-frost", path = "../../crypto/frost", default-features = false }
 
-monero-wallet = { git = "https://github.com/monero-oxide/monero-oxide", rev = "6966575e05fe09b77674c46984b21686ed9304ff", default-features = false, features = ["std", "multisig"] }
-monero-simple-request-rpc = { git = "https://github.com/monero-oxide/monero-oxide", rev = "6966575e05fe09b77674c46984b21686ed9304ff", default-features = false }
+monero-wallet = { git = "https://github.com/monero-oxide/monero-oxide", rev = "7f37cc8f770858aa1739e0f56dbe447db86f4ba6", default-features = false, features = ["std", "multisig"] }
+monero-simple-request-rpc = { git = "https://github.com/monero-oxide/monero-oxide", rev = "7f37cc8f770858aa1739e0f56dbe447db86f4ba6", default-features = false }
 
 serai-client = { path = "../../substrate/client", default-features = false, features = ["monero"] }
 

processor/monero/src/primitives/block.rs

@@ -1,6 +1,6 @@
 use std::collections::HashMap;
 
-use ciphersuite::Ciphersuite;
+use ciphersuite::*;
 use dalek_ff_group::Ed25519;
 
 use monero_wallet::{
@@ -32,7 +32,7 @@ pub(crate) struct Block(pub(crate) MScannableBlock);
 impl primitives::Block for Block {
   type Header = BlockHeader;
 
-  type Key = <Ed25519 as Ciphersuite>::G;
+  type Key = <Ed25519 as WrappedGroup>::G;
   type Address = Address;
   type Output = Output;
   type Eventuality = Eventuality;

processor/monero/src/primitives/mod.rs

@@ -1,6 +1,6 @@
 use zeroize::Zeroizing;
 
-use ciphersuite::Ciphersuite;
+use ciphersuite::*;
 use dalek_ff_group::Ed25519;
 
 use monero_wallet::{address::SubaddressIndex, ViewPairError, GuaranteedViewPair};
@@ -28,8 +28,8 @@ pub(crate) const FORWARDED_SUBADDRESS: SubaddressIndex = match SubaddressIndex::
   None => panic!("SubaddressIndex for FORWARDED_SUBADDRESS was None"),
 };
 
-pub(crate) fn view_pair(key: <Ed25519 as Ciphersuite>::G) -> GuaranteedViewPair {
-  match GuaranteedViewPair::new(key.0, Zeroizing::new(*view_key::<Ed25519>(0))) {
+pub(crate) fn view_pair(key: <Ed25519 as WrappedGroup>::G) -> GuaranteedViewPair {
+  match GuaranteedViewPair::new(key.0, Zeroizing::new(view_key::<Ed25519>(0))) {
     Ok(view_pair) => view_pair,
     Err(ViewPairError::TorsionedSpendKey) => {
       unreachable!("dalek_ff_group::EdwardsPoint had torsion")

processor/monero/src/primitives/output.rs

@@ -1,6 +1,6 @@
 use std::io;
 
-use ciphersuite::{group::Group, Ciphersuite};
+use ciphersuite::WrappedGroup;
 use dalek_ff_group::Ed25519;
 
 use monero_wallet::WalletOutput;
@@ -35,7 +35,7 @@ impl AsMut<[u8]> for OutputId {
 
 #[derive(Clone, PartialEq, Eq, Debug)]
 pub(crate) struct Output(pub(crate) WalletOutput);
-impl ReceivedOutput<<Ed25519 as Ciphersuite>::G, Address> for Output {
+impl ReceivedOutput<<Ed25519 as WrappedGroup>::G, Address> for Output {
   type Id = OutputId;
   type TransactionId = [u8; 32];
 
@@ -64,12 +64,12 @@ impl ReceivedOutput<<Ed25519 as Ciphersuite>::G, Address> for Output {
     self.0.transaction()
   }
 
-  fn key(&self) -> <Ed25519 as Ciphersuite>::G {
+  fn key(&self) -> <Ed25519 as WrappedGroup>::G {
     // The spend key will be a key we generated, so it'll be in the prime-order subgroup
     // The output's key is the spend key + (key_offset * G), so it's in the prime-order subgroup if
     // the spend key is
     dalek_ff_group::EdwardsPoint(
-      self.0.key() - (*<Ed25519 as Ciphersuite>::G::generator() * self.0.key_offset()),
+      self.0.key() - (*<Ed25519 as WrappedGroup>::generator() * self.0.key_offset()),
     )
   }
 

processor/monero/src/scheduler.rs

@@ -4,7 +4,7 @@ use zeroize::Zeroizing;
 use rand_core::SeedableRng;
 use rand_chacha::ChaCha20Rng;
 
-use ciphersuite::Ciphersuite;
+use ciphersuite::*;
 use dalek_ff_group::Ed25519;
 
 use monero_wallet::rpc::{FeeRate, RpcError};
@@ -33,7 +33,7 @@ use crate::{
   rpc::Rpc,
 };
 
-fn address_from_serai_key(key: <Ed25519 as Ciphersuite>::G, kind: OutputType) -> Address {
+fn address_from_serai_key(key: <Ed25519 as WrappedGroup>::G, kind: OutputType) -> Address {
   view_pair(key)
     .address(
       Network::Mainnet,
@@ -118,8 +118,8 @@ async fn signable_transaction(
       MoneroAddress::new(
         Network::Mainnet,
         AddressType::Legacy,
-        <Ed25519 as Ciphersuite>::generator().0,
-        <Ed25519 as Ciphersuite>::generator().0,
+        <Ed25519 as WrappedGroup>::generator().0,
+        <Ed25519 as WrappedGroup>::generator().0,
       ),
       0,
     ));