Smash the singular Ciphersuite trait into multiple

This helps identify where the various functionalities are used, or rather, not
used. The `Ciphersuite` trait present in `patches/ciphersuite`, facilitating
the entire FCMP++ tree, only requires the markers _and_ canonical point
decoding. I've opened a PR to upstream such a trait into `group`
(https://github.com/zkcrypto/group/pull/68).

`WrappedGroup` is still justified for as long as `Group::generator` exists.
Moving `::generator()` to its own trait, on an independent structure (upstream)
would be massively appreciated. @tarcieri also wanted to update from
`fn generator()` to `const GENERATOR`, which would encourage further discussion
on https://github.com/zkcrypto/group/issues/32 and
https://github.com/zkcrypto/group/issues/45, which have been stagnant.

The `Id` trait is occasionally used yet really should be first off the chopping
block.

Finally, `WithPreferredHash` is only actually used around a third of the time,
which more than justifies it being a separate trait.

---

Updates `dalek_ff_group::Scalar` to directly re-export
`curve25519_dalek::Scalar`, as without issue. `dalek_ff_group::RistrettoPoint`
also could be replaced with an export of `curve25519_dalek::RistrettoPoint`,
yet the coordinator relies on how we implemented `Hash` on it for the hell of
it so it isn't worth it at this time. `dalek_ff_group::EdwardsPoint` can't be
replaced for an re-export of `curve25519_dalek::SubgroupPoint` as it doesn't
implement `zeroize`, `subtle` traits within a released, non-yanked version.
Relevance to https://github.com/serai-dex/serai/issues/201 and
https://github.com/dalek-cryptography/curve25519-dalek/issues/811#issuecomment-3247732746.

Also updates the `Ristretto` ciphersuite to prefer `Blake2b-512` over
`SHA2-512`. In order to maintain compliance with FROST's IETF standard,
`modular-frost` defines its own ciphersuite for Ristretto which still uses
`SHA2-512`.

networks/bitcoin/Cargo.toml

@@ -27,7 +27,7 @@ rand_core = { version = "0.6", default-features = false }
 bitcoin = { version = "0.32", default-features = false }
 
 k256 = { version = "^0.13.1", default-features = false, features = ["arithmetic", "bits"] }
-frost = { package = "modular-frost", path = "../../crypto/frost", version = "0.10", default-features = false, features = ["secp256k1"], optional = true }
+frost = { package = "modular-frost", path = "../../crypto/frost", version = "0.11", default-features = false, features = ["secp256k1"], optional = true }
 
 hex = { version = "0.4", default-features = false, optional = true }
 serde = { version = "1", default-features = false, features = ["derive"], optional = true }

networks/bitcoin/src/crypto.rs

@@ -40,7 +40,7 @@ mod frost_crypto {
   use k256::{elliptic_curve::ops::Reduce, U256, Scalar};
 
   use frost::{
-    curve::{Ciphersuite, Secp256k1},
+    curve::{WrappedGroup, Secp256k1},
     Participant, ThresholdKeys, ThresholdView, FrostError,
     algorithm::{Hram as HramTrait, Algorithm, IetfSchnorr as FrostSchnorr},
   };
@@ -128,10 +128,10 @@ mod frost_crypto {
     fn sign_share(
       &mut self,
       params: &ThresholdView<Secp256k1>,
-      nonce_sums: &[Vec<<Secp256k1 as Ciphersuite>::G>],
-      nonces: Vec<Zeroizing<<Secp256k1 as Ciphersuite>::F>>,
+      nonce_sums: &[Vec<<Secp256k1 as WrappedGroup>::G>],
+      nonces: Vec<Zeroizing<<Secp256k1 as WrappedGroup>::F>>,
       msg: &[u8],
-    ) -> <Secp256k1 as Ciphersuite>::F {
+    ) -> <Secp256k1 as WrappedGroup>::F {
       self.0.sign_share(params, nonce_sums, nonces, msg)
     }
 

networks/bitcoin/src/wallet/mod.rs

@@ -13,7 +13,7 @@ use k256::{
 
 #[cfg(feature = "std")]
 use frost::{
-  curve::{Ciphersuite, Secp256k1},
+  curve::{WrappedGroup, GroupIo, Secp256k1},
   ThresholdKeys,
 };
 
@@ -59,7 +59,7 @@ pub fn tweak_keys(keys: ThresholdKeys<Secp256k1>) -> ThresholdKeys<Secp256k1> {
       would be unusable due to a check the script path hash is less than the order. That doesn't
       impact us as we don't want the script path to be usable.
     */
-    keys.offset(<Secp256k1 as Ciphersuite>::F::reduce(U256::from_be_bytes(
+    keys.offset(<Secp256k1 as WrappedGroup>::F::reduce(U256::from_be_bytes(
       *tweak_hash.to_raw_hash().as_ref(),
     )))
   };