mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 12:19:24 +00:00
Replace ExternalBlock with Batch
The initial TODO was simply to use one ExternalBlock per all batches in the block. This would require publishing ExternalBlock after the last batch, requiring knowing the last batch. While we could add such a pipeline, it'd require: 1) Initial preprocesses using a distinct message from BatchPreprocess 2) An additional message sent after all BatchPreprocess are sent Unfortunately, both would require tweaks to the SubstrateSigner which aren't worth the complexity compared to the solution here, at least, not at this time. While this will cause, if a Tributary is signing a block whose total batch data exceeds 25 kB, to use multiple transactions which could be optimized out by 'better' local data pipelining, that's an extreme edge case. Given the temporal nature of each Tributary, it's also an acceptable edge. This does no longer achieve synchrony over external blocks accordingly. While signed batches have synchrony, as they embed their block hash, batches being signed don't have cryptographic synchrony on their contents. This means validators who are eclipsed may produce invalid shares, as they sign a different batch. This will be introduced in a follow-up commit.
This commit is contained in:
@@ -1,8 +1,5 @@
|
||||
use scale::{Encode, Decode};
|
||||
use serai_client::{
|
||||
primitives::{NetworkId, BlockHash},
|
||||
in_instructions::primitives::SignedBatch,
|
||||
};
|
||||
use serai_client::{primitives::NetworkId, in_instructions::primitives::SignedBatch};
|
||||
|
||||
pub use serai_db::*;
|
||||
|
||||
@@ -48,42 +45,6 @@ impl<'a, D: Db> MainDb<'a, D> {
|
||||
txn.commit();
|
||||
}
|
||||
|
||||
fn batches_in_block_key(network: NetworkId, block: [u8; 32]) -> Vec<u8> {
|
||||
Self::main_key(b"batches_in_block", (network, block).encode())
|
||||
}
|
||||
pub fn batches_in_block<G: Get>(
|
||||
getter: &G,
|
||||
network: NetworkId,
|
||||
block: [u8; 32],
|
||||
) -> Vec<[u8; 32]> {
|
||||
getter
|
||||
.get(Self::batches_in_block_key(network, block))
|
||||
.expect("asking for batches in block for block without batches")
|
||||
.chunks(32)
|
||||
.map(|id| id.try_into().unwrap())
|
||||
.collect()
|
||||
}
|
||||
pub fn add_batch_to_block(
|
||||
txn: &mut D::Transaction<'_>,
|
||||
network: NetworkId,
|
||||
block: BlockHash,
|
||||
id: [u8; 32],
|
||||
) {
|
||||
let key = Self::batches_in_block_key(network, block.0);
|
||||
let Some(mut existing) = txn.get(&key) else {
|
||||
txn.put(&key, id);
|
||||
return;
|
||||
};
|
||||
|
||||
if existing.chunks(32).any(|existing_id| existing_id == id) {
|
||||
// TODO: Is this an invariant?
|
||||
return;
|
||||
}
|
||||
|
||||
existing.extend(id);
|
||||
txn.put(&key, existing);
|
||||
}
|
||||
|
||||
fn first_preprocess_key(id: [u8; 32]) -> Vec<u8> {
|
||||
Self::main_key(b"first_preprocess", id)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user