absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 12:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct the fee amortization algorithm for an edge case

Browse Source 
This is technically over-agressive, as a dropped output will reduce the fee,
yet this edge case is so minor the flow for it to not be over-aggressive (over
a few fractions of a cent) is by no means worth it.

Fixes the crash causable by the WIP send_test.
This commit is contained in:
Luke Parker
2023-07-29 06:55:55 -04:00
parent f78332453b
commit 8b14bb54bb
3 changed files with 53 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
coins/monero/src/wallet/send/mod.rs
View File

@@ -140,8 +140,11 @@ pub enum TransactionError {
TooMuchData,
#[cfg_attr(feature = "std", error("too many inputs/too much arbitrary data"))]
TooLargeTransaction,
#[cfg_attr(feature = "std", error("not enough funds (in {0}, out {1})"))]
NotEnoughFunds(u64, u64),
#[cfg_attr(
feature = "std",
error("not enough funds (inputs {inputs}, outputs {outputs}, fee {fee})")
)]
NotEnoughFunds { inputs: u64, outputs: u64, fee: u64 },
#[cfg_attr(feature = "std", error("wrong spend private key"))]
WrongPrivateKey,
#[cfg_attr(feature = "std", error("rpc error ({0})"))]
@@ -509,7 +512,7 @@ impl SignableTransaction {
// Make sure we have enough funds
let in_amount = inputs.iter().map(|(input, _)| input.commitment().amount).sum::<u64>();
if in_amount < (out_amount + fee) {
Err(TransactionError::NotEnoughFunds(in_amount, out_amount + fee))?;
Err(TransactionError::NotEnoughFunds { inputs: in_amount, outputs: out_amount, fee })?;
}
// Sanity check we have the expected number of change outputs