absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 12:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Erc20::approve for DestinationType::Contract

Browse Source 
This allows the CREATE code to bork without the Serai router losing access to
the coins in question. It does incur overhead on the deployed contract, which
now no longer just has to query its balance but also has to call the
transferFrom, but its a safer pattern and not a UX detriment.

This also improves documentation.
This commit is contained in:
Luke Parker
2025-01-27 11:37:17 -05:00
parent f8c3acae7b
commit 7e01589fba
4 changed files with 115 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
processor/ethereum/router/src/tests/mod.rs
View File

@@ -914,10 +914,10 @@ async fn test_erc20_code_out_instruction() {
let unused_gas = test.gas_unused_by_calls(&tx).await;
assert_eq!(gas_used + unused_gas, gas);
assert_eq!(erc20.balance_of(&test, test.router.address()).await, U256::from(0));
assert_eq!(erc20.balance_of(&test, test.router.address()).await, U256::from(amount_out));
assert_eq!(erc20.balance_of(&test, tx.recover_signer().unwrap()).await, U256::from(fee));
let deployed = test.router.address().create(1);
assert_eq!(erc20.balance_of(&test, deployed).await, amount_out);
assert_eq!(erc20.router_approval(&test, deployed).await, amount_out);
assert_eq!(test.provider.get_code_at(deployed).await.unwrap().to_vec(), true.abi_encode());
}