From 7a75020dc881763f7b7edd09db0b07dda1af879f Mon Sep 17 00:00:00 2001 From: Luke Parker Date: Mon, 3 Jul 2023 18:37:17 -0400 Subject: [PATCH] Remove verify_rct_* from Mlsag Both methods were ports from Monero, overtly specific without clear documentation. They need to be added back in, with documentation, or included in a node which provides the necessary further context for them to be naturally understandable. --- coins/monero/src/ringct/mlsag/mod.rs | 33 ---------------------------- 1 file changed, 33 deletions(-) diff --git a/coins/monero/src/ringct/mlsag/mod.rs b/coins/monero/src/ringct/mlsag/mod.rs index d41fcfc0..6999251f 100644 --- a/coins/monero/src/ringct/mlsag/mod.rs +++ b/coins/monero/src/ringct/mlsag/mod.rs @@ -32,39 +32,6 @@ impl Mlsag { }) } - pub fn verify_rct_full( - &self, - msg: &[u8; 32], - pubs: &[[EdwardsPoint; 2]], - out_pks: &[EdwardsPoint], - fee: &EdwardsPoint, - key_image: &EdwardsPoint, - ) -> bool { - let sum_out_pk = out_pks.iter().sum::(); - - let mut ring_matrix = Vec::with_capacity(pubs.len()); - for member in pubs.iter() { - ring_matrix.push([member[0], member[1] - sum_out_pk - fee]) - } - - self.verify(msg, &ring_matrix, key_image) - } - - pub fn verify_rct_simple( - &self, - msg: &[u8; 32], - pubs: &[[EdwardsPoint; 2]], - pseudo_out: &EdwardsPoint, - key_image: &EdwardsPoint, - ) -> bool { - let mut ring_matrix = Vec::with_capacity(pubs.len()); - for member in pubs.iter() { - ring_matrix.push([member[0], member[1] - pseudo_out]) - } - - self.verify(msg, &ring_matrix, key_image) - } - #[cfg(feature = "experimental")] pub fn verify( &self,