Replace usage of io::Error::new(io::ErrorKind::Other, with io::Error::other

Newly possible with Rust 1.74.

coordinator/tributary/src/lib.rs

@@ -81,7 +81,7 @@ impl<T: TransactionTrait> ReadWrite for Transaction<T> {
         let tx = T::read(reader)?;
         Ok(Transaction::Application(tx))
       }
-      _ => Err(io::Error::new(io::ErrorKind::Other, "invalid transaction type")),
+      _ => Err(io::Error::other("invalid transaction type")),
     }
   }
   fn write<W: io::Write>(&self, writer: &mut W) -> io::Result<()> {

coordinator/tributary/src/tests/blockchain.rs

@@ -412,7 +412,7 @@ async fn block_tx_ordering() {
       match kind[0] {
         0 => Ok(SignedTx::Signed(Box::new(SignedTransaction::read(reader)?))),
         1 => Ok(SignedTx::Provided(Box::new(ProvidedTransaction::read(reader)?))),
-        _ => Err(io::Error::new(io::ErrorKind::Other, "invalid transaction type")),
+        _ => Err(io::Error::other("invalid transaction type")),
       }
     }
 

coordinator/tributary/src/transaction.rs

@@ -55,7 +55,7 @@ impl ReadWrite for Signed {
     reader.read_exact(&mut nonce)?;
     let nonce = u32::from_le_bytes(nonce);
     if nonce >= (u32::MAX - 1) {
-      Err(io::Error::new(io::ErrorKind::Other, "nonce exceeded limit"))?;
+      Err(io::Error::other("nonce exceeded limit"))?;
     }
 
     let mut signature = SchnorrSignature::<Ristretto>::read(reader)?;
@@ -64,7 +64,7 @@ impl ReadWrite for Signed {
       // We should never produce zero signatures though meaning this should never come up
       // If it does somehow come up, this is a decent courtesy
       signature.zeroize();
-      Err(io::Error::new(io::ErrorKind::Other, "signature nonce was identity"))?;
+      Err(io::Error::other("signature nonce was identity"))?;
     }
 
     Ok(Signed { signer, nonce, signature })
@@ -73,7 +73,7 @@ impl ReadWrite for Signed {
   fn write<W: io::Write>(&self, writer: &mut W) -> io::Result<()> {
     // This is either an invalid signature or a private key leak
     if self.signature.R.is_identity().into() {
-      Err(io::Error::new(io::ErrorKind::Other, "signature nonce was identity"))?;
+      Err(io::Error::other("signature nonce was identity"))?;
     }
     writer.write_all(&self.signer.to_bytes())?;
     writer.write_all(&self.nonce.to_le_bytes())?;