Remove subxt (#460)

* Remove subxt

Removes ~20 crates from our Cargo.lock.

Removes downloading the metadata and enables removing the getMetadata RPC route
(relevant to #379).

Moves forward #337.

Done now due to distinctions in the subxt 0.32 API surface which make it
justifiable to not update.

* fmt, update due to deny triggering on a yanked crate

* Correct the handling of substrate_block_notifier now that it's ephemeral, not long-lived

* Correct URL in tests/coordinator from ws to http

substrate/client/tests/common/dex.rs

@@ -20,7 +20,7 @@ pub async fn add_liquidity(
     &pair,
     &SeraiDex::add_liquidity(coin, coin_amount, sri_amount, Amount(1), Amount(1), address.into()),
     nonce,
-    Default::default(),
+    0,
   );
 
   publish_tx(serai, &tx).await

substrate/client/tests/common/in_instructions.rs

@@ -26,7 +26,7 @@ pub async fn provide_batch(serai: &Serai, batch: Batch) -> [u8; 32] {
   let set = ValidatorSet { session: Session(0), network: batch.network };
   let pair = insecure_pair_from_name(&format!("ValidatorSet {:?}", set));
   let keys = if let Some(keys) =
-    serai.with_current_latest_block().await.unwrap().validator_sets().keys(set).await.unwrap()
+    serai.as_of_latest_finalized_block().await.unwrap().validator_sets().keys(set).await.unwrap()
   {
     keys
   } else {

substrate/client/tests/common/mod.rs

@@ -42,18 +42,18 @@ macro_rules! serai_test {
         test.run_async(|ops| async move {
           // Sleep until the Substrate RPC starts
           let serai_rpc = ops.handle(handle).host_port(9944).unwrap();
-          let serai_rpc = format!("ws://{}:{}", serai_rpc.0, serai_rpc.1);
+          let serai_rpc = format!("http://{}:{}", serai_rpc.0, serai_rpc.1);
           // Bound execution to 60 seconds
           for _ in 0 .. 60 {
             tokio::time::sleep(core::time::Duration::from_secs(1)).await;
-            let Ok(client) = Serai::new(&serai_rpc).await else { continue };
-            if client.latest_block_hash().await.is_err() {
+            let Ok(client) = Serai::new(serai_rpc.clone()).await else { continue };
+            if client.latest_finalized_block_hash().await.is_err() {
               continue;
             }
             break;
           }
           #[allow(clippy::redundant_closure_call)]
-          $test(Serai::new(&serai_rpc).await.unwrap()).await;
+          $test(Serai::new(serai_rpc).await.unwrap()).await;
         }).await;
       }
     )*

substrate/client/tests/common/tx.rs

@@ -2,12 +2,18 @@ use core::time::Duration;
 
 use tokio::time::sleep;
 
+use scale::Encode;
+
 use serai_client::Serai;
 
 #[allow(dead_code)]
 pub async fn publish_tx(serai: &Serai, tx: &[u8]) -> [u8; 32] {
-  let mut latest =
-    serai.block(serai.latest_block_hash().await.unwrap()).await.unwrap().unwrap().number();
+  let mut latest = serai
+    .block(serai.latest_finalized_block_hash().await.unwrap())
+    .await
+    .unwrap()
+    .unwrap()
+    .number();
 
   serai.publish(tx).await.unwrap();
 
@@ -20,7 +26,7 @@ pub async fn publish_tx(serai: &Serai, tx: &[u8]) -> [u8; 32] {
     let block = {
       let mut block;
       while {
-        block = serai.block_by_number(latest).await.unwrap();
+        block = serai.finalized_block_by_number(latest).await.unwrap();
         block.is_none()
       } {
         sleep(Duration::from_secs(1)).await;
@@ -34,7 +40,7 @@ pub async fn publish_tx(serai: &Serai, tx: &[u8]) -> [u8; 32] {
     };
 
     for transaction in block.transactions() {
-      if transaction.0 == tx {
+      if transaction.encode() == tx {
         return block.hash();
       }
     }

substrate/client/tests/common/validator_sets.rs

@@ -28,7 +28,7 @@ pub async fn set_keys(serai: &Serai, set: ValidatorSet, key_pair: KeyPair) -> [u
   let public_key = <Ristretto as Ciphersuite>::read_G::<&[u8]>(&mut public.0.as_ref()).unwrap();
   assert_eq!(
     serai
-      .with_current_latest_block()
+      .as_of_latest_finalized_block()
       .await
       .unwrap()
       .validator_sets()
@@ -48,7 +48,7 @@ pub async fn set_keys(serai: &Serai, set: ValidatorSet, key_pair: KeyPair) -> [u
     musig::<Ristretto>(&musig_context(set), &Zeroizing::new(secret_key), &[public_key]).unwrap();
   assert_eq!(
     serai
-      .with_current_latest_block()
+      .as_of_latest_finalized_block()
       .await
       .unwrap()
       .validator_sets()
@@ -69,7 +69,7 @@ pub async fn set_keys(serai: &Serai, set: ValidatorSet, key_pair: KeyPair) -> [u
     &set_keys_message(&set, &key_pair),
   );
 
-  // Vote in a key pair
+  // Set the key pair
   let block = publish_tx(
     serai,
     &SeraiValidatorSets::set_keys(set.network, key_pair.clone(), Signature(sig.to_bytes())),