From 63133ae53032bfebd735a0f848ab4b06baa1571a Mon Sep 17 00:00:00 2001 From: Luke Parker Date: Mon, 8 Dec 2025 23:22:55 -0500 Subject: [PATCH] Call the shells via a `sh` symlink to trigger their POSIX-compliant behavior (if special-cased based on how the shell was invoked) --- .github/actions/build-dependencies/action.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/stack_size.yml | 14 +++++++++----- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/actions/build-dependencies/action.yml b/.github/actions/build-dependencies/action.yml index 695b7e4e..679167d5 100644 --- a/.github/actions/build-dependencies/action.yml +++ b/.github/actions/build-dependencies/action.yml @@ -62,7 +62,7 @@ runs: docker system prune -a --volumes sudo apt remove -y *docker* # Install uidmap which will be required for the explicitly installed Docker - sudo apt install uidmap + sudo apt install -y uidmap if: runner.os == 'Linux' - name: Update system dependencies diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 12ae78d6..6a4fdc33 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -208,7 +208,7 @@ jobs: - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # 6.0.0 - name: shellcheck run: | - sudo apt install shellcheck + sudo apt install -y shellcheck find . -iname "*.sh" | while read -r script; do shellcheck --enable=all --shell=sh --severity=info $script done diff --git a/.github/workflows/stack_size.yml b/.github/workflows/stack_size.yml index e7279ad0..47e6850c 100644 --- a/.github/workflows/stack_size.yml +++ b/.github/workflows/stack_size.yml @@ -37,12 +37,16 @@ jobs: GOBIN=$(pwd) go install github.com/yaegashi/muslstack@d19cc5866abce3ca59dfc1666df7cc97097d0933 ./muslstack -s $STACK ./monerod-muslstack - sudo apt install bash dash zsh busybox - ln -s $(which busybox) /usr/bin/ash - ln -s $(which busybox) /usr/bin/hush - for shell in sh bash dash zsh ash hush; do + sudo apt update -y + sudo apt upgrade -y + sudo apt install -y ksh bash tcsh dash zsh busybox + sudo ln -s $(which busybox) /usr/bin/ash + sudo ln -s $(which busybox) /usr/bin/hush + for shell in sh ksh bash tcsh dash zsh ash hush; do cp monerod monerod-idss-$shell - $shell ./orchestration/increase_default_stack_size.sh monerod-idss-$shell + ln -s $(which $shell) sh + ./sh ./orchestration/increase_default_stack_size.sh monerod-idss-$shell + rm ./sh done find . -iname "monerod-*" | while read -r bin; do