Remove monero-rs types

Still missing an updated RPC file. Restructures the library as it makes 
sense

coins/monero/src/wallet/send/mod.rs

@@ -0,0 +1,319 @@
+use thiserror::Error;
+
+use rand_core::{RngCore, CryptoRng};
+use rand::seq::SliceRandom;
+
+use curve25519_dalek::{
+  constants::ED25519_BASEPOINT_TABLE,
+  scalar::Scalar,
+  edwards::EdwardsPoint
+};
+
+use monero::{
+  consensus::Encodable,
+  util::{key::PublicKey, address::Address},
+  blockdata::transaction::SubField
+};
+
+#[cfg(feature = "multisig")]
+use frost::FrostError;
+
+use crate::{
+  Commitment,
+  random_scalar,
+  generate_key_image, bulletproofs::Bulletproofs, clsag::{ClsagError, ClsagInput, Clsag},
+  rpc::{Rpc, RpcError},
+  transaction::*,
+  wallet::{uniqueness, shared_key, commitment_mask, amount_encryption, SpendableOutput, Decoys}
+};
+#[cfg(feature = "multisig")]
+use crate::frost::MultisigError;
+
+#[cfg(feature = "multisig")]
+mod multisig;
+
+#[allow(non_snake_case)]
+#[derive(Clone, Debug)]
+struct SendOutput {
+  R: EdwardsPoint,
+  dest: EdwardsPoint,
+  mask: Scalar,
+  amount: [u8; 8]
+}
+
+impl SendOutput {
+  fn new<R: RngCore + CryptoRng>(
+    rng: &mut R,
+    unique: Option<[u8; 32]>,
+    output: (Address, u64),
+    o: usize
+  ) -> Result<SendOutput, TransactionError> {
+    let r = random_scalar(rng);
+    let shared_key = shared_key(
+      unique,
+      r,
+      &output.0.public_view.point.decompress().ok_or(TransactionError::InvalidAddress)?,
+      o
+    );
+
+    Ok(
+      SendOutput {
+        R: &r * &ED25519_BASEPOINT_TABLE,
+        dest: (
+          (&shared_key * &ED25519_BASEPOINT_TABLE) +
+          output.0.public_spend.point.decompress().ok_or(TransactionError::InvalidAddress)?
+        ),
+        mask: commitment_mask(shared_key),
+        amount: amount_encryption(output.1, shared_key)
+      }
+    )
+  }
+}
+
+
+#[derive(Error, Debug)]
+pub enum TransactionError {
+  #[error("no inputs")]
+  NoInputs,
+  #[error("no outputs")]
+  NoOutputs,
+  #[error("too many outputs")]
+  TooManyOutputs,
+  #[error("not enough funds (in {0}, out {1})")]
+  NotEnoughFunds(u64, u64),
+  #[error("invalid address")]
+  InvalidAddress,
+  #[error("rpc error ({0})")]
+  RpcError(RpcError),
+  #[error("clsag error ({0})")]
+  ClsagError(ClsagError),
+  #[error("invalid transaction ({0})")]
+  InvalidTransaction(RpcError),
+  #[cfg(feature = "multisig")]
+  #[error("frost error {0}")]
+  FrostError(FrostError),
+  #[cfg(feature = "multisig")]
+  #[error("multisig error {0}")]
+  MultisigError(MultisigError)
+}
+
+async fn prepare_inputs<R: RngCore + CryptoRng>(
+  rng: &mut R,
+  rpc: &Rpc,
+  inputs: &[SpendableOutput],
+  spend: &Scalar,
+  tx: &mut Transaction
+) -> Result<Vec<(Scalar, EdwardsPoint, ClsagInput)>, TransactionError> {
+  let mut signable = Vec::with_capacity(inputs.len());
+
+  // Select decoys
+  let decoys = Decoys::select(
+    rng,
+    rpc,
+    rpc.get_height().await.map_err(|e| TransactionError::RpcError(e))? - 10,
+    inputs
+  ).await.map_err(|e| TransactionError::RpcError(e))?;
+
+  for (i, input) in inputs.iter().enumerate() {
+    signable.push((
+      spend + input.key_offset,
+      generate_key_image(&(spend + input.key_offset)),
+      ClsagInput::new(
+        input.commitment,
+        decoys[i].clone()
+      ).map_err(|e| TransactionError::ClsagError(e))?
+    ));
+
+    tx.prefix.inputs.push(Input::ToKey {
+      amount: 0,
+      key_offsets: decoys[i].offsets.clone(),
+      key_image: signable[i].1
+    });
+  }
+
+  signable.sort_by(|x, y| x.1.compress().to_bytes().cmp(&y.1.compress().to_bytes()).reverse());
+  tx.prefix.inputs.sort_by(|x, y| if let (
+    Input::ToKey { key_image: x, ..},
+    Input::ToKey { key_image: y, ..}
+  ) = (x, y) {
+    x.compress().to_bytes().cmp(&y.compress().to_bytes()).reverse()
+  } else {
+    panic!("Input wasn't ToKey")
+  });
+
+  Ok(signable)
+}
+
+#[derive(Clone, Debug)]
+pub struct SignableTransaction {
+  inputs: Vec<SpendableOutput>,
+  payments: Vec<(Address, u64)>,
+  change: Address,
+  fee_per_byte: u64,
+
+  fee: u64,
+  outputs: Vec<SendOutput>
+}
+
+impl SignableTransaction {
+  pub fn new(
+    inputs: Vec<SpendableOutput>,
+    payments: Vec<(Address, u64)>,
+    change: Address,
+    fee_per_byte: u64
+  ) -> Result<SignableTransaction, TransactionError> {
+    if inputs.len() == 0 {
+      Err(TransactionError::NoInputs)?;
+    }
+    if payments.len() == 0 {
+      Err(TransactionError::NoOutputs)?;
+    }
+
+    Ok(
+      SignableTransaction {
+        inputs,
+        payments,
+        change,
+        fee_per_byte,
+
+        fee: 0,
+        outputs: vec![]
+      }
+    )
+  }
+
+  fn prepare_outputs<R: RngCore + CryptoRng>(
+    &mut self,
+    rng: &mut R,
+    uniqueness: Option<[u8; 32]>
+  ) -> Result<(Vec<Commitment>, Scalar), TransactionError> {
+    self.fee = self.fee_per_byte * 2000; // TODO
+
+    // TODO TX MAX SIZE
+
+    // Make sure we have enough funds
+    let in_amount = self.inputs.iter().map(|input| input.commitment.amount).sum();
+    let out_amount = self.fee + self.payments.iter().map(|payment| payment.1).sum::<u64>();
+    if in_amount < out_amount {
+      Err(TransactionError::NotEnoughFunds(in_amount, out_amount))?;
+    }
+
+    let mut temp_outputs = Vec::with_capacity(self.payments.len() + 1);
+    // Add the payments to the outputs
+    for payment in &self.payments {
+      temp_outputs.push((None, (payment.0, payment.1)));
+    }
+    // Ideally, the change output would always have uniqueness, as we control this wallet software
+    // Unfortunately, if this is used with multisig, doing so would add an extra round due to the
+    // fact Bulletproofs use a leader protocol reliant on this shared key before the first round of
+    // communication. Making the change output unique would require Bulletproofs not be a leader
+    // protocol, using a seeded random
+    // There is a vector where the multisig participants leak the output key they're about to send
+    // to, and someone could use that key, forcing some funds to be burnt accordingly if they win
+    // the race. Any multisig wallet, with this current setup, must only keep change keys in context
+    // accordingly, preferably as soon as they are proposed, even before they appear as confirmed
+    // Using another source of uniqueness would also be possible, yet it'd make scanning a tri-key
+    // system (currently dual for the simpler API, yet would be dual even with a more complex API
+    // under this decision)
+    // TODO after https://github.com/serai-dex/serai/issues/2
+    temp_outputs.push((uniqueness, (self.change, in_amount - out_amount)));
+
+    // Shuffle the outputs
+    temp_outputs.shuffle(rng);
+
+    // Actually create the outputs
+    self.outputs = Vec::with_capacity(temp_outputs.len());
+    let mut commitments = Vec::with_capacity(temp_outputs.len());
+    let mut mask_sum = Scalar::zero();
+    for (o, output) in temp_outputs.iter().enumerate() {
+      self.outputs.push(SendOutput::new(rng, output.0, output.1, o)?);
+      commitments.push(Commitment::new(self.outputs[o].mask, output.1.1));
+      mask_sum += self.outputs[o].mask;
+    }
+
+    Ok((commitments, mask_sum))
+  }
+
+  fn prepare_transaction(
+    &self,
+    commitments: &[Commitment],
+    bp: Bulletproofs
+  ) -> Transaction {
+    // Create the TX extra
+    let mut extra = vec![];
+    SubField::TxPublicKey(
+      PublicKey { point: self.outputs[0].R.compress() }
+    ).consensus_encode(&mut extra).unwrap();
+    SubField::AdditionalPublickKey(
+      self.outputs[1 .. self.outputs.len()].iter().map(|output| PublicKey { point: output.R.compress() }).collect()
+    ).consensus_encode(&mut extra).unwrap();
+
+    // Format it for monero-rs
+    let mut tx_outputs = Vec::with_capacity(self.outputs.len());
+    let mut ecdh_info = Vec::with_capacity(self.outputs.len());
+    for o in 0 .. self.outputs.len() {
+      tx_outputs.push(Output {
+        amount: 0,
+        key: self.outputs[o].dest,
+        tag: None
+      });
+      ecdh_info.push(self.outputs[o].amount);
+    }
+
+    Transaction {
+      prefix: TransactionPrefix {
+        version: 2,
+        unlock_time: 0,
+        inputs: vec![],
+        outputs: tx_outputs,
+        extra
+      },
+      rct_signatures: RctSignatures {
+        base: RctBase {
+          fee: self.fee,
+          ecdh_info,
+          commitments: commitments.iter().map(|commitment| commitment.calculate()).collect()
+        },
+        prunable: RctPrunable::Clsag {
+          bulletproofs: vec![bp],
+          clsags: vec![],
+          pseudo_outs: vec![]
+        }
+      }
+    }
+  }
+
+  pub async fn sign<R: RngCore + CryptoRng>(
+    &mut self,
+    rng: &mut R,
+    rpc: &Rpc,
+    spend: &Scalar
+  ) -> Result<Transaction, TransactionError> {
+    let (commitments, mask_sum) = self.prepare_outputs(
+      rng,
+      Some(
+        uniqueness(
+          &self.inputs.iter().map(|input| Input::ToKey {
+            amount: 0,
+            key_offsets: vec![],
+            key_image: generate_key_image(&(spend + input.key_offset))
+          }).collect::<Vec<_>>()
+        )
+      )
+    )?;
+
+    let mut tx = self.prepare_transaction(&commitments, Bulletproofs::new(&commitments)?);
+
+    let signable = prepare_inputs(rng, rpc, &self.inputs, spend, &mut tx).await?;
+
+    let clsag_pairs = Clsag::sign(rng, &signable, mask_sum, tx.signature_hash());
+    match tx.rct_signatures.prunable {
+      RctPrunable::Null => panic!("Signing for RctPrunable::Null"),
+      RctPrunable::Clsag { ref mut clsags, ref mut pseudo_outs, .. } => {
+        clsags.append(&mut clsag_pairs.iter().map(|clsag| clsag.0.clone()).collect::<Vec<_>>());
+        pseudo_outs.append(&mut clsag_pairs.iter().map(|clsag| clsag.1.clone()).collect::<Vec<_>>());
+      }
+    }
+    Ok(tx)
+  }
+}

coins/monero/src/wallet/send/multisig.rs

@@ -0,0 +1,314 @@
+use std::{rc::Rc, cell::RefCell};
+
+use rand_core::{RngCore, CryptoRng, SeedableRng};
+use rand_chacha::ChaCha12Rng;
+
+use curve25519_dalek::{traits::Identity, scalar::Scalar, edwards::{EdwardsPoint, CompressedEdwardsY}};
+
+use transcript::Transcript as TranscriptTrait;
+use frost::{FrostError, MultisigKeys, MultisigParams, sign::{State, StateMachine, AlgorithmMachine}};
+
+use crate::{
+  frost::{Transcript, Ed25519},
+  random_scalar, bulletproofs::Bulletproofs, clsag::{ClsagInput, ClsagDetails, ClsagMultisig},
+  rpc::Rpc,
+  transaction::{Input, RctPrunable, Transaction},
+  wallet::{TransactionError, SignableTransaction, Decoys}
+};
+
+pub struct TransactionMachine {
+  leader: bool,
+  signable: SignableTransaction,
+  transcript: Transcript,
+
+  decoys: Vec<Decoys>,
+
+  images: Vec<EdwardsPoint>,
+  output_masks: Option<Scalar>,
+  inputs: Vec<Rc<RefCell<Option<ClsagDetails>>>>,
+  clsags: Vec<AlgorithmMachine<Ed25519, ClsagMultisig>>,
+
+  tx: Option<Transaction>
+}
+
+impl SignableTransaction {
+  pub async fn multisig<R: RngCore + CryptoRng>(
+    mut self,
+    label: Vec<u8>,
+    rng: &mut R,
+    rpc: &Rpc,
+    height: usize,
+    keys: MultisigKeys<Ed25519>,
+    included: &[usize]
+  ) -> Result<TransactionMachine, TransactionError> {
+    let mut images = vec![];
+    images.resize(self.inputs.len(), EdwardsPoint::identity());
+    let mut inputs = vec![];
+    for _ in 0 .. self.inputs.len() {
+      // Doesn't resize as that will use a single Rc for the entire Vec
+      inputs.push(Rc::new(RefCell::new(None)));
+    }
+    let mut clsags = vec![];
+
+    // Create a RNG out of the input shared keys, which either requires the view key or being every
+    // sender, and the payments (address and amount), which a passive adversary may be able to know
+    // depending on how these transactions are coordinated
+
+    let mut transcript = Transcript::new(label);
+    // Also include the spend_key as below only the key offset is included, so this confirms the sum product
+    // Useful as confirming the sum product confirms the key image, further guaranteeing the one time
+    // properties noted below
+    transcript.append_message(b"spend_key", &keys.group_key().0.compress().to_bytes());
+    for input in &self.inputs {
+      // These outputs can only be spent once. Therefore, it forces all RNGs derived from this
+      // transcript (such as the one used to create one time keys) to be unique
+      transcript.append_message(b"input_hash", &input.tx);
+      transcript.append_message(b"input_output_index", &u16::try_from(input.o).unwrap().to_le_bytes());
+      // Not including this, with a doxxed list of payments, would allow brute forcing the inputs
+      // to determine RNG seeds and therefore the true spends
+      transcript.append_message(b"input_shared_key", &input.key_offset.to_bytes());
+    }
+    for payment in &self.payments {
+      transcript.append_message(b"payment_address", &payment.0.as_bytes());
+      transcript.append_message(b"payment_amount", &payment.1.to_le_bytes());
+    }
+    transcript.append_message(b"change", &self.change.as_bytes());
+
+    // Select decoys
+    // Ideally, this would be done post entropy, instead of now, yet doing so would require sign
+    // to be async which isn't feasible. This should be suitably competent though
+    // While this inability means we can immediately create the input, moving it out of the
+    // Rc RefCell, keeping it within an Rc RefCell keeps our options flexible
+    let decoys = Decoys::select(
+      &mut ChaCha12Rng::from_seed(transcript.rng_seed(b"decoys", None)),
+      rpc,
+      height,
+      &self.inputs
+    ).await.map_err(|e| TransactionError::RpcError(e))?;
+
+    for (i, input) in self.inputs.iter().enumerate() {
+      clsags.push(
+        AlgorithmMachine::new(
+          ClsagMultisig::new(
+            transcript.clone(),
+            inputs[i].clone()
+          ).map_err(|e| TransactionError::MultisigError(e))?,
+          Rc::new(keys.offset(dalek_ff_group::Scalar(input.key_offset))),
+          included
+        ).map_err(|e| TransactionError::FrostError(e))?
+      );
+    }
+
+    // Verify these outputs by a dummy prep
+    self.prepare_outputs(rng, None)?;
+
+    Ok(TransactionMachine {
+      leader: keys.params().i() == included[0],
+      signable: self,
+      transcript,
+
+      decoys,
+
+      images,
+      output_masks: None,
+      inputs,
+      clsags,
+
+      tx: None
+    })
+  }
+}
+
+impl StateMachine for TransactionMachine {
+  type Signature = Transaction;
+
+  fn preprocess<R: RngCore + CryptoRng>(
+    &mut self,
+    rng: &mut R
+  ) -> Result<Vec<u8>, FrostError> {
+    if self.state() != State::Fresh {
+      Err(FrostError::InvalidSignTransition(State::Fresh, self.state()))?;
+    }
+
+    // Iterate over each CLSAG calling preprocess
+    let mut serialized = vec![];
+    for (i, clsag) in self.clsags.iter_mut().enumerate() {
+      let preprocess = clsag.preprocess(rng)?;
+      // First 64 bytes are FROST's commitments
+      self.images[i] += CompressedEdwardsY(preprocess[64 .. 96].try_into().unwrap()).decompress().unwrap();
+      serialized.extend(&preprocess);
+    }
+
+    if self.leader {
+      let mut entropy = [0; 32];
+      rng.fill_bytes(&mut entropy);
+      serialized.extend(&entropy);
+
+      let mut rng = ChaCha12Rng::from_seed(self.transcript.rng_seed(b"tx_keys", Some(entropy)));
+      // Safe to unwrap thanks to the dummy prepare
+      let (commitments, output_masks) = self.signable.prepare_outputs(&mut rng, None).unwrap();
+      self.output_masks = Some(output_masks);
+
+      let bp = Bulletproofs::new(&commitments).unwrap();
+      bp.serialize(&mut serialized).unwrap();
+
+      let tx = self.signable.prepare_transaction(&commitments, bp);
+      self.tx = Some(tx);
+    }
+
+    Ok(serialized)
+  }
+
+  fn sign(
+    &mut self,
+    commitments: &[Option<Vec<u8>>],
+    _: &[u8]
+  ) -> Result<Vec<u8>, FrostError> {
+    if self.state() != State::Preprocessed {
+      Err(FrostError::InvalidSignTransition(State::Preprocessed, self.state()))?;
+    }
+
+    // FROST commitments, image, commitments, and their proofs
+    let clsag_len = 64 + ClsagMultisig::serialized_len();
+    let clsag_lens = clsag_len * self.clsags.len();
+
+    // Split out the prep and update the TX
+    let mut tx;
+    if self.leader {
+      tx = self.tx.take().unwrap();
+    } else {
+      let (l, prep) = commitments.iter().enumerate().filter(|(_, prep)| prep.is_some()).next()
+        .ok_or(FrostError::InternalError("no participants".to_string()))?;
+      let prep = prep.as_ref().unwrap();
+
+      // Not invalid outputs due to doing a dummy prep as leader
+      let (commitments, output_masks) = self.signable.prepare_outputs(
+        &mut ChaCha12Rng::from_seed(
+          self.transcript.rng_seed(
+            b"tx_keys",
+            Some(prep[clsag_lens .. (clsag_lens + 32)].try_into().map_err(|_| FrostError::InvalidShare(l))?)
+          )
+        ),
+        None
+      ).map_err(|_| FrostError::InvalidShare(l))?;
+      self.output_masks.replace(output_masks);
+
+      // Verify the provided bulletproofs if not leader
+      let bp = Bulletproofs::deserialize(
+        &mut std::io::Cursor::new(&prep[(clsag_lens + 32) .. prep.len()])
+      ).map_err(|_| FrostError::InvalidShare(l))?;
+      if !bp.verify(&commitments.iter().map(|c| c.calculate()).collect::<Vec<EdwardsPoint>>()) {
+        Err(FrostError::InvalidShare(l))?;
+      }
+
+      tx = self.signable.prepare_transaction(&commitments, bp);
+    }
+
+    for c in 0 .. self.clsags.len() {
+      // Calculate the key images in order to update the TX
+      // Multisig will parse/calculate/validate this as needed, yet doing so here as well provides
+      // the easiest API overall
+      for (l, serialized) in commitments.iter().enumerate().filter(|(_, s)| s.is_some()) {
+        self.images[c] += CompressedEdwardsY(
+          serialized.as_ref().unwrap()[((c * clsag_len) + 64) .. ((c * clsag_len) + 96)]
+            .try_into().map_err(|_| FrostError::InvalidCommitment(l))?
+        ).decompress().ok_or(FrostError::InvalidCommitment(l))?;
+      }
+    }
+
+    let mut commitments = (0 .. self.inputs.len()).map(|c| commitments.iter().map(
+      |commitments| commitments.clone().map(
+        |commitments| commitments[(c * clsag_len) .. ((c * clsag_len) + clsag_len)].to_vec()
+      )
+    ).collect::<Vec<_>>()).collect::<Vec<_>>();
+
+    let mut sorted = Vec::with_capacity(self.decoys.len());
+    while self.decoys.len() != 0 {
+      sorted.push((
+        self.signable.inputs.swap_remove(0),
+        self.decoys.swap_remove(0),
+        self.images.swap_remove(0),
+        self.inputs.swap_remove(0),
+        self.clsags.swap_remove(0),
+        commitments.swap_remove(0)
+      ));
+    }
+    sorted.sort_by(|x, y| x.2.compress().to_bytes().cmp(&y.2.compress().to_bytes()).reverse());
+
+    let mut rng = ChaCha12Rng::from_seed(self.transcript.rng_seed(b"pseudo_out_masks", None));
+    let mut sum_pseudo_outs = Scalar::zero();
+    while sorted.len() != 0 {
+      let value = sorted.remove(0);
+
+      let mut mask = random_scalar(&mut rng);
+      if sorted.len() == 0 {
+        mask = self.output_masks.unwrap() - sum_pseudo_outs;
+      } else {
+        sum_pseudo_outs += mask;
+      }
+
+      tx.prefix.inputs.push(
+        Input::ToKey {
+          amount: 0,
+          key_offsets: value.1.offsets.clone(),
+          key_image: value.2
+        }
+      );
+
+      value.3.replace(
+        Some(
+          ClsagDetails::new(
+            ClsagInput::new(
+              value.0.commitment,
+              value.1
+            ).map_err(|_| panic!("Signing an input which isn't present in the ring we created for it"))?,
+            mask
+          )
+        )
+      );
+
+      self.clsags.push(value.4);
+      commitments.push(value.5);
+    }
+
+    let msg = tx.signature_hash();
+    self.tx = Some(tx);
+
+    // Iterate over each CLSAG calling sign
+    let mut serialized = Vec::with_capacity(self.clsags.len() * 32);
+    for (c, clsag) in self.clsags.iter_mut().enumerate() {
+      serialized.extend(&clsag.sign(&commitments[c], &msg)?);
+    }
+
+    Ok(serialized)
+  }
+
+  fn complete(&mut self, shares: &[Option<Vec<u8>>]) -> Result<Transaction, FrostError> {
+    if self.state() != State::Signed {
+      Err(FrostError::InvalidSignTransition(State::Signed, self.state()))?;
+    }
+
+    let mut tx = self.tx.take().unwrap();
+    match tx.rct_signatures.prunable {
+      RctPrunable::Null => panic!("Signing for RctPrunable::Null"),
+      RctPrunable::Clsag { ref mut clsags, ref mut pseudo_outs, .. } => {
+        for (c, clsag) in self.clsags.iter_mut().enumerate() {
+          let (clsag, pseudo_out) = clsag.complete(&shares.iter().map(
+            |share| share.clone().map(|share| share[(c * 32) .. ((c * 32) + 32)].to_vec())
+          ).collect::<Vec<_>>())?;
+          clsags.push(clsag);
+          pseudo_outs.push(pseudo_out);
+        }
+      }
+    }
+    Ok(tx)
+  }
+
+  fn multisig_params(&self) -> MultisigParams {
+    self.clsags[0].multisig_params()
+  }
+
+  fn state(&self) -> State {
+    self.clsags[0].state()
+  }
+}