absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-10 05:09:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace best_* with finalized_*

Browse Source 
We test their equivalency yet still better to use finalized_* in 
general.
This commit is contained in:
Luke Parker
2022-10-30 11:13:47 -04:00
parent c0056643c8
commit 503adfee2f
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
substrate/tendermint/client/src/authority/mod.rs
View File

@@ -72,10 +72,10 @@ impl<T: TendermintValidator> TendermintAuthority<T> {
let info = self.import.client.info();
(
info.best_hash,
info.finalized_hash,
(
// Header::Number: TryInto<u64> doesn't implement Debug and can't be unwrapped
match info.best_number.try_into() {
match info.finalized_number.try_into() {
Ok(best) => BlockNumber(best),
Err(_) => panic!("BlockNumber exceeded u64"),
},
@@ -85,7 +85,7 @@ impl<T: TendermintValidator> TendermintAuthority<T> {
&mut self
.import
.client
.justifications(&BlockId::Hash(info.best_hash))
.justifications(&BlockId::Hash(info.finalized_hash))
.unwrap()
.map(|justifications| justifications.get(CONSENSUS_ID).cloned().unwrap())
.unwrap_or_default()