absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 12:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only check the cosign is after its start block if faulty

Browse Source 
We don't have consensus on the session's last block, so we shouldn't check if
the cosign is before the session ends. What matters is that network, within its
set, claims it's still active at that block (on its view of the blockchain).
This commit is contained in:
Luke Parker
2024-12-26 00:26:48 -05:00
parent df06da5552
commit 3d15710a43
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coordinator/cosign/src/lib.rs
View File

@@ -347,12 +347,14 @@ impl<D: Db> Cosigning<D> {
// Cosign is for a block predating the global session // Cosign is for a block predating the global session
return Ok(false); return Ok(false);
} }
if !faulty {
if let Some(last_block) = GlobalSessionsLastBlock::get(&self.db, cosign.global_session) { if let Some(last_block) = GlobalSessionsLastBlock::get(&self.db, cosign.global_session) {
if cosign.block_number > last_block { if cosign.block_number > last_block {
// Cosign is for a block after the last block this global session should have signed // Cosign is for a block after the last block this global session should have signed
return Ok(false); return Ok(false);
} }
} }
}
// Check the cosign's signature // Check the cosign's signature
{ {