Refine from pedantic, remove erratic consts

crypto/frost/src/algorithm.rs

@@ -147,7 +147,7 @@ pub type IetfSchnorr<C, H> = Schnorr<C, IetfTranscript, H>;
 
 impl<C: Curve, T: Sync + Clone + Debug + Transcript, H: Hram<C>> Schnorr<C, T, H> {
   /// Construct a Schnorr algorithm continuing the specified transcript.
-  pub const fn new(transcript: T) -> Self {
+  pub fn new(transcript: T) -> Self {
     Self { transcript, c: None, _hram: PhantomData }
   }
 }
@@ -156,7 +156,7 @@ impl<C: Curve, H: Hram<C>> IetfSchnorr<C, H> {
   /// Construct a IETF-compatible Schnorr algorithm.
   ///
   /// Please see the `IetfSchnorr` documentation for the full details of this.
-  pub const fn ietf() -> Self {
+  pub fn ietf() -> Self {
     Self::new(IetfTranscript(vec![]))
   }
 }

crypto/frost/src/lib.rs

@@ -1,8 +1,11 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![doc = include_str!("../README.md")]
 
+use core::fmt::Debug;
 use std::collections::HashMap;
 
+use thiserror::Error;
+
 /// Distributed key generation protocol.
 pub use dkg::{self, Participant, ThresholdParams, ThresholdCore, ThresholdKeys, ThresholdView};
 
@@ -20,32 +23,25 @@ pub mod sign;
 #[cfg(any(test, feature = "tests"))]
 pub mod tests;
 
-#[allow(clippy::std_instead_of_core)]
-mod frost_error {
-  use core::fmt::Debug;
-  use thiserror::Error;
-  use dkg::Participant;
-  /// Various errors possible during signing.
-  #[derive(Clone, Copy, PartialEq, Eq, Debug, Error)]
-  pub enum FrostError {
-    #[error("invalid participant (0 < participant <= {0}, yet participant is {1})")]
-    InvalidParticipant(u16, Participant),
-    #[error("invalid signing set ({0})")]
-    InvalidSigningSet(&'static str),
-    #[error("invalid participant quantity (expected {0}, got {1})")]
-    InvalidParticipantQuantity(usize, usize),
-    #[error("duplicated participant ({0})")]
-    DuplicatedParticipant(Participant),
-    #[error("missing participant {0}")]
-    MissingParticipant(Participant),
+/// Various errors possible during signing.
+#[derive(Clone, Copy, PartialEq, Eq, Debug, Error)]
+pub enum FrostError {
+  #[error("invalid participant (0 < participant <= {0}, yet participant is {1})")]
+  InvalidParticipant(u16, Participant),
+  #[error("invalid signing set ({0})")]
+  InvalidSigningSet(&'static str),
+  #[error("invalid participant quantity (expected {0}, got {1})")]
+  InvalidParticipantQuantity(usize, usize),
+  #[error("duplicated participant ({0})")]
+  DuplicatedParticipant(Participant),
+  #[error("missing participant {0}")]
+  MissingParticipant(Participant),
 
-    #[error("invalid preprocess (participant {0})")]
-    InvalidPreprocess(Participant),
-    #[error("invalid share (participant {0})")]
-    InvalidShare(Participant),
-  }
+  #[error("invalid preprocess (participant {0})")]
+  InvalidPreprocess(Participant),
+  #[error("invalid share (participant {0})")]
+  InvalidShare(Participant),
 }
-pub use frost_error::FrostError;
 
 /// Validate a map of values to have the expected participants.
 pub fn validate_map<T>(

crypto/frost/src/sign.rs

@@ -53,7 +53,7 @@ struct Params<C: Curve, A: Algorithm<C>> {
 }
 
 impl<C: Curve, A: Algorithm<C>> Params<C, A> {
-  const fn new(algorithm: A, keys: ThresholdKeys<C>) -> Self {
+  fn new(algorithm: A, keys: ThresholdKeys<C>) -> Self {
     Self { algorithm, keys }
   }
 
@@ -111,7 +111,7 @@ pub struct AlgorithmMachine<C: Curve, A: Algorithm<C>> {
 
 impl<C: Curve, A: Algorithm<C>> AlgorithmMachine<C, A> {
   /// Creates a new machine to generate a signature with the specified keys.
-  pub const fn new(algorithm: A, keys: ThresholdKeys<C>) -> Self {
+  pub fn new(algorithm: A, keys: ThresholdKeys<C>) -> Self {
     Self { params: Params::new(algorithm, keys) }
   }