mirror of
https://github.com/serai-dex/serai.git
synced 2025-12-08 20:29:23 +00:00
monero: investigated TODO and can remove it
The behavior appears to match monero core. monero core isn't throwing an exception in the linked code, it's returning boost::none (and logging an error) which is the same functional behavior as finding that the output does not belong to the user.
This commit is contained in:
@@ -363,7 +363,6 @@ impl Scanner {
|
|||||||
// https://github.com/monero-project/monero/
|
// https://github.com/monero-project/monero/
|
||||||
// blob/04a1e2875d6e35e27bb21497988a6c822d319c28/
|
// blob/04a1e2875d6e35e27bb21497988a6c822d319c28/
|
||||||
// src/cryptonote_basic/cryptonote_format_utils.cpp#L1062
|
// src/cryptonote_basic/cryptonote_format_utils.cpp#L1062
|
||||||
// TODO: Should this return? Where does Monero set the trap handler for this exception?
|
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
None => {
|
None => {
|
||||||
|
|||||||
Reference in New Issue
Block a user