Merge branch 'next' into next-polkadot-sdk

common/request/Cargo.toml

@@ -1,9 +1,9 @@
 [package]
 name = "simple-request"
-version = "0.1.1"
+version = "0.2.0"
 description = "A simple HTTP(S) request library"
 license = "MIT"
-repository = "https://github.com/serai-dex/serai/tree/develop/common/simple-request"
+repository = "https://github.com/serai-dex/serai/tree/develop/common/request"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["http", "https", "async", "request", "ssl"]
 edition = "2021"
@@ -31,5 +31,6 @@ base64ct = { version = "1", features = ["alloc"], optional = true }
 
 [features]
 tls = ["hyper-rustls"]
+webpki-roots = ["tls", "hyper-rustls/webpki-roots"]
 basic-auth = ["zeroize", "base64ct"]
 default = ["tls"]

common/request/src/lib.rs

@@ -52,24 +52,30 @@ pub struct Client {
 }
 
 impl Client {
+  #[allow(clippy::unnecessary_wraps)]
   fn connector() -> Result<Connector, Error> {
     let mut res = HttpConnector::new();
     res.set_keepalive(Some(core::time::Duration::from_secs(60)));
     res.set_nodelay(true);
     res.set_reuse_address(true);
+
     #[cfg(feature = "tls")]
     res.enforce_http(false);
     #[cfg(feature = "tls")]
-    let res = HttpsConnectorBuilder::new()
-      .with_native_roots()
-      .map_err(|e| {
-        Error::ConnectionError(
-          format!("couldn't load system's SSL root certificates: {e:?}").into(),
-        )
-      })?
-      .https_or_http()
-      .enable_http1()
-      .wrap_connector(res);
+    let https = HttpsConnectorBuilder::new().with_native_roots();
+    #[cfg(all(feature = "tls", not(feature = "webpki-roots")))]
+    let https = https.map_err(|e| {
+      Error::ConnectionError(
+        format!("couldn't load system's SSL root certificates and webpki-roots unavilable: {e:?}")
+          .into(),
+      )
+    })?;
+    // Fallback to `webpki-roots` if present
+    #[cfg(all(feature = "tls", feature = "webpki-roots"))]
+    let https = https.unwrap_or(HttpsConnectorBuilder::new().with_webpki_roots());
+    #[cfg(feature = "tls")]
+    let res = https.https_or_http().enable_http1().wrap_connector(res);
+
     Ok(res)
   }
 

common/std-shims/src/lib.rs

@@ -17,8 +17,8 @@ pub mod error {
 #[rustversion::since(1.81)]
 pub use core::error;
 
-#[cfg(all(feature = "alloc", not(feature = "std")))]
-pub extern crate alloc as extern_alloc;
+#[cfg(feature = "alloc")]
+extern crate alloc as extern_alloc;
 #[cfg(all(feature = "alloc", not(feature = "std")))]
 pub use extern_alloc::{alloc, borrow, boxed, ffi, fmt, rc, slice, str, string, task, vec, format};
 #[cfg(feature = "std")]
@@ -30,7 +30,7 @@ pub mod sync;
 
 pub mod prelude {
   // Shim the `std` prelude
-  #[cfg(all(feature = "alloc", not(feature = "std")))]
+  #[cfg(feature = "alloc")]
   pub use extern_alloc::{
     format, vec,
     borrow::ToOwned,