Add job to competently check MSRVs

The prior workflow (now deleted) required manually specifying the packages to check and only checked the package could compile under the stated MSRV. It didn't verify it was actually the _minimum_ supported Rust version. The new version finds the MSRV from scratch to check if the stated MSRV aligns. Updates stated MSRVs accordingly. Also removes many explicit dependencies from secq256k1 for their re-exports via k256. Not directly relevant, just part of tidying up all the `toml`s.
2025-12-08 12:19:24 +00:00 · 2025-08-26 14:04:39 -04:00
parent e3e41324c9
commit 2f833dec77
81 changed files with 251 additions and 430 deletions
--- a/crypto/ciphersuite/kp256/Cargo.toml
+++ b/crypto/ciphersuite/kp256/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/ciphersuite
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["ciphersuite", "ff", "group"]
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.85"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/dalek-ff-group/Cargo.toml
+++ b/crypto/dalek-ff-group/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/dalek-ff-gr
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["curve25519", "ed25519", "ristretto", "dalek", "group"]
 edition = "2021"
-rust-version = "1.65"
+rust-version = "1.66"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/dkg/evrf/Cargo.toml
+++ b/crypto/dkg/evrf/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/dkg/evrf"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["dkg", "multisig", "threshold", "ff", "group"]
 edition = "2021"
-rust-version = "1.81"
+rust-version = "1.89"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/ed448/Cargo.toml
+++ b/crypto/ed448/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/ed448"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["ed448", "ff", "group"]
 edition = "2021"
-rust-version = "1.65"
+rust-version = "1.83"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/evrf/embedwards25519/Cargo.toml
+++ b/crypto/evrf/embedwards25519/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/evrf/embedw
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["curve25519", "ed25519", "ristretto255", "group"]
 edition = "2021"
-rust-version = "1.80"
+rust-version = "1.83"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/evrf/secq256k1/Cargo.toml
+++ b/crypto/evrf/secq256k1/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/evrf/secq25
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["secp256k1", "secq256k1", "group"]
 edition = "2021"
-rust-version = "1.80"
+rust-version = "1.85"

 [package.metadata.docs.rs]
 all-features = true
@@ -19,14 +19,6 @@ hex-literal = { version = "0.4", default-features = false }

 std-shims = { version = "0.1", path = "../../../common/std-shims", default-features = false, optional = true }

-rand_core = { version = "0.6", default-features = false }
-
-zeroize = { version = "^1.5", default-features = false, features = ["zeroize_derive"] }
-subtle = { version = "^2.4", default-features = false }
-
-generic-array = { version = "0.14", default-features = false }
-crypto-bigint = { version = "0.5", default-features = false, features = ["zeroize"] }
-
 k256 = { version = "0.13", default-features = false, features = ["arithmetic"] }

 blake2 = { version = "0.10", default-features = false }
@@ -42,6 +34,6 @@ rand_core = { version = "0.6", features = ["std"] }
 ff-group-tests = { path = "../../ff-group-tests" }

 [features]
-alloc = ["std-shims", "zeroize/alloc", "ciphersuite/alloc"]
-std = ["std-shims/std", "rand_core/std", "zeroize/std", "subtle/std", "blake2/std", "ciphersuite/std", "ec-divisors/std", "generalized-bulletproofs-ec-gadgets/std"]
+alloc = ["std-shims", "k256/alloc", "ciphersuite/alloc"]
+std = ["std-shims/std", "k256/std", "blake2/std", "ciphersuite/std", "ec-divisors/std", "generalized-bulletproofs-ec-gadgets/std"]
 default = ["std"]
--- a/crypto/evrf/secq256k1/src/backend.rs
+++ b/crypto/evrf/secq256k1/src/backend.rs
@@ -1,4 +1,4 @@
-use zeroize::Zeroize;
+use k256::elliptic_curve::zeroize::Zeroize;

 // Use black_box when possible
 #[rustversion::since(1.66)]
@@ -85,13 +85,13 @@ macro_rules! field {
      iter::{Sum, Product},
    };

-    use subtle::{Choice, CtOption, ConstantTimeEq, ConstantTimeLess, ConditionallySelectable};
-    use rand_core::RngCore;
-
-    use crypto_bigint::{Integer, NonZero, Encoding, impl_modulus};
-
-    use ciphersuite::group::ff::{
-      Field, PrimeField, FieldBits, PrimeFieldBits, FromUniformBytes, helpers::sqrt_ratio_generic,
+    use k256::elliptic_curve::{
+      subtle::{Choice, CtOption, ConstantTimeEq, ConstantTimeLess, ConditionallySelectable},
+      rand_core::RngCore,
+      bigint::{Integer, NonZero, Encoding, impl_modulus},
+      group::ff::{
+        Field, PrimeField, FieldBits, PrimeFieldBits, FromUniformBytes, helpers::sqrt_ratio_generic,
+      },
    };

    use $crate::backend::u8_from_bool;
--- a/crypto/evrf/secq256k1/src/lib.rs
+++ b/crypto/evrf/secq256k1/src/lib.rs
@@ -7,8 +7,11 @@ use std_shims::prelude::*;
 #[cfg(any(feature = "alloc", feature = "std"))]
 use std_shims::io::{self, Read};

-use generic_array::typenum::{Sum, Diff, Quot, U, U1, U2};
-use ciphersuite::group::{ff::PrimeField, Group};
+use k256::elliptic_curve::{
+  zeroize::Zeroize,
+  generic_array::typenum::{Sum, Diff, Quot, U, U1, U2},
+  group::{ff::PrimeField, Group},
+};

 #[macro_use]
 mod backend;
@@ -26,8 +29,11 @@ pub use point::Point;
 /// hash_to_F is implemented with a naive concatenation of the dst and data, allowing transposition
 /// between the two. This means `dst: b"abc", data: b"def"`, will produce the same scalar as
 /// `dst: "abcdef", data: b""`. Please use carefully, not letting dsts be substrings of each other.
-#[derive(Clone, Copy, PartialEq, Eq, Debug, zeroize::Zeroize)]
+#[derive(Clone, Copy, PartialEq, Eq, Debug)]
 pub struct Secq256k1;
+impl Zeroize for Secq256k1 {
+  fn zeroize(&mut self) {}
+}
 impl ciphersuite::Ciphersuite for Secq256k1 {
  type F = Scalar;
  type G = Point;
--- a/crypto/evrf/secq256k1/src/point.rs
+++ b/crypto/evrf/secq256k1/src/point.rs
@@ -3,17 +3,16 @@ use core::{
  iter::Sum,
 };

-use rand_core::RngCore;
-
-use zeroize::Zeroize;
-use subtle::{Choice, CtOption, ConstantTimeEq, ConditionallySelectable, ConditionallyNegatable};
-
-use generic_array::{typenum::U33, GenericArray};
-
-use ciphersuite::group::{
-  ff::{Field, PrimeField, PrimeFieldBits},
-  Group, GroupEncoding,
-  prime::PrimeGroup,
+use k256::elliptic_curve::{
+  zeroize::Zeroize,
+  subtle::{Choice, CtOption, ConstantTimeEq, ConditionallySelectable, ConditionallyNegatable},
+  generic_array::{typenum::U33, GenericArray},
+  rand_core::RngCore,
+  group::{
+    ff::{Field, PrimeField, PrimeFieldBits},
+    Group, GroupEncoding,
+    prime::PrimeGroup,
+  },
 };

 use crate::{backend::u8_from_bool, Scalar, FieldElement};
--- a/crypto/evrf/secq256k1/src/scalar.rs
+++ b/crypto/evrf/secq256k1/src/scalar.rs
@@ -1,8 +1,9 @@
-use zeroize::{DefaultIsZeroes, Zeroize};
-
-use crypto_bigint::{
-  U256, U512,
-  modular::constant_mod::{ResidueParams, Residue},
+use k256::elliptic_curve::{
+  zeroize::{DefaultIsZeroes, Zeroize},
+  bigint::{
+    U256, U512,
+    modular::constant_mod::{ResidueParams, Residue},
+  },
 };

 const MODULUS_STR: &str = "FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEFFFFFC2F";
--- a/crypto/frost/Cargo.toml
+++ b/crypto/frost/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/frost"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["frost", "multisig", "threshold"]
 edition = "2021"
-rust-version = "1.80"
+rust-version = "1.79"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/multiexp/Cargo.toml
+++ b/crypto/multiexp/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/multiexp"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["multiexp", "ff", "group"]
 edition = "2021"
-rust-version = "1.80"
+rust-version = "1.79"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/schnorr/Cargo.toml
+++ b/crypto/schnorr/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/schnorr"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["schnorr", "ff", "group"]
 edition = "2021"
-rust-version = "1.80"
+rust-version = "1.79"

 [package.metadata.docs.rs]
 all-features = true
--- a/crypto/schnorrkel/Cargo.toml
+++ b/crypto/schnorrkel/Cargo.toml
@@ -7,7 +7,7 @@ repository = "https://github.com/serai-dex/serai/tree/develop/crypto/schnorrkel"
 authors = ["Luke Parker <lukeparker5132@gmail.com>"]
 keywords = ["frost", "multisig", "threshold", "schnorrkel"]
 edition = "2021"
-rust-version = "1.80"
+rust-version = "1.79"

 [package.metadata.docs.rs]
 all-features = true