absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-08 12:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Natspec, slither Deployer, Router

Browse Source
This commit is contained in:
Luke Parker
2024-10-30 21:35:43 -04:00
parent ce1689b325
commit 2a427382f1
8 changed files with 481 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
networks/ethereum/schnorr/contracts/Schnorr.sol
View File

@@ -2,12 +2,17 @@
pragma solidity ^0.8.26;
/// @title A library for verifying Schnorr signatures
/// @author Luke Parker <lukeparker5132@gmail.com>
/// @author Luke Parker <lukeparker@serai.exchange>
/// @author Elizabeth Binks <elizabethjbinks@gmail.com>
/// @notice Verifies a Schnorr signature for a specified public key
/// @dev This contract is not complete. Only certain public keys are compatible
/// @dev See https://github.com/serai-dex/serai/blob/next/networks/ethereum/schnorr/src/tests/premise.rs for implementation details
// TODO: Pin to a specific branch/commit once `next` is merged into `develop`
/**
* @dev This contract is not complete (in the cryptographic sense). Only a subset of potential
* public keys are representable here.
*
* See https://github.com/serai-dex/serai/blob/next/networks/ethereum/schnorr/src/tests/premise.rs
* for implementation details
*/
// TODO: Pin above link to a specific branch/commit once `next` is merged into `develop`
library Schnorr {
// secp256k1 group order
uint256 private constant Q = 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364141;
@@ -18,26 +23,30 @@ library Schnorr {
uint8 private constant KEY_PARITY = 27;
/// @notice Verifies a Schnorr signature for the specified public key
/// @dev The y-coordinate of the public key is assumed to be even
/// @dev The x-coordinate of the public key is assumed to be less than the order of secp256k1
/// @dev The challenge is calculated as `keccak256(abi.encodePacked(address(R), public_key, message))` where `R` is the commitment to the Schnorr signature's nonce
/// @param public_key The x-coordinate of the public key
/**
* @dev The y-coordinate of the public key is assumed to be even. The x-coordinate of the public
* key is assumed to be less than the order of secp256k1.
*
* The challenge is calculated as `keccak256(abi.encodePacked(address(R), publicKey, message))`
* where `R` is the commitment to the Schnorr signature's nonce.
*/
/// @param publicKey The x-coordinate of the public key
/// @param message The (hash of the) message signed
/// @param c The challenge for the Schnorr signature
/// @param s The response to the challenge for the Schnorr signature
/// @return If the signature is valid
function verify(bytes32 public_key, bytes32 message, bytes32 c, bytes32 s)
function verify(bytes32 publicKey, bytes32 message, bytes32 c, bytes32 s)
internal
pure
returns (bool)
{
// ecrecover = (m, v, r, s) -> key
// We instead pass the following to recover the Schnorr signature's nonce (not a public key)
bytes32 sa = bytes32(Q - mulmod(uint256(s), uint256(public_key), Q));
bytes32 ca = bytes32(Q - mulmod(uint256(c), uint256(public_key), Q));
bytes32 sa = bytes32(Q - mulmod(uint256(s), uint256(publicKey), Q));
bytes32 ca = bytes32(Q - mulmod(uint256(c), uint256(publicKey), Q));
/*
The ecrecover precompile checks `r` and `s` (`public_key` and `ca`) are non-zero, banning the
The ecrecover precompile checks `r` and `s` (`publicKey` and `ca`) are non-zero, banning the
two keys with zero for their x-coordinate and zero challenges. Each already only had a
negligible probability of occuring (assuming zero x-coordinates are even on-curve in the first
place).
@@ -45,11 +54,11 @@ library Schnorr {
`sa` is not checked to be non-zero yet it does not need to be. The inverse of it is never
taken.
*/
address R = ecrecover(sa, KEY_PARITY, public_key, ca);
address R = ecrecover(sa, KEY_PARITY, publicKey, ca);
// The ecrecover failed
if (R == address(0)) return false;
// Check the signature is correct by rebuilding the challenge
return c == keccak256(abi.encodePacked(R, public_key, message));
return c == keccak256(abi.encodePacked(R, publicKey, message));
}
}

16
networks/ethereum/schnorr/contracts/tests/Schnorr.sol
View File

@@ -8,19 +8,23 @@ import "../Schnorr.sol";
/// @author Elizabeth Binks <elizabethjbinks@gmail.com>
contract TestSchnorr {
/// @notice Verifies a Schnorr signature for the specified public key
/// @dev The y-coordinate of the public key is assumed to be even
/// @dev The x-coordinate of the public key is assumed to be less than the order of secp256k1
/// @dev The challenge is calculated as `keccak256(abi.encodePacked(address(R), public_key, message))` where `R` is the commitment to the Schnorr signature's nonce
/// @param public_key The x-coordinate of the public key
/**
* @dev The y-coordinate of the public key is assumed to be even. The x-coordinate of the public
* key is assumed to be less than the order of secp256k1.
*
* The challenge is calculated as `keccak256(abi.encodePacked(address(R), publicKey, message))`
* where `R` is the commitment to the Schnorr signature's nonce.
*/
/// @param publicKey The x-coordinate of the public key
/// @param message The (hash of the) message signed
/// @param c The challenge for the Schnorr signature
/// @param s The response to the challenge for the Schnorr signature
/// @return If the signature is valid
function verify(bytes32 public_key, bytes calldata message, bytes32 c, bytes32 s)
function verify(bytes32 publicKey, bytes calldata message, bytes32 c, bytes32 s)
external
pure
returns (bool)
{
return Schnorr.verify(public_key, keccak256(message), c, s);
return Schnorr.verify(publicKey, keccak256(message), c, s);
}
}