From 295c1bd044b45b21ca6920a7c657cf5154fc99a9 Mon Sep 17 00:00:00 2001 From: Luke Parker Date: Thu, 9 Jan 2025 00:16:45 -0500 Subject: [PATCH] Document improper handling of session rotation in P2P allow list --- coordinator/src/p2p/libp2p/validators.rs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/coordinator/src/p2p/libp2p/validators.rs b/coordinator/src/p2p/libp2p/validators.rs index 7eb2e996..7ba48907 100644 --- a/coordinator/src/p2p/libp2p/validators.rs +++ b/coordinator/src/p2p/libp2p/validators.rs @@ -115,6 +115,15 @@ impl Validators { self.validators.insert(validator, networks); } else { // Because this validator is no longer present in any network, mark them as removed + /* + This isn't accurate. The validator isn't present in the latest session for this + network. The validator was present in the prior session which has yet to retire. Our + lack of explicit inclusion for both the prior session and the current session causes + only the validators mutually present in both sessions to be responsible for all actions + still ongoing as the prior validator set retires. + + TODO: Fix this + */ removed.insert(validator); } }