From 16065ccd4e47655d8d4d7da71b7dc520353f88a0 Mon Sep 17 00:00:00 2001 From: Luke Parker Date: Wed, 2 Nov 2022 03:29:04 -0400 Subject: [PATCH] Remove an attempt at caching I don't believe would ever hit --- substrate/tendermint/client/src/tendermint.rs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/substrate/tendermint/client/src/tendermint.rs b/substrate/tendermint/client/src/tendermint.rs index 285075d6..901c591e 100644 --- a/substrate/tendermint/client/src/tendermint.rs +++ b/substrate/tendermint/client/src/tendermint.rs @@ -176,16 +176,6 @@ impl TendermintImport { &self, block: &mut BlockImportParams, ) -> Result<(), Error> { - if block.finalized { - if block.fork_choice != Some(ForkChoiceStrategy::Custom(false)) { - // Since we alw1ays set the fork choice, this means something else marked the block as - // finalized, which shouldn't be possible. Ensuring nothing else is setting blocks as - // finalized helps ensure our security - panic!("block was finalized despite not setting the fork choice"); - } - return Ok(()); - } - // Set the block as a worse choice block.fork_choice = Some(ForkChoiceStrategy::Custom(false));