Add Batch messages from processor, verify Batchs published on-chain

Renames Update to SignedBatch.

Checks Batch equality via a hash of the InInstructions. That prevents needing
to keep the Batch in node state or TX introspect.

substrate/client/Cargo.toml

@@ -36,6 +36,8 @@ lazy_static = "1"
 
 rand_core = "0.6"
 
+blake2 = "0.10"
+
 ciphersuite = { path = "../../crypto/ciphersuite", features = ["ristretto"] }
 frost = { package = "modular-frost", path = "../../crypto/frost", features = ["tests"] }
 schnorrkel = { path = "../../crypto/schnorrkel", package = "frost-schnorrkel" }

substrate/client/tests/batch.rs

@@ -1,5 +1,12 @@
 use rand_core::{RngCore, OsRng};
 
+use blake2::{
+  digest::{consts::U32, Digest},
+  Blake2b,
+};
+
+use scale::Encode;
+
 use serai_client::{
   primitives::{Amount, NetworkId, Coin, Balance, BlockHash, SeraiAddress},
   in_instructions::{
@@ -38,12 +45,20 @@ serai_test!(
       }],
     };
 
-    let block = provide_batch(batch).await;
+    let block = provide_batch(batch.clone()).await;
 
     let serai = serai().await;
     assert_eq!(serai.get_latest_block_for_network(block, network).await.unwrap(), Some(block_hash));
     let batches = serai.get_batch_events(block).await.unwrap();
-    assert_eq!(batches, vec![InInstructionsEvent::Batch { network, id, block: block_hash }]);
+    assert_eq!(
+      batches,
+      vec![InInstructionsEvent::Batch {
+        network,
+        id,
+        block: block_hash,
+        instructions_hash: Blake2b::<U32>::digest(batch.instructions.encode()).into(),
+      }]
+    );
 
     assert_eq!(
       serai.get_mint_events(block).await.unwrap(),

substrate/client/tests/burn.rs

@@ -1,5 +1,12 @@
 use rand_core::{RngCore, OsRng};
 
+use blake2::{
+  digest::{consts::U32, Digest},
+  Blake2b,
+};
+
+use scale::Encode;
+
 use sp_core::Pair;
 
 use serai_client::{
@@ -45,11 +52,19 @@ serai_test!(
       }],
     };
 
-    let block = provide_batch(batch).await;
+    let block = provide_batch(batch.clone()).await;
 
     let serai = serai().await;
     let batches = serai.get_batch_events(block).await.unwrap();
-    assert_eq!(batches, vec![InInstructionsEvent::Batch { network, id, block: block_hash }]);
+    assert_eq!(
+      batches,
+      vec![InInstructionsEvent::Batch {
+        network,
+        id,
+        block: block_hash,
+        instructions_hash: Blake2b::<U32>::digest(batch.instructions.encode()).into(),
+      }]
+    );
 
     assert_eq!(
       serai.get_mint_events(block).await.unwrap(),

substrate/client/tests/common/in_instructions.rs

@@ -1,3 +1,10 @@
+use blake2::{
+  digest::{consts::U32, Digest},
+  Blake2b,
+};
+
+use scale::Encode;
+
 use sp_core::Pair;
 
 use serai_client::{
@@ -38,7 +45,12 @@ pub async fn provide_batch(batch: Batch) -> [u8; 32] {
   // TODO: impl From<Batch> for BatchEvent?
   assert_eq!(
     batches,
-    vec![InInstructionsEvent::Batch { network: batch.network, id: batch.id, block: batch.block }],
+    vec![InInstructionsEvent::Batch {
+      network: batch.network,
+      id: batch.id,
+      block: batch.block,
+      instructions_hash: Blake2b::<U32>::digest(batch.instructions.encode()).into(),
+    }],
   );
 
   // TODO: Check the tokens events

substrate/in-instructions/pallet/Cargo.toml

@@ -17,9 +17,10 @@ thiserror = { version = "1", optional = true }
 scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive", "max-encoded-len"] }
 scale-info = { version = "2", default-features = false, features = ["derive"] }
 
+sp-core = { git = "https://github.com/serai-dex/substrate", default-features = false }
+sp-io = { git = "https://github.com/serai-dex/substrate", default-features = false }
 sp-application-crypto = { git = "https://github.com/serai-dex/substrate", default-features = false }
 sp-runtime = { git = "https://github.com/serai-dex/substrate", default-features = false }
-sp-core = { git = "https://github.com/serai-dex/substrate", default-features = false }
 
 frame-system = { git = "https://github.com/serai-dex/substrate", default-features = false }
 frame-support = { git = "https://github.com/serai-dex/substrate", default-features = false }
@@ -37,6 +38,9 @@ std = [
   "scale/std",
   "scale-info/std",
 
+  "sp-core/std",
+  "sp-io/std",
+  "sp-application-crypto/std",
   "sp-runtime/std",
 
   "frame-system/std",

substrate/in-instructions/pallet/src/lib.rs

@@ -4,6 +4,7 @@
 
 use scale::Encode;
 
+use sp_io::hashing::blake2_256;
 use sp_runtime::RuntimeDebug;
 
 use serai_primitives::{BlockHash, NetworkId};
@@ -45,7 +46,7 @@ pub mod pallet {
   #[pallet::event]
   #[pallet::generate_deposit(fn deposit_event)]
   pub enum Event<T: Config> {
-    Batch { network: NetworkId, id: u32, block: BlockHash },
+    Batch { network: NetworkId, id: u32, block: BlockHash, instructions_hash: [u8; 32] },
     InstructionFailure { network: NetworkId, id: u32, index: u32 },
   }
 
@@ -123,6 +124,7 @@ pub mod pallet {
         network: batch.network,
         id: batch.id,
         block: batch.block,
+        instructions_hash: blake2_256(&batch.instructions.encode()),
       });
       for (i, instruction) in batch.instructions.into_iter().enumerate() {
         // TODO: Check this balance's coin belongs to this network