absolutebi/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-12-10 21:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the precommit signature hash

Browse Source 
It cached signatures per-block. Precommit signatures are bound to each 
round. This would lead to forming invalid commits when a commit should 
be formed. Under debug, the machine would catch that and panic. On 
release, it'd have everyone who wasn't a validator fail to continue 
syncing.
This commit is contained in:
Luke Parker
2022-11-13 18:15:19 -05:00
parent b7502a7f67
commit 0b8181b912
2 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
substrate/tendermint/machine/src/lib.rs
View File

@@ -345,15 +345,15 @@ impl<N: Network + 'static> TendermintMachine<N> {
Ok(Some(block)) => { Ok(Some(block)) => {
let mut validators = vec![]; let mut validators = vec![];
let mut sigs = vec![]; let mut sigs = vec![];
for (v, sig) in self // Get all precommits for this round
.block for (validator, msgs) in &self.block.log.log[&msg.round] {
.log if let Some(Data::Precommit(Some((id, sig)))) = msgs.get(&Step::Precommit) {
.precommitted // If this precommit was for this block, include it
.iter() if id == &block.id() {
.filter_map(|(k, (id, sig))| Some((*k, sig.clone())).filter(|_| id == &block.id())) validators.push(*validator);
{ sigs.push(sig.clone());
validators.push(v); }
sigs.push(sig); }
} }
let commit = Commit { let commit = Commit {

11
substrate/tendermint/machine/src/message_log.rs
View File

@@ -4,10 +4,7 @@ use crate::{ext::*, RoundNumber, Step, Data, DataFor, MessageFor, TendermintErro
pub(crate) struct MessageLog<N: Network> { pub(crate) struct MessageLog<N: Network> {
weights: Arc<N::Weights>, weights: Arc<N::Weights>,
pub(crate) precommitted: HashMap< precommitted: HashMap<N::ValidatorId, <N::Block as Block>::Id>,
N::ValidatorId,
(<N::Block as Block>::Id, <N::SignatureScheme as SignatureScheme>::Signature),
>,
pub(crate) log: HashMap<RoundNumber, HashMap<N::ValidatorId, HashMap<Step, DataFor<N>>>>, pub(crate) log: HashMap<RoundNumber, HashMap<N::ValidatorId, HashMap<Step, DataFor<N>>>>,
} }
@@ -34,13 +31,13 @@ impl<N: Network> MessageLog<N> {
} }
// If they already precommitted to a distinct hash, error // If they already precommitted to a distinct hash, error
if let Data::Precommit(Some((hash, sig))) = &msg.data { if let Data::Precommit(Some((hash, _))) = &msg.data {
if let Some((prev, _)) = self.precommitted.get(&msg.sender) { if let Some(prev) = self.precommitted.get(&msg.sender) {
if hash != prev { if hash != prev {
Err(TendermintError::Malicious(msg.sender))?; Err(TendermintError::Malicious(msg.sender))?;
} }
} }
self.precommitted.insert(msg.sender, (*hash, sig.clone())); self.precommitted.insert(msg.sender, *hash);
} }
msgs.insert(step, msg.data); msgs.insert(step, msg.data);