Further expand clippy workspace lints

Achieves a notable amount of reduced async and clones.

coins/monero/src/wallet/scan.rs

@@ -356,17 +356,19 @@ impl Scanner {
       let output_key = output_key.unwrap();
 
       for key in [Some(Some(&tx_key)), additional.as_ref().map(|additional| additional.get(o))] {
-        let key = if let Some(Some(key)) = key {
-          key
-        } else if let Some(None) = key {
-          // This is non-standard. There were additional keys, yet not one for this output
-          // https://github.com/monero-project/monero/
-          //   blob/04a1e2875d6e35e27bb21497988a6c822d319c28/
-          //   src/cryptonote_basic/cryptonote_format_utils.cpp#L1062
-          // TODO: Should this return? Where does Monero set the trap handler for this exception?
-          continue;
-        } else {
-          break;
+        let key = match key {
+          Some(Some(key)) => key,
+          Some(None) => {
+            // This is non-standard. There were additional keys, yet not one for this output
+            // https://github.com/monero-project/monero/
+            //   blob/04a1e2875d6e35e27bb21497988a6c822d319c28/
+            //   src/cryptonote_basic/cryptonote_format_utils.cpp#L1062
+            // TODO: Should this return? Where does Monero set the trap handler for this exception?
+            continue;
+          }
+          None => {
+            break;
+          }
         };
         let (view_tag, shared_key, payment_id_xor) = shared_key(
           if self.burning_bug.is_none() { Some(uniqueness(&tx.prefix.inputs)) } else { None },

coins/monero/src/wallet/seed/classic.rs

@@ -134,6 +134,7 @@ fn checksum_index(words: &[Zeroizing<String>], lang: &WordList) -> usize {
 }
 
 // Convert a private key to a seed
+#[allow(clippy::needless_pass_by_value)]
 fn key_to_seed(lang: Language, key: Zeroizing<Scalar>) -> ClassicSeed {
   let bytes = Zeroizing::new(key.to_bytes());
 
@@ -282,6 +283,7 @@ impl ClassicSeed {
     key_to_seed(lang, Zeroizing::new(random_scalar(rng)))
   }
 
+  #[allow(clippy::needless_pass_by_value)]
   pub fn from_string(words: Zeroizing<String>) -> Result<ClassicSeed, SeedError> {
     let (lang, entropy) = seed_to_bytes(&words)?;
 
@@ -297,6 +299,7 @@ impl ClassicSeed {
     Ok(Self::from_entropy(lang, entropy).unwrap())
   }
 
+  #[allow(clippy::needless_pass_by_value)]
   pub fn from_entropy(lang: Language, entropy: Zeroizing<[u8; 32]>) -> Option<ClassicSeed> {
     Option::from(Scalar::from_canonical_bytes(*entropy))
       .map(|scalar| key_to_seed(lang, Zeroizing::new(scalar)))

coins/monero/src/wallet/seed/polyseed.rs

@@ -262,6 +262,7 @@ impl Polyseed {
   }
 
   /// Create a new `Polyseed` from a String.
+  #[allow(clippy::needless_pass_by_value)]
   pub fn from_string(seed: Zeroizing<String>) -> Result<Polyseed, SeedError> {
     // Decode the seed into its polynomial coefficients
     let mut poly = [0; POLYSEED_LENGTH];
@@ -302,7 +303,7 @@ impl Polyseed {
           }
 
           let Some(coeff) = (if lang.has_accent {
-            let ascii = |word: &str| word.chars().filter(|c| c.is_ascii()).collect::<String>();
+            let ascii = |word: &str| word.chars().filter(char::is_ascii).collect::<String>();
             check_if_matches(
               lang.has_prefix,
               lang.words.iter().map(|lang_word| ascii(lang_word)),

coins/monero/src/wallet/send/builder.rs

@@ -136,7 +136,7 @@ impl SignableTransactionBuilder {
       read.r_seed.clone(),
       read.inputs.clone(),
       read.payments.clone(),
-      read.change_address.clone(),
+      &read.change_address,
       read.data.clone(),
       read.fee_rate,
     )

coins/monero/src/wallet/send/mod.rs

@@ -415,7 +415,7 @@ impl SignableTransaction {
     r_seed: Option<Zeroizing<[u8; 32]>>,
     inputs: Vec<(SpendableOutput, Decoys)>,
     payments: Vec<(MoneroAddress, u64)>,
-    change: Change,
+    change: &Change,
     data: Vec<Vec<u8>>,
     fee_rate: Fee,
   ) -> Result<SignableTransaction, TransactionError> {

coins/monero/src/wallet/send/multisig.rs

@@ -70,7 +70,7 @@ impl SignableTransaction {
   /// The height is the Monero blockchain height to synchronize around.
   pub fn multisig(
     self,
-    keys: ThresholdKeys<Ed25519>,
+    keys: &ThresholdKeys<Ed25519>,
     mut transcript: RecommendedTranscript,
   ) -> Result<TransactionMachine, TransactionError> {
     let mut inputs = vec![];