2023-08-01 05:33:08 -04:00
|
|
|
#![allow(clippy::needless_pass_by_ref_mut)] // False positives
|
|
|
|
|
|
2023-07-22 04:04:17 -04:00
|
|
|
use std::sync::{OnceLock, Mutex};
|
|
|
|
|
|
2023-07-24 20:06:05 -04:00
|
|
|
use zeroize::Zeroizing;
|
2023-07-21 14:01:58 -04:00
|
|
|
use rand_core::{RngCore, OsRng};
|
|
|
|
|
|
|
|
|
|
use ciphersuite::{group::ff::PrimeField, Ciphersuite, Ristretto};
|
|
|
|
|
|
2023-07-29 04:26:24 -04:00
|
|
|
use serai_client::primitives::NetworkId;
|
2023-07-24 20:06:05 -04:00
|
|
|
use messages::{ProcessorMessage, CoordinatorMessage};
|
|
|
|
|
use serai_message_queue::{Service, Metadata, client::MessageQueue};
|
2023-07-22 04:04:17 -04:00
|
|
|
|
2023-07-21 14:01:58 -04:00
|
|
|
use dockertest::{
|
2023-10-23 06:59:38 -04:00
|
|
|
PullPolicy, Image, LogAction, LogPolicy, LogSource, LogOptions, StartPolicy,
|
|
|
|
|
TestBodySpecification, DockerOperations,
|
2023-07-21 14:01:58 -04:00
|
|
|
};
|
|
|
|
|
|
2023-07-24 20:06:05 -04:00
|
|
|
mod networks;
|
|
|
|
|
pub use networks::*;
|
2023-07-21 14:01:58 -04:00
|
|
|
|
2023-07-24 20:06:05 -04:00
|
|
|
#[cfg(test)]
|
|
|
|
|
mod tests;
|
2023-07-22 04:04:17 -04:00
|
|
|
|
2023-07-24 20:06:05 -04:00
|
|
|
static UNIQUE_ID: OnceLock<Mutex<u16>> = OnceLock::new();
|
2023-07-22 04:04:17 -04:00
|
|
|
|
|
|
|
|
pub fn processor_instance(
|
|
|
|
|
network: NetworkId,
|
2023-07-24 20:06:05 -04:00
|
|
|
port: u32,
|
2023-07-22 04:04:17 -04:00
|
|
|
message_queue_key: <Ristretto as Ciphersuite>::F,
|
2024-05-22 18:50:11 -04:00
|
|
|
) -> Vec<TestBodySpecification> {
|
2023-07-21 14:01:58 -04:00
|
|
|
let mut entropy = [0; 32];
|
|
|
|
|
OsRng.fill_bytes(&mut entropy);
|
|
|
|
|
|
2023-11-12 23:55:15 -05:00
|
|
|
let network_str = match network {
|
|
|
|
|
NetworkId::Serai => panic!("starting a processor for Serai"),
|
|
|
|
|
NetworkId::Bitcoin => "bitcoin",
|
|
|
|
|
NetworkId::Ethereum => "ethereum",
|
|
|
|
|
NetworkId::Monero => "monero",
|
|
|
|
|
};
|
|
|
|
|
let image = format!("{network_str}-processor");
|
|
|
|
|
serai_docker_tests::build(image.clone());
|
|
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
let mut res = vec![TestBodySpecification::with_image(
|
2023-11-12 23:55:15 -05:00
|
|
|
Image::with_repository(format!("serai-dev-{image}")).pull_policy(PullPolicy::Never),
|
2023-07-21 14:01:58 -04:00
|
|
|
)
|
2023-10-23 06:59:38 -04:00
|
|
|
.replace_env(
|
2023-07-21 14:01:58 -04:00
|
|
|
[
|
|
|
|
|
("MESSAGE_QUEUE_KEY".to_string(), hex::encode(message_queue_key.to_repr())),
|
|
|
|
|
("ENTROPY".to_string(), hex::encode(entropy)),
|
2023-11-12 23:55:15 -05:00
|
|
|
("NETWORK".to_string(), network_str.to_string()),
|
2023-07-22 04:04:17 -04:00
|
|
|
("NETWORK_RPC_LOGIN".to_string(), format!("{RPC_USER}:{RPC_PASS}")),
|
|
|
|
|
("NETWORK_RPC_PORT".to_string(), port.to_string()),
|
2023-07-21 14:01:58 -04:00
|
|
|
("DB_PATH".to_string(), "./processor-db".to_string()),
|
Add support for multiple multisigs to the processor (#377)
* Design and document a multisig rotation flow
* Make Scanner::eventualities a HashMap so it's per-key
* Don't drop eventualities, always follow through on them
Technical improvements made along the way.
* Start creating an isolate object to manage multisigs, which doesn't require being a signer
Removes key from SubstrateBlock.
* Move Scanner/Scheduler under multisigs
* Move Batch construction into MultisigManager
* Clarify "should" in Multisig Rotation docs
* Add block_number to MultisigManager, as it controls the scanner
* Move sign_plans into MultisigManager
Removes ThresholdKeys from prepare_send.
* Make SubstrateMutable an alias for MultisigManager
* Rewrite Multisig Rotation
The prior scheme had an exploit possible where funds were sent to the old
multisig, then burnt on Serai to send from the new multisig, locking liquidity
for 6 hours. While a fee could be applied to stragglers, to make this attack
unprofitable, the newly described scheme avoids all this.
* Add mini
mini is a miniature version of Serai, emphasizing Serai's nature as a
collection of independent clocks. The intended use is to identify race
conditions and prove protocols are comprehensive regarding when certain clocks
tick.
This uses loom, a prior candidate for evaluating the processor/coordinator as
free of race conditions (#361).
* Use mini to prove a race condition in the current multisig rotation docs, and prove safety of alternatives
Technically, the prior commit had mini prove the race condition.
The docs currently say the activation block of the new multisig is the block
after the next Batch's. If the two next Batches had already entered the
mempool, prior to set_keys being called, the second next Batch would be
expected to contain the new key's data yet fail to as the key wasn't public
when the Batch was actually created.
The naive solution is to create a Batch, publish it, wait until it's included,
and only then scan the next block. This sets a bound of
`Batch publication time < block time`. Optimistically, we can publish a Batch
in 24s while our shortest block time is 2m. Accordingly, we should be fine with
the naive solution which doesn't take advantage of throughput. #333 may
significantly change latency however and require an algorithm whose throughput
exceeds the rate of blocks created.
In order to re-introduce parallelization, enabling throughput, we need to
define a safe range of blocks to scan without Serai ordering the first one.
mini demonstrates safety of scanning n blocks Serai hasn't acknowledged, so
long as the first is scanned before block n+1 is (shifting the n-block window).
The docs will be updated next, to reflect this.
* Fix Multisig Rotation
I believe this is finally good enough to be final.
1) Fixes the race condition present in the prior document, as demonstrated by
mini.
`Batch`s for block `n` and `n+1`, may have been in the mempool when a
multisig's activation block was set to `n`. This would cause a potentially
distinct `Batch` for `n+1`, despite `n+1` already having a signed `Batch`.
2) Tightens when UIs should use the new multisig to prevent eclipse attacks,
and protection against `Batch` publication delays.
3) Removes liquidity fragmentation by tightening flow/handling of latency.
4) Several clarifications and documentation of reasoning.
5) Correction of "prior multisig" to "all prior multisigs" regarding historical
verification, with explanation why.
* Clarify terminology in mini
Synchronizes it from my original thoughts on potential schema to the design
actually created.
* Remove most of processor's README for a reference to docs/processor
This does drop some misc commentary, though none too beneficial. The section on
scanning, deemed sufficiently beneficial, has been moved to a document and
expanded on.
* Update scanner TODOs in line with new docs
* Correct documentation on Bitcoin::Block::time, and Block::time
* Make the scanner in MultisigManager no longer public
* Always send ConfirmKeyPair, regardless of if in-set
* Cargo.lock changes from a prior commit
* Add a policy document on defining a Canonical Chain
I accidentally committed a version of this with a few headers earlier, and this
is a proper version.
* Competent MultisigManager::new
* Update processor's comments
* Add mini to copied files
* Re-organize Scanner per multisig rotation document
* Add RUST_LOG trace targets to e2e tests
* Have the scanner wait once it gets too far ahead
Also bug fixes.
* Add activation blocks to the scanner
* Split received outputs into existing/new in MultisigManager
* Select the proper scheduler
* Schedule multisig activation as detailed in documentation
* Have the Coordinator assert if multiple `Batch`s occur within a block
While the processor used to have ack_up_to_block, enabling skips in the block
acked, support for this was removed while reworking it for multiple multisigs.
It should happen extremely infrequently.
While it would still be beneficial to have, if multiple `Batch`s could occur
within a block (with the complexity here not being worth adding that ban as a
policy), multiple `Batch`s were blocked for DoS reasons.
* Schedule payments to the proper multisig
* Correct >= to <
* Use the new multisig's key for change on schedule
* Don't report External TXs to prior multisig once deprecated
* Forward from the old multisig to the new one at all opportunities
* Move unfulfilled payments in queue from prior to new multisig
* Create MultisigsDb, splitting it out of MainDb
Drops the call to finish_signing from the Signer. While this will cause endless
re-attempts, the Signer will still consider them completed and drop them,
making this an O(n) cost at boot even if we did nothing from here.
The MultisigManager should call finish_signing once the Scanner completes the
Eventuality.
* Don't check Scanner-emitted completions, trust they are completions
Prevents needing to use async code to mark the completion and creates a
fault-free model. The current model, on fault, would cause a lack of marked
completion in the signer.
* Fix a possible panic in the processor
A shorter-chain reorg could cause this assert to trip. It's fixed by
de-duplicating the data, as the assertion checked consistency. Without the
potential for inconsistency, it's unnecessary.
* Document why an existing TODO isn't valid
* Change when we drop payments for being to the change address
The earlier timing prevents creating Plans solely to the branch address,
causing the payments to be dropped, and the TX to become an effective
aggregation TX.
* Extensively document solutions to Eventualities being potentially created after having already scanned their resolutions
* When closing, drop External/Branch outputs which don't cause progress
* Properly decide if Change outputs should be forward or not when closing
This completes all code needed to make the old multisig have a finite lifetime.
* Commentary on forwarding schemes
* Provide a 1 block window, with liquidity fragmentation risks, due to latency
On Bitcoin, this will be 10 minutes for the relevant Batch to be confirmed. On
Monero, 2 minutes. On Ethereum, ~6 minutes.
Also updates the Multisig Rotation document with the new forwarding plan.
* Implement transaction forwarding from old multisig to new multisig
Identifies a fault where Branch outputs which shouldn't be dropped may be, if
another output fulfills their next step. Locking Branch fulfillment down to
only Branch outputs is not done in this commit, but will be in the next.
* Only let Branch outputs fulfill branches
* Update TODOs
* Move the location of handling signer events to avoid a race condition
* Avoid a deadlock by using a RwLock on a single txn instead of two txns
* Move Batch ID out of the Scanner
* Increase from one block of latency on new keys activation to two
For Monero, this offered just two minutes when our latency to publish a Batch
is around a minute already. This does increase the time our liquidity can be
fragmented by up to 20 minutes (Bitcoin), yet it's a stupid attack only
possible once a week (when we rotate). Prioritizing normal users' transactions
not being subject to forwarding is more important here.
Ideally, we'd not do +2 blocks yet plus `time`, such as +10 minutes, making
this agnostic of the underlying network's block scheduling. This is a
complexity not worth it.
* Split MultisigManager::substrate_block into multiple functions
* Further tweaks to substrate_block
* Acquire a lock on all Scanner operations after calling ack_block
Gives time to call register_eventuality and initiate signing.
* Merge sign_plans into substrate_block
Also ensure the Scanner's lock isn't prematurely released.
* Use a HashMap to pass to-be-forwarded instructions, not the DB
* Successfully determine in ClosingExisting
* Move from 2 blocks of latency when rotating to 10 minutes
Superior as noted in 6d07af92ce10cfd74c17eb3400368b0150eb36d7, now trivial to
implement thanks to prior commit.
* Add note justifying measuring time in blocks when rotating
* Implement delaying of outputs received early to the new multisig per specification
* Documentation on why Branch outputs don't have the race condition concerns Change do
Also ensures 6 hours is at least N::CONFIRMATIONS, for sanity purposes.
* Remove TODO re: sanity checking Eventualities
We sanity check the Plan the Eventuality is derived from, and the Eventuality
is handled moments later (in the same file, with a clear call path). There's no
reason to add such APIs to Eventualities for a sanity check given that.
* Add TODO(now) for TODOs which must be done in this branch
Also deprecates a pair of TODOs to TODO2, and accepts the flow of the Signer
having the Eventuality.
* Correct errors in potential/future flow descriptions
* Accept having a single Plan Vec
Per the following code consuming it, there's no benefit to bifurcating it by
key.
* Only issue sign_transaction on boot for the proper signer
* Only set keys when participating in their construction
* Misc progress
Only send SubstrateBlockAck when we have a signer, as it's only used to tell
the Tributary of what Plans are being signed in response to this block.
Only immediately sets substrate_signer if session is 0.
On boot, doesn't panic if we don't have an active key (as we wouldn't if only
joining the next multisig). Continues.
* Correctly detect and set retirement block
Modifies the retirement block from first block meeting requirements to block
CONFIRMATIONS after.
Adds an ack flow to the Scanner's Confirmed event and Block event to accomplish
this, which may deadlock at this time (will be fixed shortly).
Removes an invalid await (after a point declared unsafe to use await) from
MultisigsManager::next_event.
* Remove deadlock in multisig_completed and document alternative
The alternative is simpler, albeit less efficient. There's no reason to adopt
it now, yet perhaps if it benefits modeling?
* Handle the final step of retirement, dropping the old key and setting new to existing
* Remove TODO about emitting a Block on every step
If we emit on NewAsChange, we lose the purpose of the NewAsChange period.
The only concern is if we reach ClosingExisting, and nothing has happened, then
all coins will still be in the old multisig until something finally does. This
isn't a problem worth solving, as it's latency under exceptional dead time.
* Add TODO about potentially not emitting a Block event for the reitrement block
* Restore accidentally deleted CI file
* Pair of slight tweaks
* Add missing if statement
* Disable an assertion when testing
One of the test flows currently abuses the Scanner in a way triggering it.
2023-09-25 09:48:15 -04:00
|
|
|
("RUST_LOG".to_string(), "serai_processor=trace,".to_string()),
|
2023-07-21 14:01:58 -04:00
|
|
|
]
|
|
|
|
|
.into(),
|
2024-05-22 18:50:11 -04:00
|
|
|
)];
|
|
|
|
|
|
|
|
|
|
if network == NetworkId::Ethereum {
|
|
|
|
|
serai_docker_tests::build("ethereum-relayer".to_string());
|
|
|
|
|
res.push(
|
|
|
|
|
TestBodySpecification::with_image(
|
|
|
|
|
Image::with_repository("serai-dev-ethereum-relayer".to_string())
|
|
|
|
|
.pull_policy(PullPolicy::Never),
|
|
|
|
|
)
|
|
|
|
|
.replace_env(
|
|
|
|
|
[
|
|
|
|
|
("DB_PATH".to_string(), "./ethereum-relayer-db".to_string()),
|
|
|
|
|
("RUST_LOG".to_string(), "serai_ethereum_relayer=trace,".to_string()),
|
|
|
|
|
]
|
|
|
|
|
.into(),
|
|
|
|
|
)
|
|
|
|
|
.set_publish_all_ports(true),
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
res
|
2023-07-21 14:01:58 -04:00
|
|
|
}
|
|
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
pub type Handles = (String, String, String, String);
|
2023-07-22 04:04:17 -04:00
|
|
|
pub fn processor_stack(
|
|
|
|
|
network: NetworkId,
|
2024-05-21 00:29:33 -04:00
|
|
|
network_hostname_override: Option<String>,
|
2023-10-23 06:59:38 -04:00
|
|
|
) -> (Handles, <Ristretto as Ciphersuite>::F, Vec<TestBodySpecification>) {
|
2023-07-22 04:04:17 -04:00
|
|
|
let (network_composition, network_rpc_port) = network_instance(network);
|
2023-07-21 14:01:58 -04:00
|
|
|
|
|
|
|
|
let (coord_key, message_queue_keys, message_queue_composition) =
|
|
|
|
|
serai_message_queue_tests::instance();
|
2023-07-22 04:04:17 -04:00
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
let mut processor_compositions =
|
2023-07-22 04:04:17 -04:00
|
|
|
processor_instance(network, network_rpc_port, message_queue_keys[&network]);
|
|
|
|
|
|
|
|
|
|
// Give every item in this stack a unique ID
|
|
|
|
|
// Uses a Mutex as we can't generate a 8-byte random ID without hitting hostname length limits
|
|
|
|
|
let unique_id = {
|
|
|
|
|
let unique_id_mutex = UNIQUE_ID.get_or_init(|| Mutex::new(0));
|
|
|
|
|
let mut unique_id_lock = unique_id_mutex.lock().unwrap();
|
2023-10-23 06:59:38 -04:00
|
|
|
let unique_id = *unique_id_lock;
|
2023-07-22 04:04:17 -04:00
|
|
|
*unique_id_lock += 1;
|
|
|
|
|
unique_id
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let mut compositions = vec![];
|
|
|
|
|
let mut handles = vec![];
|
2023-10-23 06:59:38 -04:00
|
|
|
for (name, composition) in [
|
2024-05-22 18:50:11 -04:00
|
|
|
Some((
|
2023-10-23 06:59:38 -04:00
|
|
|
match network {
|
|
|
|
|
NetworkId::Serai => unreachable!(),
|
|
|
|
|
NetworkId::Bitcoin => "bitcoin",
|
|
|
|
|
NetworkId::Ethereum => "ethereum",
|
|
|
|
|
NetworkId::Monero => "monero",
|
|
|
|
|
},
|
|
|
|
|
network_composition,
|
2024-05-22 18:50:11 -04:00
|
|
|
)),
|
|
|
|
|
Some(("message_queue", message_queue_composition)),
|
|
|
|
|
Some(("processor", processor_compositions.remove(0))),
|
|
|
|
|
processor_compositions.pop().map(|composition| ("relayer", composition)),
|
|
|
|
|
]
|
|
|
|
|
.into_iter()
|
|
|
|
|
.flatten()
|
|
|
|
|
{
|
2023-10-23 06:59:38 -04:00
|
|
|
let handle = format!("processor-{name}-{unique_id}");
|
2023-07-22 04:04:17 -04:00
|
|
|
compositions.push(
|
2023-10-23 06:59:38 -04:00
|
|
|
composition.set_start_policy(StartPolicy::Strict).set_handle(handle.clone()).set_log_options(
|
|
|
|
|
Some(LogOptions {
|
2023-07-23 10:13:11 -04:00
|
|
|
action: LogAction::Forward,
|
2023-10-23 06:59:38 -04:00
|
|
|
policy: if handle.contains("-processor-") {
|
|
|
|
|
LogPolicy::Always
|
|
|
|
|
} else {
|
|
|
|
|
LogPolicy::OnError
|
|
|
|
|
},
|
2023-07-23 10:13:11 -04:00
|
|
|
source: LogSource::Both,
|
2023-10-23 06:59:38 -04:00
|
|
|
}),
|
|
|
|
|
),
|
2023-07-21 14:01:58 -04:00
|
|
|
);
|
2023-10-23 06:59:38 -04:00
|
|
|
handles.push(handle);
|
2023-07-22 04:04:17 -04:00
|
|
|
}
|
|
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
let processor_composition = compositions.get_mut(2).unwrap();
|
2024-05-21 00:29:33 -04:00
|
|
|
processor_composition.inject_container_name(
|
|
|
|
|
network_hostname_override.unwrap_or_else(|| handles[0].clone()),
|
|
|
|
|
"NETWORK_RPC_HOSTNAME",
|
|
|
|
|
);
|
2024-05-22 18:50:11 -04:00
|
|
|
if let Some(hostname) = handles.get(3) {
|
|
|
|
|
processor_composition.inject_container_name(hostname, "ETHEREUM_RELAYER_HOSTNAME");
|
|
|
|
|
processor_composition.modify_env("ETHEREUM_RELAYER_PORT", "20830");
|
|
|
|
|
}
|
2023-10-23 06:59:38 -04:00
|
|
|
processor_composition.inject_container_name(handles[1].clone(), "MESSAGE_QUEUE_RPC");
|
2023-07-22 04:04:17 -04:00
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
(
|
|
|
|
|
(
|
|
|
|
|
handles[0].clone(),
|
|
|
|
|
handles[1].clone(),
|
|
|
|
|
handles[2].clone(),
|
|
|
|
|
handles.get(3).cloned().unwrap_or(String::new()),
|
|
|
|
|
),
|
|
|
|
|
coord_key,
|
|
|
|
|
compositions,
|
|
|
|
|
)
|
2023-07-21 14:01:58 -04:00
|
|
|
}
|
2023-07-22 04:04:17 -04:00
|
|
|
|
2023-07-24 20:06:05 -04:00
|
|
|
#[derive(serde::Deserialize, Debug)]
|
|
|
|
|
struct EmptyResponse {}
|
|
|
|
|
|
|
|
|
|
pub struct Coordinator {
|
|
|
|
|
network: NetworkId,
|
|
|
|
|
|
|
|
|
|
network_handle: String,
|
|
|
|
|
#[allow(unused)]
|
|
|
|
|
message_queue_handle: String,
|
|
|
|
|
#[allow(unused)]
|
|
|
|
|
processor_handle: String,
|
2024-05-22 18:50:11 -04:00
|
|
|
relayer_handle: String,
|
2023-07-24 20:06:05 -04:00
|
|
|
|
|
|
|
|
next_send_id: u64,
|
|
|
|
|
next_recv_id: u64,
|
|
|
|
|
queue: MessageQueue,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl Coordinator {
|
|
|
|
|
pub fn new(
|
|
|
|
|
network: NetworkId,
|
|
|
|
|
ops: &DockerOperations,
|
2024-05-22 18:50:11 -04:00
|
|
|
handles: Handles,
|
2023-07-24 20:06:05 -04:00
|
|
|
coord_key: <Ristretto as Ciphersuite>::F,
|
|
|
|
|
) -> Coordinator {
|
|
|
|
|
let rpc = ops.handle(&handles.1).host_port(2287).unwrap();
|
|
|
|
|
let rpc = rpc.0.to_string() + ":" + &rpc.1.to_string();
|
2023-07-31 00:13:58 -04:00
|
|
|
|
|
|
|
|
let res = Coordinator {
|
2023-07-24 20:06:05 -04:00
|
|
|
network,
|
|
|
|
|
|
|
|
|
|
network_handle: handles.0,
|
|
|
|
|
message_queue_handle: handles.1,
|
|
|
|
|
processor_handle: handles.2,
|
2024-05-22 18:50:11 -04:00
|
|
|
relayer_handle: handles.3,
|
2023-07-24 20:06:05 -04:00
|
|
|
|
|
|
|
|
next_send_id: 0,
|
|
|
|
|
next_recv_id: 0,
|
|
|
|
|
queue: MessageQueue::new(Service::Coordinator, rpc, Zeroizing::new(coord_key)),
|
2023-07-31 00:13:58 -04:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Sleep for up to a minute in case the external network's RPC has yet to start
|
|
|
|
|
|
|
|
|
|
// Gets an async handle to block on since this function plays nicer when it isn't itself async
|
|
|
|
|
{
|
|
|
|
|
let ops = ops.clone();
|
|
|
|
|
let network_handle = res.network_handle.clone();
|
|
|
|
|
std::thread::spawn(move || {
|
|
|
|
|
let runtime = tokio::runtime::Runtime::new().unwrap();
|
|
|
|
|
let handle = runtime.handle();
|
|
|
|
|
let _async = handle.enter();
|
|
|
|
|
|
|
|
|
|
let rpc_url = network_rpc(network, &ops, &network_handle);
|
|
|
|
|
let mut iters = 0;
|
|
|
|
|
while iters < 60 {
|
|
|
|
|
match network {
|
|
|
|
|
NetworkId::Bitcoin => {
|
|
|
|
|
use bitcoin_serai::rpc::Rpc;
|
|
|
|
|
|
|
|
|
|
// Bitcoin's Rpc::new will test the connection
|
|
|
|
|
if handle.block_on(Rpc::new(rpc_url.clone())).is_ok() {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
2024-05-14 01:33:55 -04:00
|
|
|
NetworkId::Ethereum => {
|
2024-05-21 00:29:33 -04:00
|
|
|
use std::sync::Arc;
|
|
|
|
|
use ethereum_serai::{
|
|
|
|
|
alloy::{
|
|
|
|
|
simple_request_transport::SimpleRequest,
|
|
|
|
|
rpc_client::ClientBuilder,
|
|
|
|
|
provider::{Provider, RootProvider},
|
|
|
|
|
network::Ethereum,
|
|
|
|
|
},
|
|
|
|
|
deployer::Deployer,
|
2024-05-14 01:33:55 -04:00
|
|
|
};
|
|
|
|
|
|
2024-05-21 00:29:33 -04:00
|
|
|
let provider = Arc::new(RootProvider::<_, Ethereum>::new(
|
2024-05-14 01:33:55 -04:00
|
|
|
ClientBuilder::default().transport(SimpleRequest::new(rpc_url.clone()), true),
|
2024-05-21 00:29:33 -04:00
|
|
|
));
|
|
|
|
|
|
|
|
|
|
if handle
|
|
|
|
|
.block_on(provider.raw_request::<_, ()>("evm_setAutomine".into(), [false]))
|
|
|
|
|
.is_ok()
|
|
|
|
|
{
|
|
|
|
|
handle.block_on(async {
|
|
|
|
|
// Deploy the deployer
|
|
|
|
|
let tx = Deployer::deployment_tx();
|
|
|
|
|
let signer = tx.recover_signer().unwrap();
|
|
|
|
|
let (tx, sig, _) = tx.into_parts();
|
|
|
|
|
|
|
|
|
|
provider
|
|
|
|
|
.raw_request::<_, ()>(
|
|
|
|
|
"anvil_setBalance".into(),
|
|
|
|
|
[signer.to_string(), (tx.gas_limit * tx.gas_price).to_string()],
|
|
|
|
|
)
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
|
|
|
|
|
|
|
|
|
let mut bytes = vec![];
|
|
|
|
|
tx.encode_with_signature_fields(&sig, &mut bytes);
|
|
|
|
|
let _ = provider.send_raw_transaction(&bytes).await.unwrap();
|
|
|
|
|
|
|
|
|
|
provider.raw_request::<_, ()>("anvil_mine".into(), [96]).await.unwrap();
|
|
|
|
|
|
|
|
|
|
let _ = Deployer::new(provider.clone()).await.unwrap().unwrap();
|
|
|
|
|
|
|
|
|
|
// Sleep until the actual time is ahead of whatever time is in the epoch we just
|
|
|
|
|
// mined
|
|
|
|
|
tokio::time::sleep(core::time::Duration::from_secs(30)).await;
|
|
|
|
|
});
|
|
|
|
|
break;
|
2024-05-14 01:33:55 -04:00
|
|
|
}
|
|
|
|
|
}
|
2023-07-31 00:13:58 -04:00
|
|
|
NetworkId::Monero => {
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
use monero_simple_request_rpc::SimpleRequestRpc;
|
|
|
|
|
use monero_wallet::rpc::Rpc;
|
2023-07-31 00:13:58 -04:00
|
|
|
|
|
|
|
|
// Monero's won't, so call get_height
|
2023-11-06 23:45:39 -05:00
|
|
|
if handle
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
.block_on(SimpleRequestRpc::new(rpc_url.clone()))
|
2023-07-31 00:13:58 -04:00
|
|
|
.ok()
|
|
|
|
|
.and_then(|rpc| handle.block_on(rpc.get_height()).ok())
|
|
|
|
|
.is_some()
|
|
|
|
|
{
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
NetworkId::Serai => panic!("processor is booting with external network of Serai"),
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
println!("external network RPC has yet to boot, waiting 1 sec, attempt {iters}");
|
|
|
|
|
handle.block_on(tokio::time::sleep(core::time::Duration::from_secs(1)));
|
|
|
|
|
iters += 1;
|
|
|
|
|
}
|
|
|
|
|
if iters == 60 {
|
|
|
|
|
panic!("couldn't connect to external network {network:?} after 60s");
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
.join()
|
|
|
|
|
.unwrap();
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
2023-07-31 00:13:58 -04:00
|
|
|
|
|
|
|
|
res
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Send a message to a processor as its coordinator.
|
2023-07-25 18:09:23 -04:00
|
|
|
pub async fn send_message(&mut self, msg: impl Into<CoordinatorMessage>) {
|
|
|
|
|
let msg: CoordinatorMessage = msg.into();
|
2023-07-24 20:06:05 -04:00
|
|
|
self
|
|
|
|
|
.queue
|
|
|
|
|
.queue(
|
|
|
|
|
Metadata {
|
|
|
|
|
from: Service::Coordinator,
|
|
|
|
|
to: Service::Processor(self.network),
|
2023-07-25 18:09:23 -04:00
|
|
|
intent: msg.intent(),
|
2023-07-24 20:06:05 -04:00
|
|
|
},
|
2023-11-25 04:01:11 -05:00
|
|
|
borsh::to_vec(&msg).unwrap(),
|
2023-07-24 20:06:05 -04:00
|
|
|
)
|
|
|
|
|
.await;
|
|
|
|
|
self.next_send_id += 1;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Receive a message from a processor as its coordinator.
|
|
|
|
|
pub async fn recv_message(&mut self) -> ProcessorMessage {
|
2023-09-27 12:20:57 -04:00
|
|
|
let msg = tokio::time::timeout(
|
2023-11-25 04:09:07 -05:00
|
|
|
core::time::Duration::from_secs(20),
|
2023-09-27 12:20:57 -04:00
|
|
|
self.queue.next(Service::Processor(self.network)),
|
|
|
|
|
)
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
2023-07-24 20:06:05 -04:00
|
|
|
assert_eq!(msg.from, Service::Processor(self.network));
|
|
|
|
|
assert_eq!(msg.id, self.next_recv_id);
|
2023-09-27 12:20:57 -04:00
|
|
|
self.queue.ack(Service::Processor(self.network), msg.id).await;
|
2023-07-24 20:06:05 -04:00
|
|
|
self.next_recv_id += 1;
|
2023-11-25 04:01:11 -05:00
|
|
|
borsh::from_slice(&msg.msg).unwrap()
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
|
|
|
|
|
2023-07-25 18:09:23 -04:00
|
|
|
pub async fn add_block(&self, ops: &DockerOperations) -> ([u8; 32], Vec<u8>) {
|
2023-07-24 20:06:05 -04:00
|
|
|
let rpc_url = network_rpc(self.network, ops, &self.network_handle);
|
|
|
|
|
match self.network {
|
|
|
|
|
NetworkId::Bitcoin => {
|
|
|
|
|
use bitcoin_serai::{
|
2023-10-30 04:45:20 -04:00
|
|
|
bitcoin::{consensus::Encodable, network::Network, Script, Address},
|
2023-07-24 20:06:05 -04:00
|
|
|
rpc::Rpc,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Mine a block
|
|
|
|
|
let rpc = Rpc::new(rpc_url).await.expect("couldn't connect to the Bitcoin RPC");
|
|
|
|
|
rpc
|
|
|
|
|
.rpc_call::<Vec<String>>(
|
|
|
|
|
"generatetoaddress",
|
2023-10-30 04:45:20 -04:00
|
|
|
serde_json::json!([1, Address::p2sh(Script::new(), Network::Regtest).unwrap()]),
|
2023-07-24 20:06:05 -04:00
|
|
|
)
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
|
|
|
|
|
2023-07-25 18:09:23 -04:00
|
|
|
// Get it so we can return it
|
|
|
|
|
let hash = rpc.get_block_hash(rpc.get_latest_block_number().await.unwrap()).await.unwrap();
|
|
|
|
|
let block = rpc.get_block(&hash).await.unwrap();
|
2023-07-24 20:06:05 -04:00
|
|
|
let mut block_buf = vec![];
|
|
|
|
|
block.consensus_encode(&mut block_buf).unwrap();
|
2023-07-25 18:09:23 -04:00
|
|
|
(hash, block_buf)
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
2024-05-14 01:33:55 -04:00
|
|
|
NetworkId::Ethereum => {
|
2024-05-14 01:42:18 -04:00
|
|
|
use ethereum_serai::alloy::{
|
|
|
|
|
simple_request_transport::SimpleRequest,
|
2024-06-13 15:57:08 -04:00
|
|
|
rpc_types::{BlockTransactionsKind, BlockNumberOrTag},
|
2024-05-14 01:42:18 -04:00
|
|
|
rpc_client::ClientBuilder,
|
|
|
|
|
provider::{Provider, RootProvider},
|
|
|
|
|
network::Ethereum,
|
2024-05-14 01:33:55 -04:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let provider = RootProvider::<_, Ethereum>::new(
|
|
|
|
|
ClientBuilder::default().transport(SimpleRequest::new(rpc_url.clone()), true),
|
|
|
|
|
);
|
|
|
|
|
let start = provider
|
2024-06-13 15:57:08 -04:00
|
|
|
.get_block(BlockNumberOrTag::Latest.into(), BlockTransactionsKind::Hashes)
|
2024-05-14 01:33:55 -04:00
|
|
|
.await
|
|
|
|
|
.unwrap()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.header
|
|
|
|
|
.number
|
|
|
|
|
.unwrap();
|
|
|
|
|
// We mine 96 blocks to mine one epoch, then cause its finalization
|
|
|
|
|
provider.raw_request::<_, ()>("anvil_mine".into(), [96]).await.unwrap();
|
|
|
|
|
let end_of_epoch = start + 31;
|
|
|
|
|
let hash = provider
|
2024-06-13 15:57:08 -04:00
|
|
|
.get_block(BlockNumberOrTag::Number(end_of_epoch).into(), BlockTransactionsKind::Hashes)
|
2024-05-14 01:33:55 -04:00
|
|
|
.await
|
|
|
|
|
.unwrap()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.header
|
|
|
|
|
.hash
|
|
|
|
|
.unwrap();
|
|
|
|
|
|
|
|
|
|
let state = provider
|
|
|
|
|
.raw_request::<_, String>("anvil_dumpState".into(), ())
|
|
|
|
|
.await
|
|
|
|
|
.unwrap()
|
|
|
|
|
.into_bytes();
|
|
|
|
|
(hash.into(), state)
|
|
|
|
|
}
|
2023-07-24 20:06:05 -04:00
|
|
|
NetworkId::Monero => {
|
|
|
|
|
use curve25519_dalek::{constants::ED25519_BASEPOINT_POINT, scalar::Scalar};
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
use monero_simple_request_rpc::SimpleRequestRpc;
|
|
|
|
|
use monero_wallet::{rpc::Rpc, address::Network, ViewPair};
|
2023-07-24 20:06:05 -04:00
|
|
|
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
let rpc = SimpleRequestRpc::new(rpc_url).await.expect("couldn't connect to the Monero RPC");
|
|
|
|
|
rpc
|
|
|
|
|
.generate_blocks(
|
|
|
|
|
&ViewPair::new(ED25519_BASEPOINT_POINT, Zeroizing::new(Scalar::ONE))
|
|
|
|
|
.unwrap()
|
|
|
|
|
.legacy_address(Network::Mainnet),
|
|
|
|
|
1,
|
2023-07-24 20:06:05 -04:00
|
|
|
)
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
2023-07-25 18:09:23 -04:00
|
|
|
let hash = rpc.get_block_hash(rpc.get_height().await.unwrap() - 1).await.unwrap();
|
|
|
|
|
(hash, rpc.get_block(hash).await.unwrap().serialize())
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
|
|
|
|
NetworkId::Serai => panic!("processor tests adding block to Serai"),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
pub async fn sync(&self, ops: &DockerOperations, others: &[Coordinator]) {
|
|
|
|
|
let rpc_url = network_rpc(self.network, ops, &self.network_handle);
|
|
|
|
|
match self.network {
|
|
|
|
|
NetworkId::Bitcoin => {
|
|
|
|
|
use bitcoin_serai::{bitcoin::consensus::Encodable, rpc::Rpc};
|
|
|
|
|
|
|
|
|
|
let rpc = Rpc::new(rpc_url).await.expect("couldn't connect to the Bitcoin RPC");
|
|
|
|
|
let to = rpc.get_latest_block_number().await.unwrap();
|
|
|
|
|
for coordinator in others {
|
2024-05-21 00:29:33 -04:00
|
|
|
let other_rpc = Rpc::new(network_rpc(self.network, ops, &coordinator.network_handle))
|
|
|
|
|
.await
|
|
|
|
|
.expect("couldn't connect to the Bitcoin RPC");
|
|
|
|
|
let from = other_rpc.get_latest_block_number().await.unwrap() + 1;
|
2024-05-14 01:33:55 -04:00
|
|
|
|
2023-07-24 20:06:05 -04:00
|
|
|
for b in from ..= to {
|
|
|
|
|
let mut buf = vec![];
|
|
|
|
|
rpc
|
|
|
|
|
.get_block(&rpc.get_block_hash(b).await.unwrap())
|
|
|
|
|
.await
|
|
|
|
|
.unwrap()
|
|
|
|
|
.consensus_encode(&mut buf)
|
|
|
|
|
.unwrap();
|
2024-05-14 01:33:55 -04:00
|
|
|
|
2024-05-21 00:29:33 -04:00
|
|
|
let res: Option<String> = other_rpc
|
|
|
|
|
.rpc_call("submitblock", serde_json::json!([hex::encode(buf)]))
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
2024-05-14 01:33:55 -04:00
|
|
|
if let Some(err) = res {
|
|
|
|
|
panic!("submitblock failed: {err}");
|
|
|
|
|
}
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2024-05-14 01:33:55 -04:00
|
|
|
NetworkId::Ethereum => {
|
2024-05-14 01:42:18 -04:00
|
|
|
use ethereum_serai::alloy::{
|
|
|
|
|
simple_request_transport::SimpleRequest,
|
2024-06-13 15:57:08 -04:00
|
|
|
rpc_types::{BlockTransactionsKind, BlockNumberOrTag},
|
2024-05-14 01:42:18 -04:00
|
|
|
rpc_client::ClientBuilder,
|
|
|
|
|
provider::{Provider, RootProvider},
|
|
|
|
|
network::Ethereum,
|
2024-05-14 01:33:55 -04:00
|
|
|
};
|
|
|
|
|
|
2024-05-21 00:29:33 -04:00
|
|
|
let (expected_number, state) = {
|
|
|
|
|
let provider = RootProvider::<_, Ethereum>::new(
|
|
|
|
|
ClientBuilder::default().transport(SimpleRequest::new(rpc_url.clone()), true),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
let expected_number = provider
|
2024-06-13 15:57:08 -04:00
|
|
|
.get_block(BlockNumberOrTag::Latest.into(), BlockTransactionsKind::Hashes)
|
2024-05-21 00:29:33 -04:00
|
|
|
.await
|
|
|
|
|
.unwrap()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.header
|
|
|
|
|
.number;
|
|
|
|
|
(
|
|
|
|
|
expected_number,
|
|
|
|
|
provider.raw_request::<_, String>("anvil_dumpState".into(), ()).await.unwrap(),
|
|
|
|
|
)
|
|
|
|
|
};
|
2024-05-14 01:33:55 -04:00
|
|
|
|
|
|
|
|
for coordinator in others {
|
|
|
|
|
let rpc_url = network_rpc(coordinator.network, ops, &coordinator.network_handle);
|
|
|
|
|
let provider = RootProvider::<_, Ethereum>::new(
|
|
|
|
|
ClientBuilder::default().transport(SimpleRequest::new(rpc_url.clone()), true),
|
|
|
|
|
);
|
2024-05-21 00:29:33 -04:00
|
|
|
assert!(provider
|
|
|
|
|
.raw_request::<_, bool>("anvil_loadState".into(), &[&state])
|
|
|
|
|
.await
|
|
|
|
|
.unwrap());
|
|
|
|
|
|
|
|
|
|
let new_number = provider
|
2024-06-13 15:57:08 -04:00
|
|
|
.get_block(BlockNumberOrTag::Latest.into(), BlockTransactionsKind::Hashes)
|
2024-05-21 00:29:33 -04:00
|
|
|
.await
|
|
|
|
|
.unwrap()
|
|
|
|
|
.unwrap()
|
|
|
|
|
.header
|
|
|
|
|
.number;
|
|
|
|
|
|
|
|
|
|
// TODO: https://github.com/foundry-rs/foundry/issues/7955
|
|
|
|
|
let _ = expected_number;
|
|
|
|
|
let _ = new_number;
|
|
|
|
|
//assert_eq!(expected_number, new_number);
|
2024-05-14 01:33:55 -04:00
|
|
|
}
|
|
|
|
|
}
|
2023-07-24 20:06:05 -04:00
|
|
|
NetworkId::Monero => {
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
use monero_simple_request_rpc::SimpleRequestRpc;
|
|
|
|
|
use monero_wallet::rpc::Rpc;
|
2023-07-24 20:06:05 -04:00
|
|
|
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
let rpc = SimpleRequestRpc::new(rpc_url).await.expect("couldn't connect to the Monero RPC");
|
2023-07-24 20:06:05 -04:00
|
|
|
let to = rpc.get_height().await.unwrap();
|
|
|
|
|
for coordinator in others {
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
let other_rpc = SimpleRequestRpc::new(network_rpc(
|
|
|
|
|
coordinator.network,
|
|
|
|
|
ops,
|
|
|
|
|
&coordinator.network_handle,
|
|
|
|
|
))
|
|
|
|
|
.await
|
|
|
|
|
.expect("couldn't connect to the Monero RPC");
|
2024-05-21 00:29:33 -04:00
|
|
|
|
|
|
|
|
let from = other_rpc.get_height().await.unwrap();
|
2023-07-24 20:06:05 -04:00
|
|
|
for b in from .. to {
|
2024-05-14 01:33:55 -04:00
|
|
|
let block =
|
|
|
|
|
rpc.get_block(rpc.get_block_hash(b).await.unwrap()).await.unwrap().serialize();
|
|
|
|
|
|
2024-05-21 00:29:33 -04:00
|
|
|
let res: serde_json::Value = other_rpc
|
2024-05-14 01:33:55 -04:00
|
|
|
.json_rpc_call("submit_block", Some(serde_json::json!([hex::encode(block)])))
|
|
|
|
|
.await
|
|
|
|
|
.unwrap();
|
|
|
|
|
let err = res.get("error");
|
|
|
|
|
if err.is_some() && (err.unwrap() != &serde_json::Value::Null) {
|
|
|
|
|
panic!("failed to submit Monero block: {res}");
|
|
|
|
|
}
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
NetworkId::Serai => panic!("processors tests syncing Serai nodes"),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
pub async fn publish_transaction(&self, ops: &DockerOperations, tx: &[u8]) {
|
2023-07-24 20:06:05 -04:00
|
|
|
let rpc_url = network_rpc(self.network, ops, &self.network_handle);
|
|
|
|
|
match self.network {
|
|
|
|
|
NetworkId::Bitcoin => {
|
2023-07-30 07:00:54 -04:00
|
|
|
use bitcoin_serai::{
|
|
|
|
|
bitcoin::{consensus::Decodable, Transaction},
|
|
|
|
|
rpc::Rpc,
|
|
|
|
|
};
|
2023-07-24 20:06:05 -04:00
|
|
|
|
|
|
|
|
let rpc =
|
|
|
|
|
Rpc::new(rpc_url).await.expect("couldn't connect to the coordinator's Bitcoin RPC");
|
2023-07-30 07:00:54 -04:00
|
|
|
rpc.send_raw_transaction(&Transaction::consensus_decode(&mut &*tx).unwrap()).await.unwrap();
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|
2024-05-14 01:33:55 -04:00
|
|
|
NetworkId::Ethereum => {
|
2024-05-14 01:42:18 -04:00
|
|
|
use ethereum_serai::alloy::{
|
|
|
|
|
simple_request_transport::SimpleRequest,
|
|
|
|
|
rpc_client::ClientBuilder,
|
|
|
|
|
provider::{Provider, RootProvider},
|
|
|
|
|
network::Ethereum,
|
2024-05-14 01:33:55 -04:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let provider = RootProvider::<_, Ethereum>::new(
|
|
|
|
|
ClientBuilder::default().transport(SimpleRequest::new(rpc_url.clone()), true),
|
|
|
|
|
);
|
|
|
|
|
let _ = provider.send_raw_transaction(tx).await.unwrap();
|
|
|
|
|
}
|
2023-07-24 20:06:05 -04:00
|
|
|
NetworkId::Monero => {
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
use monero_simple_request_rpc::SimpleRequestRpc;
|
|
|
|
|
use monero_wallet::{transaction::Transaction, rpc::Rpc};
|
2023-07-24 20:06:05 -04:00
|
|
|
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
let rpc = SimpleRequestRpc::new(rpc_url)
|
|
|
|
|
.await
|
|
|
|
|
.expect("couldn't connect to the coordinator's Monero RPC");
|
2023-07-24 20:06:05 -04:00
|
|
|
rpc.publish_transaction(&Transaction::read(&mut &*tx).unwrap()).await.unwrap();
|
|
|
|
|
}
|
|
|
|
|
NetworkId::Serai => panic!("processor tests broadcasting block to Serai"),
|
|
|
|
|
}
|
|
|
|
|
}
|
2023-07-30 07:00:54 -04:00
|
|
|
|
2024-05-22 18:50:11 -04:00
|
|
|
pub async fn publish_eventuality_completion(&self, ops: &DockerOperations, tx: &[u8]) {
|
|
|
|
|
match self.network {
|
|
|
|
|
NetworkId::Bitcoin | NetworkId::Monero => self.publish_transaction(ops, tx).await,
|
|
|
|
|
NetworkId::Ethereum => (),
|
|
|
|
|
NetworkId::Serai => panic!("processor tests broadcasting block to Serai"),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
Ethereum Integration (#557)
* Clean up Ethereum
* Consistent contract address for deployed contracts
* Flesh out Router a bit
* Add a Deployer for DoS-less deployment
* Implement Router-finding
* Use CREATE2 helper present in ethers
* Move from CREATE2 to CREATE
Bit more streamlined for our use case.
* Document ethereum-serai
* Tidy tests a bit
* Test updateSeraiKey
* Use encodePacked for updateSeraiKey
* Take in the block hash to read state during
* Add a Sandbox contract to the Ethereum integration
* Add retrieval of transfers from Ethereum
* Add inInstruction function to the Router
* Augment our handling of InInstructions events with a check the transfer event also exists
* Have the Deployer error upon failed deployments
* Add --via-ir
* Make get_transaction test-only
We only used it to get transactions to confirm the resolution of Eventualities.
Eventualities need to be modularized. By introducing the dedicated
confirm_completion function, we remove the need for a non-test get_transaction
AND begin this modularization (by no longer explicitly grabbing a transaction
to check with).
* Modularize Eventuality
Almost fully-deprecates the Transaction trait for Completion. Replaces
Transaction ID with Claim.
* Modularize the Scheduler behind a trait
* Add an extremely basic account Scheduler
* Add nonce uses, key rotation to the account scheduler
* Only report the account Scheduler empty after transferring keys
Also ban payments to the branch/change/forward addresses.
* Make fns reliant on state test-only
* Start of an Ethereum integration for the processor
* Add a session to the Router to prevent updateSeraiKey replaying
This would only happen if an old key was rotated to again, which would require
n-of-n collusion (already ridiculous and a valid fault attributable event). It
just clarifies the formal arguments.
* Add a RouterCommand + SignMachine for producing it to coins/ethereum
* Ethereum which compiles
* Have branch/change/forward return an option
Also defines a UtxoNetwork extension trait for MAX_INPUTS.
* Make external_address exclusively a test fn
* Move the "account" scheduler to "smart contract"
* Remove ABI artifact
* Move refund/forward Plan creation into the Processor
We create forward Plans in the scan path, and need to know their exact fees in
the scan path. This requires adding a somewhat wonky shim_forward_plan method
so we can obtain a Plan equivalent to the actual forward Plan for fee reasons,
yet don't expect it to be the actual forward Plan (which may be distinct if
the Plan pulls from the global state, such as with a nonce).
Also properly types a Scheduler addendum such that the SC scheduler isn't
cramming the nonce to use into the N::Output type.
* Flesh out the Ethereum integration more
* Two commits ago, into the **Scheduler, not Processor
* Remove misc TODOs in SC Scheduler
* Add constructor to RouterCommandMachine
* RouterCommand read, pairing with the prior added write
* Further add serialization methods
* Have the Router's key included with the InInstruction
This does not use the key at the time of the event. This uses the key at the
end of the block for the event. Its much simpler than getting the full event
streams for each, checking when they interlace.
This does not read the state. Every block, this makes a request for every
single key update and simply chooses the last one. This allows pruning state,
only keeping the event tree. Ideally, we'd also introduce a cache to reduce the
cost of the filter (small in events yielded, long in blocks searched).
Since Serai doesn't have any forwarding TXs, nor Branches, nor change, all of
our Plans should solely have payments out, and there's no expectation of a Plan
being made under one key broken by it being received by another key.
* Add read/write to InInstruction
* Abstract the ABI for Call/OutInstruction in ethereum-serai
* Fill out signable_transaction for Ethereum
* Move ethereum-serai to alloy
Resolves #331.
* Use the opaque sol macro instead of generated files
* Move the processor over to the now-alloy-based ethereum-serai
* Use the ecrecover provided by alloy
* Have the SC use nonce for rotation, not session (an independent nonce which wasn't synchronized)
* Always use the latest keys for SC scheduled plans
* get_eventuality_completions for Ethereum
* Finish fleshing out the processor Ethereum integration as needed for serai-processor tests
This doesn't not support any actual deployments, not even the ones simulated by
serai-processor-docker-tests.
* Add alloy-simple-request-transport to the GH workflows
* cargo update
* Clarify a few comments and make one check more robust
* Use a string for 27.0 in .github
* Remove optional from no-longer-optional dependencies in processor
* Add alloy to git deny exception
* Fix no longer optional specification in processor's binaries feature
* Use a version of foundry from 2024
* Correct fetching Bitcoin TXs in the processor docker tests
* Update rustls to resolve RUSTSEC warnings
* Use the monthly nightly foundry, not the deleted daily nightly
2024-04-21 06:02:12 -04:00
|
|
|
pub async fn get_published_transaction(
|
|
|
|
|
&self,
|
|
|
|
|
ops: &DockerOperations,
|
|
|
|
|
tx: &[u8],
|
|
|
|
|
) -> Option<Vec<u8>> {
|
2023-07-30 07:00:54 -04:00
|
|
|
let rpc_url = network_rpc(self.network, ops, &self.network_handle);
|
|
|
|
|
match self.network {
|
|
|
|
|
NetworkId::Bitcoin => {
|
|
|
|
|
use bitcoin_serai::{bitcoin::consensus::Encodable, rpc::Rpc};
|
|
|
|
|
|
|
|
|
|
let rpc =
|
|
|
|
|
Rpc::new(rpc_url).await.expect("couldn't connect to the coordinator's Bitcoin RPC");
|
Ethereum Integration (#557)
* Clean up Ethereum
* Consistent contract address for deployed contracts
* Flesh out Router a bit
* Add a Deployer for DoS-less deployment
* Implement Router-finding
* Use CREATE2 helper present in ethers
* Move from CREATE2 to CREATE
Bit more streamlined for our use case.
* Document ethereum-serai
* Tidy tests a bit
* Test updateSeraiKey
* Use encodePacked for updateSeraiKey
* Take in the block hash to read state during
* Add a Sandbox contract to the Ethereum integration
* Add retrieval of transfers from Ethereum
* Add inInstruction function to the Router
* Augment our handling of InInstructions events with a check the transfer event also exists
* Have the Deployer error upon failed deployments
* Add --via-ir
* Make get_transaction test-only
We only used it to get transactions to confirm the resolution of Eventualities.
Eventualities need to be modularized. By introducing the dedicated
confirm_completion function, we remove the need for a non-test get_transaction
AND begin this modularization (by no longer explicitly grabbing a transaction
to check with).
* Modularize Eventuality
Almost fully-deprecates the Transaction trait for Completion. Replaces
Transaction ID with Claim.
* Modularize the Scheduler behind a trait
* Add an extremely basic account Scheduler
* Add nonce uses, key rotation to the account scheduler
* Only report the account Scheduler empty after transferring keys
Also ban payments to the branch/change/forward addresses.
* Make fns reliant on state test-only
* Start of an Ethereum integration for the processor
* Add a session to the Router to prevent updateSeraiKey replaying
This would only happen if an old key was rotated to again, which would require
n-of-n collusion (already ridiculous and a valid fault attributable event). It
just clarifies the formal arguments.
* Add a RouterCommand + SignMachine for producing it to coins/ethereum
* Ethereum which compiles
* Have branch/change/forward return an option
Also defines a UtxoNetwork extension trait for MAX_INPUTS.
* Make external_address exclusively a test fn
* Move the "account" scheduler to "smart contract"
* Remove ABI artifact
* Move refund/forward Plan creation into the Processor
We create forward Plans in the scan path, and need to know their exact fees in
the scan path. This requires adding a somewhat wonky shim_forward_plan method
so we can obtain a Plan equivalent to the actual forward Plan for fee reasons,
yet don't expect it to be the actual forward Plan (which may be distinct if
the Plan pulls from the global state, such as with a nonce).
Also properly types a Scheduler addendum such that the SC scheduler isn't
cramming the nonce to use into the N::Output type.
* Flesh out the Ethereum integration more
* Two commits ago, into the **Scheduler, not Processor
* Remove misc TODOs in SC Scheduler
* Add constructor to RouterCommandMachine
* RouterCommand read, pairing with the prior added write
* Further add serialization methods
* Have the Router's key included with the InInstruction
This does not use the key at the time of the event. This uses the key at the
end of the block for the event. Its much simpler than getting the full event
streams for each, checking when they interlace.
This does not read the state. Every block, this makes a request for every
single key update and simply chooses the last one. This allows pruning state,
only keeping the event tree. Ideally, we'd also introduce a cache to reduce the
cost of the filter (small in events yielded, long in blocks searched).
Since Serai doesn't have any forwarding TXs, nor Branches, nor change, all of
our Plans should solely have payments out, and there's no expectation of a Plan
being made under one key broken by it being received by another key.
* Add read/write to InInstruction
* Abstract the ABI for Call/OutInstruction in ethereum-serai
* Fill out signable_transaction for Ethereum
* Move ethereum-serai to alloy
Resolves #331.
* Use the opaque sol macro instead of generated files
* Move the processor over to the now-alloy-based ethereum-serai
* Use the ecrecover provided by alloy
* Have the SC use nonce for rotation, not session (an independent nonce which wasn't synchronized)
* Always use the latest keys for SC scheduled plans
* get_eventuality_completions for Ethereum
* Finish fleshing out the processor Ethereum integration as needed for serai-processor tests
This doesn't not support any actual deployments, not even the ones simulated by
serai-processor-docker-tests.
* Add alloy-simple-request-transport to the GH workflows
* cargo update
* Clarify a few comments and make one check more robust
* Use a string for 27.0 in .github
* Remove optional from no-longer-optional dependencies in processor
* Add alloy to git deny exception
* Fix no longer optional specification in processor's binaries feature
* Use a version of foundry from 2024
* Correct fetching Bitcoin TXs in the processor docker tests
* Update rustls to resolve RUSTSEC warnings
* Use the monthly nightly foundry, not the deleted daily nightly
2024-04-21 06:02:12 -04:00
|
|
|
|
|
|
|
|
// Bitcoin publishes a 0-byte TX ID to reduce variables
|
|
|
|
|
// Accordingly, read the mempool to find the (presumed relevant) TX
|
|
|
|
|
let entries: Vec<String> =
|
|
|
|
|
rpc.rpc_call("getrawmempool", serde_json::json!([false])).await.unwrap();
|
|
|
|
|
assert_eq!(entries.len(), 1, "more than one entry in the mempool, so unclear which to get");
|
|
|
|
|
|
2023-07-30 07:00:54 -04:00
|
|
|
let mut hash = [0; 32];
|
Ethereum Integration (#557)
* Clean up Ethereum
* Consistent contract address for deployed contracts
* Flesh out Router a bit
* Add a Deployer for DoS-less deployment
* Implement Router-finding
* Use CREATE2 helper present in ethers
* Move from CREATE2 to CREATE
Bit more streamlined for our use case.
* Document ethereum-serai
* Tidy tests a bit
* Test updateSeraiKey
* Use encodePacked for updateSeraiKey
* Take in the block hash to read state during
* Add a Sandbox contract to the Ethereum integration
* Add retrieval of transfers from Ethereum
* Add inInstruction function to the Router
* Augment our handling of InInstructions events with a check the transfer event also exists
* Have the Deployer error upon failed deployments
* Add --via-ir
* Make get_transaction test-only
We only used it to get transactions to confirm the resolution of Eventualities.
Eventualities need to be modularized. By introducing the dedicated
confirm_completion function, we remove the need for a non-test get_transaction
AND begin this modularization (by no longer explicitly grabbing a transaction
to check with).
* Modularize Eventuality
Almost fully-deprecates the Transaction trait for Completion. Replaces
Transaction ID with Claim.
* Modularize the Scheduler behind a trait
* Add an extremely basic account Scheduler
* Add nonce uses, key rotation to the account scheduler
* Only report the account Scheduler empty after transferring keys
Also ban payments to the branch/change/forward addresses.
* Make fns reliant on state test-only
* Start of an Ethereum integration for the processor
* Add a session to the Router to prevent updateSeraiKey replaying
This would only happen if an old key was rotated to again, which would require
n-of-n collusion (already ridiculous and a valid fault attributable event). It
just clarifies the formal arguments.
* Add a RouterCommand + SignMachine for producing it to coins/ethereum
* Ethereum which compiles
* Have branch/change/forward return an option
Also defines a UtxoNetwork extension trait for MAX_INPUTS.
* Make external_address exclusively a test fn
* Move the "account" scheduler to "smart contract"
* Remove ABI artifact
* Move refund/forward Plan creation into the Processor
We create forward Plans in the scan path, and need to know their exact fees in
the scan path. This requires adding a somewhat wonky shim_forward_plan method
so we can obtain a Plan equivalent to the actual forward Plan for fee reasons,
yet don't expect it to be the actual forward Plan (which may be distinct if
the Plan pulls from the global state, such as with a nonce).
Also properly types a Scheduler addendum such that the SC scheduler isn't
cramming the nonce to use into the N::Output type.
* Flesh out the Ethereum integration more
* Two commits ago, into the **Scheduler, not Processor
* Remove misc TODOs in SC Scheduler
* Add constructor to RouterCommandMachine
* RouterCommand read, pairing with the prior added write
* Further add serialization methods
* Have the Router's key included with the InInstruction
This does not use the key at the time of the event. This uses the key at the
end of the block for the event. Its much simpler than getting the full event
streams for each, checking when they interlace.
This does not read the state. Every block, this makes a request for every
single key update and simply chooses the last one. This allows pruning state,
only keeping the event tree. Ideally, we'd also introduce a cache to reduce the
cost of the filter (small in events yielded, long in blocks searched).
Since Serai doesn't have any forwarding TXs, nor Branches, nor change, all of
our Plans should solely have payments out, and there's no expectation of a Plan
being made under one key broken by it being received by another key.
* Add read/write to InInstruction
* Abstract the ABI for Call/OutInstruction in ethereum-serai
* Fill out signable_transaction for Ethereum
* Move ethereum-serai to alloy
Resolves #331.
* Use the opaque sol macro instead of generated files
* Move the processor over to the now-alloy-based ethereum-serai
* Use the ecrecover provided by alloy
* Have the SC use nonce for rotation, not session (an independent nonce which wasn't synchronized)
* Always use the latest keys for SC scheduled plans
* get_eventuality_completions for Ethereum
* Finish fleshing out the processor Ethereum integration as needed for serai-processor tests
This doesn't not support any actual deployments, not even the ones simulated by
serai-processor-docker-tests.
* Add alloy-simple-request-transport to the GH workflows
* cargo update
* Clarify a few comments and make one check more robust
* Use a string for 27.0 in .github
* Remove optional from no-longer-optional dependencies in processor
* Add alloy to git deny exception
* Fix no longer optional specification in processor's binaries feature
* Use a version of foundry from 2024
* Correct fetching Bitcoin TXs in the processor docker tests
* Update rustls to resolve RUSTSEC warnings
* Use the monthly nightly foundry, not the deleted daily nightly
2024-04-21 06:02:12 -04:00
|
|
|
hash.copy_from_slice(&hex::decode(&entries[0]).unwrap());
|
2023-07-30 07:00:54 -04:00
|
|
|
if let Ok(tx) = rpc.get_transaction(&hash).await {
|
|
|
|
|
let mut buf = vec![];
|
|
|
|
|
tx.consensus_encode(&mut buf).unwrap();
|
|
|
|
|
Some(buf)
|
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
2024-05-14 01:33:55 -04:00
|
|
|
NetworkId::Ethereum => {
|
2024-05-22 18:50:11 -04:00
|
|
|
/*
|
2024-05-14 01:33:55 -04:00
|
|
|
let provider = RootProvider::<_, Ethereum>::new(
|
|
|
|
|
ClientBuilder::default().transport(SimpleRequest::new(rpc_url.clone()), true),
|
|
|
|
|
);
|
|
|
|
|
let mut hash = [0; 32];
|
|
|
|
|
hash.copy_from_slice(tx);
|
|
|
|
|
let tx = provider.get_transaction_by_hash(hash.into()).await.unwrap()?;
|
|
|
|
|
let (tx, sig, _) = Signed::<TxLegacy>::try_from(tx).unwrap().into_parts();
|
|
|
|
|
let mut bytes = vec![];
|
|
|
|
|
tx.encode_with_signature_fields(&sig, &mut bytes);
|
|
|
|
|
Some(bytes)
|
2024-05-22 18:50:11 -04:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
// This is being passed a signature. We need to check the relayer has a TX with this
|
|
|
|
|
// signature
|
|
|
|
|
|
|
|
|
|
use tokio::{
|
|
|
|
|
io::{AsyncReadExt, AsyncWriteExt},
|
|
|
|
|
net::TcpStream,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let (ip, port) = ops.handle(&self.relayer_handle).host_port(20831).unwrap();
|
|
|
|
|
let relayer_url = format!("{ip}:{port}");
|
|
|
|
|
|
|
|
|
|
let mut socket = TcpStream::connect(&relayer_url).await.unwrap();
|
|
|
|
|
// Iterate over every published command
|
|
|
|
|
for i in 1 .. u32::MAX {
|
|
|
|
|
socket.write_all(&i.to_le_bytes()).await.unwrap();
|
|
|
|
|
|
|
|
|
|
let mut recvd_len = [0; 4];
|
|
|
|
|
socket.read_exact(&mut recvd_len).await.unwrap();
|
|
|
|
|
if recvd_len == [0; 4] {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let mut msg = vec![0; usize::try_from(u32::from_le_bytes(recvd_len)).unwrap()];
|
|
|
|
|
socket.read_exact(&mut msg).await.unwrap();
|
|
|
|
|
for start_pos in 0 .. msg.len() {
|
|
|
|
|
if (start_pos + tx.len()) > msg.len() {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
if &msg[start_pos .. (start_pos + tx.len())] == tx {
|
|
|
|
|
return Some(msg);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
None
|
2024-05-14 01:33:55 -04:00
|
|
|
}
|
2023-07-30 07:00:54 -04:00
|
|
|
NetworkId::Monero => {
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
use monero_simple_request_rpc::SimpleRequestRpc;
|
|
|
|
|
use monero_wallet::rpc::Rpc;
|
2023-07-30 07:00:54 -04:00
|
|
|
|
Clean the Monero lib for auditing (#577)
* Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+
* Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
* Make CLSAG signing private
Also adds a bit more documentation and does a bit more tidying.
* Remove the distribution cache
It's a notable bandwidth/performance improvement, yet it's not ready. We need a
dedicated Distribution struct which is managed by the wallet and passed in.
While we can do that now, it's not currently worth the effort.
* Tidy Borromean/MLSAG a tad
* Remove experimental feature from monero-serai
* Move amount_decryption into EncryptedAmount::decrypt
* Various RingCT doc comments
* Begin crate smashing
* Further documentation, start shoring up API boundaries of existing crates
* Document and clean clsag
* Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally.
Also moves the tests from monero-serai to monero-clsag.
* Smash out monero-bulletproofs
Removes usage of dalek-ff-group/multiexp for curve25519-dalek.
Makes compiling in the generators an optional feature.
Adds a structured batch verifier which should be notably more performant.
Documentation and clean up still necessary.
* Correct no-std builds for monero-clsag and monero-bulletproofs
* Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
* Error if missing documentation
* Smash out MLSAG
* Smash out Borromean
* Tidy up monero-serai as a meta crate
* Smash out RPC, wallet
* Document the RPC
* Improve docs a bit
* Move Protocol to monero-wallet
* Incomplete work on using Option to remove panic cases
* Finish documenting monero-serai
* Remove TODO on reading pseudo_outs for AggregateMlsagBorromean
* Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
* Smash out polyseed
* Smash out seed
* Get the repo to compile again
* Smash out Monero addresses
* Document cargo features
Credit to @hinto-janai for adding such sections to their work on documenting
monero-serai in #568.
* Fix deserializing v2 miner transactions
* Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much
cleaner, albeit slower due to redoing work.
This compiles with clippy --all-features. I have to finish the multisig/builder
for --all-targets to work (and start updating the rest of Serai).
* Add SignableTransaction Read/Write
* Restore Monero multisig TX code
* Correct invalid RPC type def in monero-rpc
* Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too
young. I'm unsure what's up with that. Most seem to pass _consistently_,
implying it's not a random issue yet some configuration/env aspect.
* Clean and document monero-address
* Sync rest of repo with monero-serai changes
* Represent height/block number as a u32
* Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner
Also cleans the Scanner impl.
* Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key
images causing zeroing the ECDH to not zero the shared key.
* Finish documenting monero-serai
* Correct imports for no-std
* Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
* Restore the reserialize chain binary
* fmt, machete, GH CI
* Correct misc TODOs in monero-serai
* Have Monero test runner evaluate an Eventuality for all signed TXs
* Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
* Fix remaining bugs in monero-wallet tests
* Reject torsioned spend keys to ensure we can spend the outputs we scan
* Tidy inlined epee code in the RPC
* Correct the accidental swap of stagenet/testnet address bytes
* Remove unused dep from processor
* Handle Monero fee logic properly in the processor
* Document v2 TX/RCT output relation assumed when scanning
* Adjust how we mine the initial blocks due to some CI test failures
* Fix weight estimation for RctType::ClsagBulletproof TXs
* Again increase the amount of blocks we mine prior to running tests
* Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
* Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing.
https://github.com/monero-project/monero/issues/9141 for the upstream.
* Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
* Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
* Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The
prior code wouldn't check that amount is greater than or equal to the necessary
fee, and returning the would-be change amount as the fee isn't necessarily
helpful.
Now the fee is validated in such cases and the necessary fee is returned,
enabling operating off of that.
* Restore minimum Monero fee from develop
2024-07-07 03:57:18 -07:00
|
|
|
let rpc = SimpleRequestRpc::new(rpc_url)
|
|
|
|
|
.await
|
|
|
|
|
.expect("couldn't connect to the coordinator's Monero RPC");
|
2023-07-30 07:00:54 -04:00
|
|
|
let mut hash = [0; 32];
|
|
|
|
|
hash.copy_from_slice(tx);
|
|
|
|
|
if let Ok(tx) = rpc.get_transaction(hash).await {
|
|
|
|
|
Some(tx.serialize())
|
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
NetworkId::Serai => panic!("processor tests broadcasting block to Serai"),
|
|
|
|
|
}
|
|
|
|
|
}
|
2023-07-24 20:06:05 -04:00
|
|
|
}
|